Account - Code Metrics - edno/kleis - Measure and Improve Code Quality continuously with Scrutinizer

Account A
last analyzed 2019-08-20 11:53 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	71
Duplicated Lines	11.27 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	10
lcom	1
cbo	2
dl	8
loc	71
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	group()	0	4	1

How to fix Duplicated Code

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
use App\User;

use WhiteHat101\Crypt\APR1_MD5;

class Account extends Model
{
    const ACCOUNT_DISABLE = 0;
    const ACCOUNT_ENABLE = 1;

    const ACCOUNT_STATUS = [
        0 => [  'text' => 'accounts.disabled',
                'icon' => 'fa-ban',
                'unicon' => '&#xf05e;' ],
        1 => [  'text' => 'accounts.enabled',
                'icon' => 'fa-globe',
                'unicon' => '&#xf0ac;' ]
    ];

    const SEARCH_CRITERIA = [
        'account' => ['netlogin'],
        'fullname' => ['firstname', 'lastname'],
        'group' => [['group' => 'name']],
    ];

    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = ['firstname', 'lastname', 'netlogin', 'netpass', 'expire', 'status', 'group_id', 'category_id', 'created_by'];

    public function creator()
    {
        return $this->hasOne('App\User', 'created_by');
    }

    public function group()
    {
        return $this->hasOne('App\Group', 'id', 'group_id');
    }

    public function getStatus()
    {
        if (array_key_exists((int)$this->status, self::ACCOUNT_STATUS)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return self::ACCOUNT_STATUS[(int)$this->status];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } else {
            return null;
        }
    }

    public function category()
    {
        return $this->hasOne('App\Category', 'id', 'category_id');
    }

    public static function generateHash($password)
    {
        return APR1_MD5::hash($password);
    }

    public function enable()
    {
        $this->status = 1;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if (empty($this->expire) || $this->expire <= date('Y-m-d')) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->expire = date_create('+90 day')->format('Y-m-d');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        $this->update();
    }

    public function disable()
    {
        $this->status = 0;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->update();
    }
}


1		<?php
2
3		namespace App;
4
5		use Illuminate\Database\Eloquent\Model;
6		use App\User;
7
8		use WhiteHat101\Crypt\APR1_MD5;
9
10		class Account extends Model
11		{
12		const ACCOUNT_DISABLE = 0;
13		const ACCOUNT_ENABLE = 1;
14
15		const ACCOUNT_STATUS = [
16		0 => [ 'text' => 'accounts.disabled',
17		'icon' => 'fa-ban',
18		'unicon' => '' ],
19		1 => [ 'text' => 'accounts.enabled',
20		'icon' => 'fa-globe',
21		'unicon' => '' ]
22		];
23
24		const SEARCH_CRITERIA = [
25		'account' => ['netlogin'],
26		'fullname' => ['firstname', 'lastname'],
27		'group' => [['group' => 'name']],
28		];
29
30		/**
31		* The attributes that are mass assignable.
32		*
33		* @var array
34		*/
35		protected $fillable = ['firstname', 'lastname', 'netlogin', 'netpass', 'expire', 'status', 'group_id', 'category_id', 'created_by'];
36
37		public function creator()
38		{
39		return $this->hasOne('App\User', 'created_by');
40		}
41
42		public function group()
43		{
44		return $this->hasOne('App\Group', 'id', 'group_id');
45		}
46
47	View Code Duplication	public function getStatus()
48		{
49		if (array_key_exists((int)$this->status, self::ACCOUNT_STATUS)) {
		0 ignored issues – show Documentation introduced 2017-02-03 22:41 UTC by Report Bug Copy Issue Report The property `status` does not exist on `object<App\Account>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
50		return self::ACCOUNT_STATUS[(int)$this->status];
		0 ignored issues – show Documentation introduced 2017-02-03 22:41 UTC by Report Bug Copy Issue Report The property `status` does not exist on `object<App\Account>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
51		} else {
52		return null;
53		}
54		}
55
56		public function category()
57		{
58		return $this->hasOne('App\Category', 'id', 'category_id');
59		}
60
61		public static function generateHash($password)
62		{
63		return APR1_MD5::hash($password);
64		}
65
66		public function enable()
67		{
68		$this->status = 1;
		0 ignored issues – show Documentation introduced 2017-02-03 22:41 UTC by Report Bug Copy Issue Report The property `status` does not exist on `object<App\Account>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
69		if (empty($this->expire) \|\| $this->expire <= date('Y-m-d')) {
		0 ignored issues – show Documentation introduced 2017-02-03 22:41 UTC by Report Bug Copy Issue Report The property `expire` does not exist on `object<App\Account>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
70		$this->expire = date_create('+90 day')->format('Y-m-d');
		0 ignored issues – show Documentation introduced 2017-02-03 22:41 UTC by Report Bug Copy Issue Report The property `expire` does not exist on `object<App\Account>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
71		}
72		$this->update();
73		}
74
75		public function disable()
76		{
77		$this->status = 0;
		0 ignored issues – show Documentation introduced 2017-02-03 22:41 UTC by Report Bug Copy Issue Report The property `status` does not exist on `object<App\Account>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
78		$this->update();
79		}
80		}
81

edno / kleis

Account A last analyzed 2019-08-20 11:53 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Account A
last analyzed 2019-08-20 11:53 UTC