EdmondsCommerce\PHPQA\PHPUnit\RerunCommandGenerator

Complexity

Total Complexity

11

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	load()	0	11	3
C	main()	0	34	7
A	getDefaultFilePath()	0	3	1

<?php declare(strict_types=1);

namespace EdmondsCommerce\PHPQA\PHPUnit;

use EdmondsCommerce\PHPQA\Helper;

class RerunCommandGenerator
{
    /**
     * no failed tests so just include all
     * however, this can confuse bash - try using `set -f` to disable globbing
     */
    public const NO_FILTER = '/.*/';

    /**
     * @var string
     */
    private $logPath;

    /**
     * @var \SimpleXMLElement
     */
    private $simpleXml;

    private $toRerun = [];

    public function main(string $junitLogPath = null): string
    {
        $this->toRerun = [];
        $this->logPath = $junitLogPath ?? $this->getDefaultFilePath();
        if (!file_exists($this->logPath)) {
            return self::NO_FILTER;
        }
        $contents = file_get_contents($this->logPath);
        if ('' === $contents) {
            return self::NO_FILTER;
        }
        $this->load($contents);
        $failureNodes = $this->simpleXml->xpath(
            '//testsuite/testcase[error] | //testsuite/testcase[failure] '
            .'| //testsuite/testcase[skipped] | //testsuite/testcase[incomplete]'
        );
        foreach ($failureNodes as $testCaseNode) {
            $attributes              = $testCaseNode->attributes();
            $class                   = str_replace('\\', '\\\\', (string)$attributes->class);
            $this->toRerun[$class][] = (string)$attributes->name;
        }
        if ($this->toRerun === []) {
            return self::NO_FILTER;
        }
        $command = '/(';
        foreach ($this->toRerun as $class => $testNames) {
            foreach ($testNames as $testName) {
                $command .= "$class::$testName|";
            }
        }
        $command = rtrim($command, '|');
        $command .= ')/';

        return $command;
    }


    protected function load(string $contents)
    {

        libxml_use_internal_errors(true);
        $this->simpleXml = simplexml_load_string($contents);

It seems like simplexml_load_string($contents) can also be of type false. However, the property $simpleXml is declared as type SimpleXMLElement. Maybe add an additional type check?

        if (false === $this->simpleXml) {
            $message = "Failed loading XML\n";
            foreach (libxml_get_errors() as $error) {
                $message .= "\n\t".$error->message;
            }
            throw new \RuntimeException($message);
        }
    }

    /**
     * @return string
     * @throws \Exception
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    protected function getDefaultFilePath(): string
    {
        return Helper::getProjectRootDirectory().'/var/qa/phpunit.junit.log.xml';
    }
}