Issues in TemplateEntityRepository.php - New Issues - Inspection of "Merge pull request #148 from edmondscommerce/Fixin..." - edmondscommerce/doctrine-static-meta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 75bdf9...8faa57 )

by joseph

created 2018-09-26 07:35 UTC

Entity/Repositories/TemplateEntityRepository.php (6 issues)

Labels

Bug 3

Severity

<?php declare(strict_types=1);

namespace TemplateNamespace\Entity\Repositories;

use TemplateNamespace\Entity\Repositories\AbstractEntityRepository;
use TemplateNamespace\Entity\Interfaces\TemplateEntityInterface;

// phpcs:disable -- line length
class TemplateEntityRepository extends AbstractEntityRepository
{
// phpcs: enable

    public function find($id, ?int $lockMode = null, ?int $lockVersion = null): ?TemplateEntityInterface
    {
        $result = parent::find($id, $lockMode, $lockVersion);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        if ($result === null || $result instanceof TemplateEntityInterface) {

            return $result;
        }

        throw new \RuntimeException('Unknown entity type of ' . \get_class($result) . ' returned');
    }

    public function get($id, ?int $lockMode = null, ?int $lockVersion = null): TemplateEntityInterface
    {
        $result = parent::get($id, $lockMode, $lockVersion);
        if ($result instanceof TemplateEntityInterface) {
            return $result;
        }
        throw new \RuntimeException('Unknown entity type of ' . \get_class($result) . ' returned');
    }

    public function getOneBy(array $criteria, ?array $orderBy = null): TemplateEntityInterface
    {
        $result = $this->findOneBy($criteria, $orderBy);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        if ($result === null) {

            throw new \RuntimeException('Could not find the entity');
        }

        return $result;
    }

    public function findOneBy(array $criteria, ?array $orderBy = null): ?TemplateEntityInterface
    {
        $result = parent::findOneBy($criteria, $orderBy);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        if ($result === null || $result instanceof TemplateEntityInterface) {

            return $result;
        }

        throw new \RuntimeException('Unknown entity type of ' . \get_class($result) . ' returned');
    }
}


1			<?php declare(strict_types=1);
2
3			namespace TemplateNamespace\Entity\Repositories;
4
5			use TemplateNamespace\Entity\Repositories\AbstractEntityRepository;
6			use TemplateNamespace\Entity\Interfaces\TemplateEntityInterface;
7
8			// phpcs:disable -- line length
9			class TemplateEntityRepository extends AbstractEntityRepository
10			{
11			// phpcs: enable
12
13			public function find($id, ?int $lockMode = null, ?int $lockVersion = null): ?TemplateEntityInterface
14			{
15			$result = parent::find($id, $lockMode, $lockVersion);
			0 ignored issues – show Bug introduced 2018-09-26 08:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$result` is correct as `parent::find($id, $lockMode, $lockVersion)` targeting `EdmondsCommerce\Doctrine...ntityRepository::find()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
16			if ($result === null \|\| $result instanceof TemplateEntityInterface) {
			0 ignored issues – show introduced 2018-09-26 08:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this The condition `$result === null` is always `true`. Loading history...
17			return $result;
18			}
19
20			throw new \RuntimeException('Unknown entity type of ' . \get_class($result) . ' returned');
21			}
22
23			public function get($id, ?int $lockMode = null, ?int $lockVersion = null): TemplateEntityInterface
24			{
25			$result = parent::get($id, $lockMode, $lockVersion);
26			if ($result instanceof TemplateEntityInterface) {
27			return $result;
28			}
29			throw new \RuntimeException('Unknown entity type of ' . \get_class($result) . ' returned');
30			}
31
32			public function getOneBy(array $criteria, ?array $orderBy = null): TemplateEntityInterface
33			{
34			$result = $this->findOneBy($criteria, $orderBy);
			0 ignored issues – show Bug introduced 2018-09-26 08:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$result` is correct as `$this->findOneBy($criteria, $orderBy)` targeting `TemplateNamespace\Entity...Repository::findOneBy()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
35			if ($result === null) {
			0 ignored issues – show introduced 2018-09-26 08:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this The condition `$result === null` is always `true`. Loading history...
36			throw new \RuntimeException('Could not find the entity');
37			}
38
39			return $result;
40			}
41
42			public function findOneBy(array $criteria, ?array $orderBy = null): ?TemplateEntityInterface
43			{
44			$result = parent::findOneBy($criteria, $orderBy);
			0 ignored issues – show Bug introduced 2018-09-26 08:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$result` is correct as `parent::findOneBy($criteria, $orderBy)` targeting `EdmondsCommerce\Doctrine...Repository::findOneBy()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
45			if ($result === null \|\| $result instanceof TemplateEntityInterface) {
			0 ignored issues – show introduced 2018-09-26 08:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this The condition `$result === null` is always `true`. Loading history...
46			return $result;
47			}
48
49			throw new \RuntimeException('Unknown entity type of ' . \get_class($result) . ' returned');
50			}
51			}
52

GitHub Access Token became invalid

Push — master ( 75bdf9...8faa57 )

Entity/Repositories/TemplateEntityRepository.php (6 issues)

Labels

Severity

Introduced By

edmondscommerce / doctrine-static-meta

GitHub Access Token became invalid

Push — master ( 75bdf9...8faa57 )

Entity/Repositories/TemplateEntityRepository.php (6 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like