NonBinaryUuidFieldTrait::setId() - Code Metrics - Inspection of "Creating a non binary UUID field" - edmondscommerce/doctrine-static-meta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#139)

by joseph

created 2018-09-11 15:12 UTC

NonBinaryUuidFieldTrait::setId() A

↳ Parent: NonBinaryUuidFieldTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	6
nc	2
nop	1
dl	0
loc	11
ccs	0
cts	6
cp	0
crap	6
rs	10
c	0
b	0
f	0

<?php declare(strict_types=1);

namespace EdmondsCommerce\DoctrineStaticMeta\Entity\Fields\Traits\PrimaryKey;

use Doctrine\ORM\Mapping\Builder\ClassMetadataBuilder;
use EdmondsCommerce\DoctrineStaticMeta\MappingHelper;
use Ramsey\Uuid\Doctrine\UuidGenerator;
use Ramsey\Uuid\UuidInterface;

/**
 * This trait implements a text based UUID primary key which will then be stored as a string
 */
trait NonBinaryUuidFieldTrait
{
    /**
     * @var UuidInterface
     */
    private $id;

    /**
     * @param ClassMetadataBuilder $builder
     *
     * @see https://github.com/ramsey/uuid-doctrine#usage
     */
    protected static function metaForId(ClassMetadataBuilder $builder): void
    {
        $builder->createField('id', MappingHelper::TYPE_NON_BINARY_UUID)
                ->makePrimaryKey()
                ->nullable(false)
                ->unique(true)
                ->generatedValue('CUSTOM')
                ->setCustomIdGenerator(UuidGenerator::class)
                ->build();
    }

    public function getId(): ?UuidInterface
    {
        return $this->id;
    }

    /**
     * @param UuidInterface $id
     *
     * @return UuidFieldTrait
     */
    public function setId(UuidInterface $id)
    {
        if (null !== $this->id) {
            throw new \RuntimeException(
                'You can not overwrite a UUID that has alreasy been set.' .
                ' This method should only be used for setting the ID on newly created Entities'
            );
        }
        $this->id = $id;

        return $this;

    }
}


1			<?php declare(strict_types=1);
2
3			namespace EdmondsCommerce\DoctrineStaticMeta\Entity\Fields\Traits\PrimaryKey;
4
5			use Doctrine\ORM\Mapping\Builder\ClassMetadataBuilder;
6			use EdmondsCommerce\DoctrineStaticMeta\MappingHelper;
7			use Ramsey\Uuid\Doctrine\UuidGenerator;
8			use Ramsey\Uuid\UuidInterface;
9
10			/**
11			* This trait implements a text based UUID primary key which will then be stored as a string
12			*/
13			trait NonBinaryUuidFieldTrait
14			{
15			/**
16			* @var UuidInterface
17			*/
18			private $id;
19
20			/**
21			* @param ClassMetadataBuilder $builder
22			*
23			* @see https://github.com/ramsey/uuid-doctrine#usage
24			*/
25			protected static function metaForId(ClassMetadataBuilder $builder): void
26			{
27			$builder->createField('id', MappingHelper::TYPE_NON_BINARY_UUID)
28			->makePrimaryKey()
29			->nullable(false)
30			->unique(true)
31			->generatedValue('CUSTOM')
32			->setCustomIdGenerator(UuidGenerator::class)
33			->build();
34			}
35
36			public function getId(): ?UuidInterface
37			{
38			return $this->id;
39			}
40
41			/**
42			* @param UuidInterface $id
43			*
44			* @return UuidFieldTrait
45			*/
46			public function setId(UuidInterface $id)
47			{
48			if (null !== $this->id) {
49			throw new \RuntimeException(
50			'You can not overwrite a UUID that has alreasy been set.' .
51			' This method should only be used for setting the ID on newly created Entities'
52			);
53			}
54			$this->id = $id;
55
56			return $this;
			0 ignored issues – show Bug Best Practice introduced 2018-09-11 15:46 UTC by Report Bug Copy Issue Report The expression `return $this` returns the type `EdmondsCommerce\Doctrine...NonBinaryUuidFieldTrait` which is incompatible with the documented return type `EdmondsCommerce\Doctrine...imaryKey\UuidFieldTrait`. Loading history...
57			}
58			}
59

edmondscommerce / doctrine-static-meta

GitHub Access Token became invalid

Pull Request — master (#139)

NonBinaryUuidFieldTrait::setId() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like