edmondscommerce / doctrine-static-meta

src/Entity/Fields/Traits/String/IsbnFieldTrait.php

<?php declare(strict_types=1);

namespace EdmondsCommerce\DoctrineStaticMeta\Entity\Fields\Traits\String;

// phpcs:disable

use Doctrine\ORM\Mapping\Builder\ClassMetadataBuilder;
use EdmondsCommerce\DoctrineStaticMeta\Entity\Fields\Interfaces\String\IsbnFieldInterface;
use EdmondsCommerce\DoctrineStaticMeta\MappingHelper;
use Symfony\Component\Validator\Constraints\Isbn;
use Symfony\Component\Validator\Mapping\ClassMetadata as ValidatorClassMetaData;

// phpcs:enable
trait IsbnFieldTrait
{

    /**
     * @var string|null
     */
    private $isbn;

    /**
     * @SuppressWarnings(PHPMD.StaticAccess)
     * @param ClassMetadataBuilder $builder
     */
    public static function metaForIsbn(ClassMetadataBuilder $builder): void
    {
        MappingHelper::setSimpleStringFields(
            [IsbnFieldInterface::PROP_ISBN],
            $builder,
            IsbnFieldInterface::DEFAULT_ISBN,
            true
        );
    }

    /**
     * This method sets the validation for this field.
     *
     * You should add in as many relevant property constraints as you see fit.
     *
     * @param ValidatorClassMetaData $metadata
     *
     * @throws \Symfony\Component\Validator\Exception\MissingOptionsException
     * @throws \Symfony\Component\Validator\Exception\InvalidOptionsException
     * @throws \Symfony\Component\Validator\Exception\ConstraintDefinitionException
     */
    protected static function validatorMetaForPropertyIsbn(ValidatorClassMetaData $metadata): void
    {
        $metadata->addPropertyConstraint(
            IsbnFieldInterface::PROP_ISBN,
            new Isbn()
        );
    }

    /**
     * @return string|null
     */
    public function getIsbn(): ?string
    {
        if (null === $this->isbn) {
            return IsbnFieldInterface::DEFAULT_ISBN;
        }

        return $this->isbn;
    }

    /**
     * @param string|null $isbn
     *
     * @return self
     */
    private function setIsbn(?string $isbn): self
    {
        $this->updatePropertyValue(

It seems like updatePropertyValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            IsbnFieldInterface::PROP_ISBN,
            $isbn
        );

        return $this;
    }
}