edmondscommerce / doctrine-static-meta

src/Entity/Fields/Traits/DateTime/DateTimeSettableNoDefaultFieldTrait.php

<?php declare(strict_types=1);

namespace EdmondsCommerce\DoctrineStaticMeta\Entity\Fields\Traits\DateTime;

use Doctrine\ORM\Mapping\Builder\ClassMetadataBuilder;
use EdmondsCommerce\DoctrineStaticMeta\Entity\Fields\Interfaces\DateTime\DateTimeSettableNoDefaultFieldInterface;
use EdmondsCommerce\DoctrineStaticMeta\MappingHelper;

/**
 * Trait DateTimeSettableNoDefaultFieldTrait
 *
 * This field is a dateTime that you can set and update the value as you see fit with no defaults
 *
 * @package EdmondsCommerce\DoctrineStaticMeta\Entity\Fields\Traits\DateTime
 */
trait DateTimeSettableNoDefaultFieldTrait
{

    /**
     * @var \DateTime|null
     */
    private $dateTimeSettableNoDefault;

    /**
     * @SuppressWarnings(PHPMD.StaticAccess)
     * @param ClassMetadataBuilder $builder
     */
    public static function metaForDateTimeSettableNoDefault(ClassMetadataBuilder $builder): void
    {
        MappingHelper::setSimpleDatetimeFields(
            [DateTimeSettableNoDefaultFieldInterface::PROP_DATE_TIME_SETTABLE_NO_DEFAULT],
            $builder,
            DateTimeSettableNoDefaultFieldInterface::DEFAULT_DATE_TIME_SETTABLE_NO_DEFAULT
        );
    }

    /**
     * @return \DateTime|null
     */
    public function getDateTimeSettableNoDefault(): ?\DateTime
    {
        if (null === $this->dateTimeSettableNoDefault) {
            return DateTimeSettableNoDefaultFieldInterface::DEFAULT_DATE_TIME_SETTABLE_NO_DEFAULT;
        }

        return $this->dateTimeSettableNoDefault;
    }

    /**
     * @param \DateTime|null $dateTimeSettableNoDefault
     *
     * @return self
     */
    private function setDateTimeSettableNoDefault(?\DateTime $dateTimeSettableNoDefault): self
    {
        $this->updatePropertyValue(

It seems like updatePropertyValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            DateTimeSettableNoDefaultFieldInterface::PROP_DATE_TIME_SETTABLE_NO_DEFAULT,
            $dateTimeSettableNoDefault
        );

        return $this;
    }
}