TemplateEntityIsValidConstraint::getTargets() - Code Metrics - Inspection of "Required relations" - edmondscommerce/doctrine-static-meta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#152)

by joseph

created 2018-10-29 17:36 UTC

TemplateEntityIsValidConstraint::getTargets() A

↳ Parent: TemplateEntityIsValidConstraint

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php declare(strict_types=1);

namespace TemplateNamespace\Validation\Constraints;

use Symfony\Component\Validator\Constraint;

/**
 * This is a template Entity constraint.
 *
 * The Constraint does very little other than specify a message and imply a
 * ConstraintValidator with the same FQN as this class, but with `Validator` appended.
 *
 * @see https://symfony.com/doc/2.6/cookbook/validation/custom_constraint.html
 *
 * Suggest using the `./bin/doctrine dsm:override:create` command to create a new
 * override straight after you generate the file.
 *
 * Then you can edit it and update your override as required using
 * `./bin/doctrine dsm:overrides:update -a fromProject`
 *
 * And then reapply after a new build using
 * `./bin/doctrine dsm:overrides:update -a toProject`
 *
 */
class TemplateEntityIsValidConstraint extends Constraint
{
    public const VALUE_TYPE = 'TemplateEntity';

    public const MESSAGE = 'The value {{ string }} is not a valid ' . self::VALUE_TYPE;

    public $message = self::MESSAGE;


    /**
     * Returns whether the constraint can be put onto classes, properties or
     * both.
     *
     * This method should return one or more of the constants
     * self::CLASS_CONSTRAINT and self::PROPERTY_CONSTRAINT.
     *
     * @return string|array One or more constant values
     */
    public function getTargets(): string
    {
        self::CLASS_CONSTRAINT;
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }
}

1			<?php declare(strict_types=1);
2
3			namespace TemplateNamespace\Validation\Constraints;
4
5			use Symfony\Component\Validator\Constraint;
6
7			/**
8			* This is a template Entity constraint.
9			*
10			* The Constraint does very little other than specify a message and imply a
11			* ConstraintValidator with the same FQN as this class, but with `Validator` appended.
12			*
13			* @see https://symfony.com/doc/2.6/cookbook/validation/custom_constraint.html
14			*
15			* Suggest using the `./bin/doctrine dsm:override:create` command to create a new
16			* override straight after you generate the file.
17			*
18			* Then you can edit it and update your override as required using
19			* `./bin/doctrine dsm:overrides:update -a fromProject`
20			*
21			* And then reapply after a new build using
22			* `./bin/doctrine dsm:overrides:update -a toProject`
23			*
24			*/
25			class TemplateEntityIsValidConstraint extends Constraint
26			{
27			public const VALUE_TYPE = 'TemplateEntity';
28
29			public const MESSAGE = 'The value {{ string }} is not a valid ' . self::VALUE_TYPE;
30
31			public $message = self::MESSAGE;
32
33
34			/**
35			* Returns whether the constraint can be put onto classes, properties or
36			* both.
37			*
38			* This method should return one or more of the constants
39			* self::CLASS_CONSTRAINT and self::PROPERTY_CONSTRAINT.
40			*
41			* @return string\|array One or more constant values
42			*/
43			public function getTargets(): string
44			{
45			self::CLASS_CONSTRAINT;
			0 ignored issues – show Bug Best Practice introduced 2018-10-29 16:55 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `string`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
46			}
47			}

edmondscommerce / doctrine-static-meta

GitHub Access Token became invalid

Pull Request — master (#152)

TemplateEntityIsValidConstraint::getTargets() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like