Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php declare(strict_types=1); |
||
12 | trait ValidateTrait |
||
13 | { |
||
14 | protected $needsValidating = false; |
||
15 | |||
16 | /** |
||
17 | * @param ValidatorClassMetaData $metadata |
||
18 | * |
||
19 | * @throws DoctrineStaticMetaException |
||
20 | */ |
||
21 | public static function loadValidatorMetaData(ValidatorClassMetaData $metadata): void |
||
26 | |||
27 | public static function getPropertyValidatorMetaFor(ClassMetadata $metadata) |
||
31 | |||
32 | /** |
||
33 | * @param ValidatorClassMetaData $metadata |
||
34 | * |
||
35 | * @throws DoctrineStaticMetaException |
||
36 | */ |
||
37 | View Code Duplication | protected static function loadPropertyValidatorMetaData(ValidatorClassMetaData $metadata): void |
|
60 | |||
61 | public function setValidated() |
||
66 | |||
67 | public function setNeedsValidating() |
||
72 | |||
73 | public function needsValidating(): bool |
||
77 | } |
||
78 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.