EdmondsCommerce\DoctrineStaticMeta\CodeGeneration\Creation\Process\ReplaceTypeHintsProcess

Complexity

Total Complexity

2

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	run()	0	11	1

<?php declare(strict_types=1);

namespace EdmondsCommerce\DoctrineStaticMeta\CodeGeneration\Creation\Process;

use EdmondsCommerce\DoctrineStaticMeta\CodeGeneration\CodeHelper;
use EdmondsCommerce\DoctrineStaticMeta\CodeGeneration\Filesystem\File;

class ReplaceTypeHintsProcess implements ProcessInterface
{
    /**
     * @var CodeHelper
     */
    private $codeHelper;
    /**
     * @var string
     */
    private $mappingHelperType;
    /**
     * @var bool
     */
    private $nullable;
    /**
     * @var string
     */
    private $phpType;

    public function __construct(CodeHelper $codeHelper, string $phpType, string $mappingHelperType, $defaultValue)
    {
        $this->codeHelper        = $codeHelper;
        $this->phpType           = $phpType;
        $this->mappingHelperType = $mappingHelperType;
        $this->nullable          = (null === $defaultValue);

    }

    public function run(File\FindReplace $findReplace): void
    {
        $file     = $findReplace->getFile();
        $contents = $file->getContents();
        $contents = $this->codeHelper->replaceTypeHintsInContents(
            $contents,

It seems like $contents can also be of type null; however, parameter $contents of EdmondsCommerce\DoctrineStaticMeta\CodeGeneration\CodeHelper::replaceTypeHintsInContents() does only seem to accept string, maybe add an additional type check?

            $this->phpType,
            $this->mappingHelperType,
            $this->nullable
        );
        $file->setContents($contents);
    }
}