ExpressionBuilder - Code Metrics - edgardmessias/yii2-firebird - Measure and Improve Code Quality continuously with Scrutinizer

ExpressionBuilder A
last analyzed 2018-04-18 18:56 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	2
c	0
b	0
f	0
lcom	0
cbo	1
dl	0
loc	25
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	build()	0	15	2

<?php
/**
 * @link http://www.yiiframework.com/
 * @copyright Copyright (c) 2008 Yii Software LLC
 * @license http://www.yiiframework.com/license/
 */

namespace edgardmessias\db\firebird;

use yii\db\Expression;
use yii\db\ExpressionBuilderInterface;
use yii\db\ExpressionBuilderTrait;
use yii\db\ExpressionInterface;

/**
 * {@inheritdoc}
 */
class ExpressionBuilder implements ExpressionBuilderInterface
{
    use ExpressionBuilderTrait;


    /**
     * {@inheritdoc}
     * @param Expression|ExpressionInterface $expression the expression to be built
     */
    public function build(ExpressionInterface $expression, array &$params = [])
    {
        $params = array_merge($params, $expression->params);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $string = $expression->__toString();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        
        static $expressionMap = [
            "strftime('%Y')" => "EXTRACT(YEAR FROM TIMESTAMP 'now')"
        ];
        
        if (isset($expressionMap[$string])) {
            return $expressionMap[$string];
        }
        
        return $string;
    }
}


ExpressionBuilder A
last analyzed 2018-04-18 18:56 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Available Fixes

Available Fixes

1			<?php
2			/**
3			* @link http://www.yiiframework.com/
4			* @copyright Copyright (c) 2008 Yii Software LLC
5			* @license http://www.yiiframework.com/license/
6			*/
7
8			namespace edgardmessias\db\firebird;
9
10			use yii\db\Expression;
11			use yii\db\ExpressionBuilderInterface;
12			use yii\db\ExpressionBuilderTrait;
13			use yii\db\ExpressionInterface;
14
15			/**
16			* {@inheritdoc}
17			*/
18			class ExpressionBuilder implements ExpressionBuilderInterface
19			{
20			use ExpressionBuilderTrait;
21
22
23			/**
24			* {@inheritdoc}
25			* @param Expression\|ExpressionInterface $expression the expression to be built
26			*/
27			public function build(ExpressionInterface $expression, array &$params = [])
28			{
29			$params = array_merge($params, $expression->params);
			0 ignored issues – show Bug introduced 2018-04-02 18:11 UTC by Report Bug Copy Issue Report Accessing `params` on the interface `yii\db\ExpressionInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
30			$string = $expression->__toString();
			0 ignored issues – show Bug introduced 2018-04-02 18:11 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `yii\db\ExpressionInterface` as the method `__toString()` does only exist in the following implementations of said interface: `yii\db\ActiveQuery`, `yii\db\Expression`, `yii\db\Query`, `yiiunit\data\ar\CustomerQuery`, `yiiunit\framework\db\UnqueryableQueryMock`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
31
32			static $expressionMap = [
33			"strftime('%Y')" => "EXTRACT(YEAR FROM TIMESTAMP 'now')"
34			];
35
36			if (isset($expressionMap[$string])) {
37			return $expressionMap[$string];
38			}
39
40			return $string;
41			}
42			}
43

edgardmessias / yii2-firebird

ExpressionBuilder A last analyzed 2018-04-18 18:56 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

ExpressionBuilder A
last analyzed 2018-04-18 18:56 UTC