Blacklist::add() - Code Metrics - edenleung/think-jwt - Measure and Improve Code Quality continuously with Scrutinizer

Blacklist::add() A
last analyzed 2020-03-22 09:45 UTC

↳ Parent: Blacklist

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	4
nc	2
nop	1
dl	0
loc	6
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace xiaodi\JWTAuth;

use Lcobucci\JWT\Token;
use think\App;

/**
 * 黑名单.
 */
class Blacklist
{
    private $app;

    private $store;

    protected $cacheName = 'blacklist';

    public function __construct(App $app)
    {
        $this->app = $app;

        $this->store = $this->getStore();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $configs = $this->getConfig();

        foreach ($configs as $key => $config) {
            $this->$key = $config;
        }
    }

    public function getConfig()
    {
        return $this->app->config->get('jwt.blacklist', []);
    }

    /**
     * 获取 缓存驱动.
     *
     * @return void
     */
    public function getStore()
    {
        return $this->app->cache;

    }

    /**
     * 加入黑名单.
     *
     * @param Token $token
     *
     * @return void
     */
    public function add(Token $token)
    {
        if (false === $this->has($token)) {
            $claims = $token->getClaims();
            $exp = $claims['exp']->getValue() - time();
            $this->store->push($this->cacheName, (string) $token, $exp);
        }
    }

    /**
     * 是否存在黑名单.
     *
     * @param Token $token
     *
     * @return bool
     */
    public function has(Token $token): bool
    {
        $blacklist = $this->getAll();

        return in_array((string) $token, $blacklist);
    }

    /**
     * 获取所有黑名单.
     *
     * @return array
     */
    public function getAll(): array
    {
        return $this->store->get($this->cacheName, []);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace xiaodi\JWTAuth;
6
7			use Lcobucci\JWT\Token;
8			use think\App;
9
10			/**
11			* 黑名单.
12			*/
13			class Blacklist
14			{
15			private $app;
16
17			private $store;
18
19			protected $cacheName = 'blacklist';
20
21			public function __construct(App $app)
22			{
23			$this->app = $app;
24
25			$this->store = $this->getStore();
			0 ignored issues – show Bug introduced 2020-03-17 08:07 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$this->store` is correct as `$this->getStore()` targeting `xiaodi\JWTAuth\Blacklist::getStore()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
26
27			$configs = $this->getConfig();
28
29			foreach ($configs as $key => $config) {
30			$this->$key = $config;
31			}
32			}
33
34			public function getConfig()
35			{
36			return $this->app->config->get('jwt.blacklist', []);
37			}
38
39			/**
40			* 获取缓存驱动.
41			*
42			* @return void
43			*/
44			public function getStore()
45			{
46			return $this->app->cache;
			0 ignored issues – show Bug Best Practice introduced 2020-03-16 07:54 UTC by Report Bug Copy Issue Report The expression `return $this->app->cache` returns the type `think\Cache` which is incompatible with the documented return type `void`. Loading history...
47			}
48
49			/**
50			* 加入黑名单.
51			*
52			* @param Token $token
53			*
54			* @return void
55			*/
56			public function add(Token $token)
57			{
58			if (false === $this->has($token)) {
59			$claims = $token->getClaims();
60			$exp = $claims['exp']->getValue() - time();
61			$this->store->push($this->cacheName, (string) $token, $exp);
62			}
63			}
64
65			/**
66			* 是否存在黑名单.
67			*
68			* @param Token $token
69			*
70			* @return bool
71			*/
72			public function has(Token $token): bool
73			{
74			$blacklist = $this->getAll();
75
76			return in_array((string) $token, $blacklist);
77			}
78
79			/**
80			* 获取所有黑名单.
81			*
82			* @return array
83			*/
84			public function getAll(): array
85			{
86			return $this->store->get($this->cacheName, []);
87			}
88			}
89

edenleung / think-jwt

Blacklist::add() A last analyzed 2020-03-22 09:45 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Blacklist::add() A
last analyzed 2020-03-22 09:45 UTC