Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
21 | class SocketBag implements SocketBagInterface |
||
22 | { |
||
23 | /** |
||
24 | * RequestExecutorInterface |
||
25 | * |
||
26 | * @var RequestExecutorInterface |
||
27 | */ |
||
28 | private $executor; |
||
29 | |||
30 | /** |
||
31 | * Target metadata items |
||
32 | * |
||
33 | * @var OperationMetadata[] |
||
34 | */ |
||
35 | private $items; |
||
36 | |||
37 | /** |
||
38 | * Default connection timeout |
||
39 | * |
||
40 | * @var double |
||
41 | */ |
||
42 | private $connectTimeout; |
||
43 | |||
44 | /** |
||
45 | * Default I/O timeout |
||
46 | * |
||
47 | * @var double |
||
48 | */ |
||
49 | private $ioTimeout; |
||
50 | |||
51 | /** |
||
52 | * SocketBag constructor. |
||
53 | * |
||
54 | * @param RequestExecutorInterface $executor Owner RequestExecutor |
||
55 | * @param double $connectTimeout Default connection timeout |
||
56 | * @param double $ioTimeout Default I/O timeout |
||
57 | */ |
||
58 | 152 | public function __construct(RequestExecutorInterface $executor, $connectTimeout, $ioTimeout) |
|
59 | { |
||
60 | 152 | $this->executor = $executor; |
|
61 | 152 | $this->items = [ ]; |
|
62 | 152 | $this->connectTimeout = $connectTimeout; |
|
63 | 152 | $this->ioTimeout = $ioTimeout; |
|
64 | 152 | } |
|
65 | |||
66 | /** {@inheritdoc} */ |
||
67 | 1 | public function count() |
|
71 | |||
72 | |||
73 | /** {@inheritdoc} */ |
||
74 | 141 | public function addSocket( |
|
75 | SocketInterface $socket, |
||
76 | OperationInterface $operation, |
||
77 | array $metadata = null, |
||
78 | EventHandlerInterface $eventHandlers = null |
||
79 | ) { |
||
80 | 141 | $hash = $this->getOperationStorageKey($socket); |
|
81 | 141 | if (isset($this->items[$hash])) { |
|
82 | 1 | throw new \LogicException('Can not add socket twice.'); |
|
83 | } |
||
84 | |||
85 | 141 | $meta = array_merge( |
|
86 | [ |
||
87 | 141 | RequestExecutorInterface::META_ADDRESS => null, |
|
88 | 141 | RequestExecutorInterface::META_USER_CONTEXT => null, |
|
89 | 141 | RequestExecutorInterface::META_SOCKET_STREAM_CONTEXT => null, |
|
90 | 141 | RequestExecutorInterface::META_CONNECTION_TIMEOUT => $this->connectTimeout, |
|
91 | 141 | RequestExecutorInterface::META_IO_TIMEOUT => $this->ioTimeout, |
|
92 | 141 | ], |
|
93 | 141 | $metadata ?: [], |
|
94 | [ |
||
95 | 141 | RequestExecutorInterface::META_CONNECTION_START_TIME => null, |
|
96 | 141 | RequestExecutorInterface::META_CONNECTION_FINISH_TIME => null, |
|
97 | 141 | RequestExecutorInterface::META_LAST_IO_START_TIME => null, |
|
98 | 141 | RequestExecutorInterface::META_REQUEST_COMPLETE => false, |
|
99 | ] |
||
100 | 141 | ); |
|
101 | |||
102 | 141 | $this->items[$hash] = new OperationMetadata($socket, $operation, $meta, $eventHandlers); |
|
103 | 141 | } |
|
104 | |||
105 | /** {@inheritdoc} */ |
||
106 | 1 | public function getSocketOperation(SocketInterface $socket) |
|
110 | |||
111 | /** {@inheritdoc} */ |
||
112 | 1 | public function setSocketOperation(SocketInterface $socket, OperationInterface $operation) |
|
116 | |||
117 | |||
118 | /** {@inheritdoc} */ |
||
119 | 3 | public function hasSocket(SocketInterface $socket) |
|
120 | { |
||
121 | 3 | $hash = $this->getOperationStorageKey($socket); |
|
122 | 3 | return isset($this->items[$hash]); |
|
123 | } |
||
124 | |||
125 | /** {@inheritdoc} */ |
||
126 | 3 | public function removeSocket(SocketInterface $socket) |
|
140 | |||
141 | /** {@inheritdoc} */ |
||
142 | View Code Duplication | public function postponeSocket(SocketInterface $socket) |
|
|
|||
143 | { |
||
151 | |||
152 | /** {@inheritdoc} */ |
||
153 | 84 | public function getSocketMetaData(SocketInterface $socket) |
|
157 | |||
158 | /** {@inheritdoc} */ |
||
159 | 9 | public function setSocketMetaData(SocketInterface $socket, $key, $value = null) |
|
176 | |||
177 | /** |
||
178 | * Return socket key in internal storage |
||
179 | * |
||
180 | * @param SocketInterface $socket Socket object |
||
181 | * |
||
182 | * @return string |
||
183 | */ |
||
184 | 143 | private function getOperationStorageKey(SocketInterface $socket) |
|
188 | |||
189 | /** |
||
190 | * Require operation metadata for given socket |
||
191 | * |
||
192 | * @param SocketInterface $socket Socket object |
||
193 | * |
||
194 | * @return OperationMetadata |
||
195 | * @throws \OutOfBoundsException |
||
196 | */ |
||
197 | 85 | View Code Duplication | private function requireOperation(SocketInterface $socket) |
206 | |||
207 | /** |
||
208 | * Return metadata items |
||
209 | * |
||
210 | * @return OperationMetadata[] |
||
211 | */ |
||
212 | 125 | public function getItems() |
|
216 | } |
||
217 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.