edefimov / async-sockets

src/RequestExecutor/Pipeline/AbstractTimeAwareStage.php

Spacing +3 added lines, -5 removed lines

@@ -41,8 +41,7 @@ 
     {
         $meta = $operation->getMetadata();
         return !$this->hasConnected($operation) ?
-            $meta[ RequestExecutorInterface::META_CONNECTION_TIMEOUT ] :
-            $meta[ RequestExecutorInterface::META_IO_TIMEOUT ];
+            $meta[RequestExecutorInterface::META_CONNECTION_TIMEOUT] : $meta[RequestExecutorInterface::META_IO_TIMEOUT];
     }
 
     /**
@@ -56,8 +55,7 @@ 
     {
         $meta = $operation->getMetadata();
         return !$this->hasConnected($operation) ?
-            $meta[ RequestExecutorInterface::META_CONNECTION_START_TIME ] :
-            $meta[ RequestExecutorInterface::META_LAST_IO_START_TIME ];
+            $meta[RequestExecutorInterface::META_CONNECTION_START_TIME] : $meta[RequestExecutorInterface::META_LAST_IO_START_TIME];
     }
 
     /**
@@ -74,7 +72,7 @@ 
         $meta  = $operationMetadata->getMetadata();
         $table = [
             RequestExecutorInterface::META_CONNECTION_START_TIME =>
-                $meta[ RequestExecutorInterface::META_CONNECTION_START_TIME ] === null,
+                $meta[RequestExecutorInterface::META_CONNECTION_START_TIME] === null,
 
             RequestExecutorInterface::META_CONNECTION_FINISH_TIME =>
                 $meta[RequestExecutorInterface::META_CONNECTION_FINISH_TIME] === null,

src/RequestExecutor/Pipeline/SelectStage.php

Doc Comments +1 added lines, -1 removed lines

@@ -137,7 +137,7 @@
      * @param OperationMetadata $operation Operation object
      * @param double $microTime Current time with microseconds
      *
-     * @return double|null
+     * @return double
      */
     private function getSingleSocketTimeout(OperationMetadata $operation, $microTime)
     {

Spacing +2 added lines, -4 removed lines

@@ -127,8 +127,7 @@ 
     private function getMinTimeout($newValue, $oldValue)
     {
         return (($newValue > 0 && $newValue < $oldValue) || $oldValue === null) ?
-            $newValue :
-            $oldValue;
+            $newValue : $oldValue;
     }
 
     /**
@@ -149,8 +148,7 @@ 
         }
 
         $result = $lastOperationTime === null ?
-            $desiredTimeout :
-            $desiredTimeout - ($microTime - $lastOperationTime);
+            $desiredTimeout : $desiredTimeout - ($microTime - $lastOperationTime);
 
         return $result >= 0 ? $result : 0;
     }

src/RequestExecutor/Pipeline/GuardianStage.php

Spacing +2 added lines, -2 removed lines

@@ -115,7 +115,7 @@ 
      */
     private function isZombieCandidate(RequestDescriptor $descriptor)
     {
-        $metadata  = $descriptor->getMetadata();
+        $metadata = $descriptor->getMetadata();
         if ($metadata[RequestExecutorInterface::META_REQUEST_COMPLETE]) {
             return false;
         }
@@ -164,7 +164,7 @@ 
         $event  = new DataAlertEvent(
             $this->executor,
             $socket,
-            $meta[ RequestExecutorInterface::META_USER_CONTEXT ],
+            $meta[RequestExecutorInterface::META_USER_CONTEXT],
             $attempt,
             $totalAttempts
         );

Indentation +2 added lines, -2 removed lines

@@ -123,9 +123,9 @@
         $operation = $descriptor->getOperation();
         return ($operation instanceof NullOperation) ||
                (
-                   $operation instanceof ReadOperation &&
+                    $operation instanceof ReadOperation &&
                    $operation->getFramePicker() instanceof EmptyFramePicker
-               );
+                );
     }
 
     /**

src/RequestExecutor/Pipeline/ExcludedOperationsStage.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
 
         foreach ($requestDescriptors as $key => $descriptor) {
             if (in_array($descriptor, $currentOperations, true)) {
-                unset($requestDescriptors[ $key]);
+                unset($requestDescriptors[$key]);
             }
         }
 

src/RequestExecutor/Pipeline/IoStage.php

Spacing +2 added lines, -2 removed lines

@@ -86,7 +86,7 @@ 
             }
         }
 
-        throw new \LogicException('There is no handler able to process ' . get_class($operation) . ' operation.');
+        throw new \LogicException('There is no handler able to process '.get_class($operation).' operation.');
     }
 
     /**
@@ -157,7 +157,7 @@ 
     private function setConnectionFinishTime(RequestDescriptor $requestDescriptor)
     {
         $meta         = $requestDescriptor->getMetadata();
-        $wasConnected = $meta[ RequestExecutorInterface::META_CONNECTION_FINISH_TIME ] !== null;
+        $wasConnected = $meta[RequestExecutorInterface::META_CONNECTION_FINISH_TIME] !== null;
         $this->setSocketOperationTime($requestDescriptor, RequestExecutorInterface::META_CONNECTION_FINISH_TIME);
         if (!$wasConnected) {
             $event = $this->createEvent($requestDescriptor, EventType::CONNECTED);

src/RequestExecutor/Pipeline/ConnectStage.php

Spacing +5 added lines, -5 removed lines

@@ -56,7 +56,7 @@ 
             } elseif ($decision === LimitationSolverInterface::DECISION_SKIP_CURRENT) {
                 continue;
             } elseif ($decision !== LimitationSolverInterface::DECISION_OK) {
-                throw new \LogicException('Unknown decision ' . $decision . ' received.');
+                throw new \LogicException('Unknown decision '.$decision.' received.');
             }
 
             if ($this->connectSocket($descriptor)) {
@@ -105,13 +105,13 @@ 
      */
     private function getStreamContextFromMetaData($meta)
     {
-        $metaStreamContext = $meta[ RequestExecutorInterface::META_SOCKET_STREAM_CONTEXT ];
+        $metaStreamContext = $meta[RequestExecutorInterface::META_SOCKET_STREAM_CONTEXT];
         if (is_resource($metaStreamContext)) {
             return $metaStreamContext;
         } elseif (is_array($metaStreamContext)) {
             return stream_context_create(
-                isset($metaStreamContext[ 'options' ]) ? $metaStreamContext[ 'options' ] : [ ],
-                isset($metaStreamContext[ 'params' ]) ? $metaStreamContext[ 'params' ] : [ ]
+                isset($metaStreamContext['options']) ? $metaStreamContext['options'] : [],
+                isset($metaStreamContext['params']) ? $metaStreamContext['params'] : []
             );
         }
 
@@ -139,7 +139,7 @@ 
             $meta = $descriptor->getMetadata();
 
             $socket->open(
-                $meta[ RequestExecutorInterface::META_ADDRESS ],
+                $meta[RequestExecutorInterface::META_ADDRESS],
                 $this->getStreamContextFromMetaData($meta)
             );
 

src/Operation/WriteOperation.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
      */
     public function __construct($data = null, $isOutOfBand = false)
     {
-        $this->data         = $data !== null ? (string) $data : null;
+        $this->data = $data !== null ? (string) $data : null;
         $this->isOutOfBand = $isOutOfBand;
     }
 

src/Exception/UnmanagedSocketException.php

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
             $socket,
             sprintf(
                 'System has detected a zombie connection %s and closed it. '.
-                'If you see this message it means that application ' .
+                'If you see this message it means that application '.
                 'has lost control on one of its sockets.',
                 (string) $socket
             )

src/Socket/AsyncSocketFactory.php

Spacing +6 added lines, -8 removed lines

@@ -74,19 +74,17 @@
     {
         switch ($type) {
             case self::SOCKET_CLIENT:
-                $isPersistent  = isset($options[ self::SOCKET_OPTION_IS_PERSISTENT ]) &&
-                                 $options[ self::SOCKET_OPTION_IS_PERSISTENT ];
-                $persistentKey = isset($options[ self::SOCKET_OPTION_PERSISTENT_KEY ]) ?
-                    $options[ self::SOCKET_OPTION_PERSISTENT_KEY ] :
-                    null;
+                $isPersistent  = isset($options[self::SOCKET_OPTION_IS_PERSISTENT]) &&
+                                 $options[self::SOCKET_OPTION_IS_PERSISTENT];
+                $persistentKey = isset($options[self::SOCKET_OPTION_PERSISTENT_KEY]) ?
+                    $options[self::SOCKET_OPTION_PERSISTENT_KEY] : null;
 
                 return $isPersistent ?
-                    new PersistentClientSocket($persistentKey) :
-                    new ClientSocket();
+                    new PersistentClientSocket($persistentKey) : new ClientSocket();
             case self::SOCKET_SERVER:
                 return new ServerSocket();
             default:
-                throw new \InvalidArgumentException("Unexpected type {$type} used in " . __FUNCTION__);
+                throw new \InvalidArgumentException("Unexpected type {$type} used in ".__FUNCTION__);
         }
     }