Completed
Branch feature-persistent-connect (647c46)
by Evgenij
03:19
created
src/RequestExecutor/Pipeline/IoStage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -155,7 +155,7 @@
 block discarded – undo
155 155
     private function setConnectionFinishTime(OperationMetadata $operationMetadata)
156 156
     {
157 157
         $meta         = $operationMetadata->getMetadata();
158
-        $wasConnected = $meta[ RequestExecutorInterface::META_CONNECTION_FINISH_TIME ] !== null;
158
+        $wasConnected = $meta[RequestExecutorInterface::META_CONNECTION_FINISH_TIME] !== null;
159 159
         $this->setSocketOperationTime($operationMetadata, RequestExecutorInterface::META_CONNECTION_FINISH_TIME);
160 160
         if (!$wasConnected) {
161 161
             $event = $this->createEvent($operationMetadata, EventType::CONNECTED);
Please login to merge, or discard this patch.
src/RequestExecutor/Pipeline/ConnectStage.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -105,13 +105,13 @@  discard block
 block discarded – undo
105 105
      */
106 106
     private function getStreamContextFromMetaData($meta)
107 107
     {
108
-        $metaStreamContext = $meta[ RequestExecutorInterface::META_SOCKET_STREAM_CONTEXT ];
108
+        $metaStreamContext = $meta[RequestExecutorInterface::META_SOCKET_STREAM_CONTEXT];
109 109
         if (is_resource($metaStreamContext)) {
110 110
             return $metaStreamContext;
111 111
         } elseif (is_array($metaStreamContext)) {
112 112
             return stream_context_create(
113
-                isset($metaStreamContext[ 'options' ]) ? $metaStreamContext[ 'options' ] : [ ],
114
-                isset($metaStreamContext[ 'params' ]) ? $metaStreamContext[ 'params' ] : [ ]
113
+                isset($metaStreamContext['options']) ? $metaStreamContext['options'] : [],
114
+                isset($metaStreamContext['params']) ? $metaStreamContext['params'] : []
115 115
             );
116 116
         }
117 117
 
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
             $this->setSocketOperationTime($item, RequestExecutorInterface::META_CONNECTION_START_TIME);
139 139
 
140 140
             $socket->open(
141
-                $meta[ RequestExecutorInterface::META_ADDRESS ],
141
+                $meta[RequestExecutorInterface::META_ADDRESS],
142 142
                 $this->getStreamContextFromMetaData($meta)
143 143
             );
144 144
 
Please login to merge, or discard this patch.
src/Socket/AsyncSocketFactory.php 1 patch
Spacing   +5 added lines, -7 removed lines patch added patch discarded remove patch
@@ -75,15 +75,13 @@
 block discarded – undo
75 75
     {
76 76
         switch ($type) {
77 77
             case self::SOCKET_CLIENT:
78
-                $isPersistent  = isset($options[ self::SOCKET_OPTION_IS_PERSISTENT ]) &&
79
-                                 $options[ self::SOCKET_OPTION_IS_PERSISTENT ];
80
-                $persistentKey = isset($options[ self::SOCKET_OPTION_PERSISTENT_KEY ]) ?
81
-                    $options[ self::SOCKET_OPTION_PERSISTENT_KEY ] :
82
-                    null;
78
+                $isPersistent  = isset($options[self::SOCKET_OPTION_IS_PERSISTENT]) &&
79
+                                 $options[self::SOCKET_OPTION_IS_PERSISTENT];
80
+                $persistentKey = isset($options[self::SOCKET_OPTION_PERSISTENT_KEY]) ?
81
+                    $options[self::SOCKET_OPTION_PERSISTENT_KEY] : null;
83 82
 
84 83
                 return $isPersistent ?
85
-                    new PersistentClientSocket($persistentKey) :
86
-                    new ClientSocket();
84
+                    new PersistentClientSocket($persistentKey) : new ClientSocket();
87 85
             case self::SOCKET_SERVER:
88 86
                 return new ServerSocket();
89 87
             default:
Please login to merge, or discard this patch.
src/RequestExecutor/Pipeline/TimeoutStage.php 1 patch
Spacing   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
     public function processStage(array $operations)
25 25
     {
26 26
         /** @var OperationMetadata[] $operations */
27
-        $result    = [ ];
27
+        $result    = [];
28 28
         $microTime = microtime(true);
29 29
         foreach ($operations as $key => $operation) {
30 30
             if ($this->isSingleSocketTimeout($operation, $microTime)) {
@@ -53,8 +53,7 @@  discard block
 block discarded – undo
53 53
             $meta[RequestExecutorInterface::META_USER_CONTEXT],
54 54
             $meta[RequestExecutorInterface::META_CONNECTION_FINISH_TIME] !== null &&
55 55
             !($descriptor->getSocket() instanceof ServerSocket) ?
56
-                TimeoutEvent::DURING_IO :
57
-                TimeoutEvent::DURING_CONNECTION
56
+                TimeoutEvent::DURING_IO : TimeoutEvent::DURING_CONNECTION
58 57
         );
59 58
         try {
60 59
             $this->callSocketSubscribers($descriptor, $event);
Please login to merge, or discard this patch.
src/RequestExecutor/LibEventRequestExecutor.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
     protected function initializeRequest(EventCaller $eventCaller)
105 105
     {
106 106
         parent::initializeRequest($eventCaller);
107
-        $this->base        = new LeBase();
107
+        $this->base = new LeBase();
108 108
 
109 109
         $this->connectStage    = $this->stageFactory->createConnectStage($this, $eventCaller, $this->solver);
110 110
         $this->ioStage         = $this->stageFactory->createIoStage($this, $eventCaller);
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
     protected function terminateRequest()
118 118
     {
119 119
         parent::terminateRequest();
120
-        $this->base        = null;
120
+        $this->base = null;
121 121
 
122 122
         $this->connectStage    = null;
123 123
         $this->ioStage         = null;
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
             case LeCallbackInterface::EVENT_READ:
169 169
                 // fall down
170 170
             case LeCallbackInterface::EVENT_WRITE:
171
-                $result       = $this->ioStage->processStage([ $operationMetadata ]);
171
+                $result       = $this->ioStage->processStage([$operationMetadata]);
172 172
                 $doResetEvent = empty($result);
173 173
 
174 174
                 break;
Please login to merge, or discard this patch.
src/Exception/UnmanagedSocketException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
         return new self(
30 30
             $socket,
31 31
             sprintf(
32
-                'System has detected a zombie connection %s and closed it. '.
32
+                'System has detected a zombie connection %s and closed it. ' .
33 33
                 'If you see this message it means that application ' .
34 34
                 'has lost control on one of its sockets.',
35 35
                 (string) $socket
Please login to merge, or discard this patch.
src/RequestExecutor/Pipeline/GuardianStage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@
 block discarded – undo
104 104
         return new Event(
105 105
             $this->executor,
106 106
             $operation->getSocket(),
107
-            $meta[ RequestExecutorInterface::META_USER_CONTEXT ],
107
+            $meta[RequestExecutorInterface::META_USER_CONTEXT],
108 108
             $eventName
109 109
         );
110 110
     }
Please login to merge, or discard this patch.
src/Socket/AsyncSelector.php 1 patch
Spacing   +3 added lines, -4 removed lines patch added patch discarded remove patch
@@ -239,8 +239,8 @@  discard block
 block discarded – undo
239 239
      */
240 240
     public function removeAllSocketOperations(StreamResourceInterface $streamResource)
241 241
     {
242
-        $opList = [ OperationInterface::OPERATION_READ,
243
-                    OperationInterface::OPERATION_WRITE  ];
242
+        $opList = [OperationInterface::OPERATION_READ,
243
+                    OperationInterface::OPERATION_WRITE];
244 244
 
245 245
         foreach ($opList as $op) {
246 246
             $this->removeSocketOperation($streamResource, $op);
@@ -281,8 +281,7 @@  discard block
 block discarded – undo
281 281
      */
282 282
     private function calculateAttemptsCount($seconds, $usec)
283 283
     {
284
-        $result = $seconds !== null ? ceil(($seconds * 1E6 + $usec) / self::ATTEMPT_DELAY) :
285
-            self::ATTEMPT_COUNT_FOR_INFINITE_TIMEOUT;
284
+        $result = $seconds !== null ? ceil(($seconds * 1E6 + $usec) / self::ATTEMPT_DELAY) : self::ATTEMPT_COUNT_FOR_INFINITE_TIMEOUT;
286 285
         if ($result < self::ATTEMPT_COUNT_FOR_INFINITE_TIMEOUT) {
287 286
             $result = self::ATTEMPT_COUNT_FOR_INFINITE_TIMEOUT;
288 287
         }
Please login to merge, or discard this patch.
src/RequestExecutor/Pipeline/ConnectStageReturningAllActiveSockets.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
     private function isDescriptorActive(OperationMetadata $descriptor)
54 54
     {
55 55
         $meta = $descriptor->getMetadata();
56
-        return !$meta[ RequestExecutorInterface::META_REQUEST_COMPLETE ] &&
56
+        return !$meta[RequestExecutorInterface::META_REQUEST_COMPLETE] &&
57 57
                     $descriptor->isRunning() &&
58 58
                     !$descriptor->isPostponed();
59 59
     }
Please login to merge, or discard this patch.