eddy8 / LightCMS

app/Http/Middleware/Log.php

<?php

namespace App\Http\Middleware;

use App\Repository\Admin\LogRepository;
use Carbon\Carbon;
use Closure;
use GuzzleHttp\Psr7\Query;
use Illuminate\Support\Facades\Auth;
use App\Jobs\WriteSystemLog;

class Log
{
    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @return mixed
     */
    public function handle($request, Closure $next, $guard = '')
    {
        $data = [];
        if ($guard !== '') {
            $user = Auth::guard($guard)->user();
            if ($user) {
                $data['user_id'] = $user->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                $data['user_name'] = $user->name;

Accessing name on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            }
        }
        $data['url'] = $request->url();
        $data['ua'] = $request->userAgent();
        $data['ip'] = (string) $request->getClientIp();
        $input = $request->all();
        if (isset($input['password'])) {
            $input['password'] = '******';
        }
        $data['data'] = Query::build($input, false);

        if (config('light.log_async_write')) {
            $data['updated_at'] = $data['created_at'] = Carbon::now();
            dispatch(new WriteSystemLog($data));
        } else {
            LogRepository::add($data);
        }
        return $next($request);
    }
}