App\Http\Controllers\Admin\NEditorController

Complexity

Total Complexity

39

Size/Duplication

Total Lines	260
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	catchImage()	0	27	6
A	uploadImage()	0	34	5
A	isAllowedImageType()	0	5	1
A	uploadVideo()	0	34	5
A	serve()	0	10	2
A	isValidVideo()	0	9	1
B	fetchImageFile()	0	38	7
A	isValidImage()	0	9	1
A	uploadFile()	0	34	5
A	isValidFile()	0	9	1
A	isValidUploadedFile()	0	17	5

<?php
/**
 * Date: 2019/3/16 Time: 13:42
 *
 * @author  Eddy <cumtsjh@163.com>
 * @version v1.0.0
 */

namespace App\Http\Controllers\Admin;

use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Illuminate\Http\UploadedFile;
use Illuminate\Support\Facades\Storage;
use Intervention\Image\Facades\Image;
use Intervention\Image\Exception\NotReadableException;

class NEditorController extends Controller
{
    /**
     * 基础功能-图片上传
     *
     * @param Request $request
     * @param string $type
     * @return array
     */
    public function serve(Request $request, $type)
    {
        if (!method_exists(self::class, $type)) {
            return [
                'code' => 1,
                'msg' => '未知操作'
            ];
        }

        return call_user_func(self::class . '::' . $type, $request);
    }

    protected function uploadImage(Request $request)
    {
        if (config('light.image_upload.driver') !== 'local') {
            $class = config('light.image_upload.class');
            return call_user_func([new $class, 'uploadImage'], $request);
        }

        if (!$request->hasFile('file')) {
            return [
                'code' => 2,
                'msg' => '非法请求'
            ];
        }
        $file = $request->file('file');
        if (!$this->isValidImage($file)) {

It seems like $file can also be of type Illuminate\Http\UploadedFile[] and array and null; however, parameter $file of App\Http\Controllers\Admin\NEditorController::isValidImage() does only seem to accept Illuminate\Http\UploadedFile, maybe add an additional type check?

            return [
                'code' => 3,
                'msg' => '文件不合要求'
            ];
        }

        $result = $file->store(date('Ym'), config('light.neditor.disk'));
        if (!$result) {
            return [
                'code' => 3,
                'msg' => '上传失败'
            ];
        }

        return [
            'code' => 200,
            'state' => 'SUCCESS', // 兼容ueditor
            'msg' => '',
            'url' => Storage::disk(config('light.neditor.disk'))->url($result),
        ];
    }

    public function catchImage(Request $request)
    {
        if (config('light.image_upload.driver') !== 'local') {
            $class = config('light.image_upload.class');
            return call_user_func([new $class, 'catchImage'], $request);
        }

        $files = array_unique((array) $request->post('file'));
        $urls = [];
        foreach ($files as $v) {
            $image = $this->fetchImageFile($v);
            if (!$image || !$image['extension'] || !$this->isAllowedImageType($image['extension'])) {
                continue;
            }

            $path = date('Ym') . '/' . md5($v) . '.' . $image['extension'];
            Storage::disk(config('light.neditor.disk'))
                ->put($path, $image['data']);
            $urls[] = [
                'url' => Storage::disk(config('light.neditor.disk'))->url($path),
                'source' => $v,
                'state' => 'SUCCESS'
            ];
        }

        return [
           'list' => $urls
        ];
    }

    public function uploadVideo(Request $request)
    {
        if (config('light.image_upload.driver') !== 'local') {
            $class = config('light.image_upload.class');
            return call_user_func([new $class, 'uploadImage'], $request);
        }

        if (!$request->hasFile('file')) {
            return [
                'code' => 2,
                'msg' => '非法请求'
            ];
        }
        $file = $request->file('file');
        if (!$this->isValidVideo($file)) {

It seems like $file can also be of type Illuminate\Http\UploadedFile[] and array and null; however, parameter $file of App\Http\Controllers\Admin\NEditorController::isValidVideo() does only seem to accept Illuminate\Http\UploadedFile, maybe add an additional type check?

            return [
                'code' => 3,
                'msg' => '文件不合要求'
            ];
        }

        $result = $file->store('video/' . date('Ym'), config('light.neditor.disk'));
        if (!$result) {
            return [
                'code' => 3,
                'msg' => '上传失败'
            ];
        }

        return [
            'code' => 200,
            'state' => 'SUCCESS', // 兼容ueditor
            'msg' => '',
            'url' => Storage::disk(config('light.neditor.disk'))->url($result),
        ];
    }

    public function uploadFile(Request $request)
    {
        if (config('light.image_upload.driver') !== 'local') {
            $class = config('light.image_upload.class');
            return call_user_func([new $class, 'uploadImage'], $request);
        }

        if (!$request->hasFile('file')) {
            return [
                'code' => 2,
                'msg' => '非法请求'
            ];
        }
        $file = $request->file('file');
        if (!$this->isValidFile($file)) {

It seems like $file can also be of type Illuminate\Http\UploadedFile[] and array and null; however, parameter $file of App\Http\Controllers\Admin\NEditorController::isValidFile() does only seem to accept Illuminate\Http\UploadedFile, maybe add an additional type check?

            return [
                'code' => 3,
                'msg' => '文件不合要求'
            ];
        }

        $result = $file->store('file/' . date('Ym'), config('light.neditor.disk'));
        if (!$result) {
            return [
                'code' => 3,
                'msg' => '上传失败'
            ];
        }

        return [
            'code' => 200,
            'state' => 'SUCCESS', // 兼容ueditor
            'msg' => '',
            'url' => Storage::disk(config('light.neditor.disk'))->url($result),
        ];
    }

    protected function isValidImage(UploadedFile $file)
    {
        $c = config('light.neditor.upload');
        $config = [
            'maxSize' => $c['imageMaxSize'],
            'AllowFiles' => $c['imageAllowFiles'],
        ];

        return $this->isValidUploadedFile($file, $config);
    }

    protected function isValidVideo(UploadedFile $file)
    {
        $c = config('light.neditor.upload');
        $config = [
            'maxSize' => $c['videoMaxSize'],
            'AllowFiles' => $c['videoAllowFiles'],
        ];

        return $this->isValidUploadedFile($file, $config);
    }

    protected function isValidFile(UploadedFile $file)
    {
        $c = config('light.neditor.upload');
        $config = [
            'maxSize' => $c['fileMaxSize'],
            'AllowFiles' => $c['fileAllowFiles'],
        ];

        return $this->isValidUploadedFile($file, $config);
    }

    protected function isValidUploadedFile(UploadedFile $file, array $config)
    {
        if (!$file->isValid() ||
            $file->getSize() > $config['maxSize'] ||
            !in_array(
                '.' . strtolower($file->getClientOriginalExtension()),
                $config['AllowFiles']
            ) ||
            !in_array(
                '.' . strtolower($file->guessExtension()),

It seems like $file->guessExtension() can also be of type null; however, parameter $string of strtolower() does only seem to accept string, maybe add an additional type check?

                $config['AllowFiles']
            )
        ) {
            return false;
        }

        return true;
    }

    protected function fetchImageFile($url)
    {
        try {
            if (!filter_var($url, FILTER_VALIDATE_URL)) {
                return false;
            }

            if (extension_loaded('curl')) {
                $ch = curl_init();
                $options =  [
                    CURLOPT_URL => $url,
                    CURLOPT_RETURNTRANSFER => true,
                    CURLOPT_USERAGENT => 'Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.2 (KHTML, like Gecko) Chrome/22.0.1216.0 Safari/537.2'
                ];
                curl_setopt_array($ch, $options);
                $data = curl_exec($ch);
                curl_close($ch);
                if (!$data) {
                    return false;
                }

                if (isWebp($data)) {
                    $image = Image::make(imagecreatefromwebp($url));
                    $extension = 'webp';
                } else {
                    $image = Image::make($data);
                }
            } else {
                $image = Image::make($url);
            }
        } catch (NotReadableException $e) {
            return false;
        }

        $mime = $image->mime();
        return [
            'extension' => $extension ?? ($mime ? strtolower(explode('/', $mime)[1]) : ''),
            'data' => $data

The variable $data does not seem to be defined for all execution paths leading up to this point.

        ];
    }

    protected function isAllowedImageType($extension)
    {
        $c = config('light.neditor.upload');

        return in_array('.' . $extension, $c['imageAllowFiles'], true);
    }
}