Conditions | 16 |
Paths | 66 |
Total Lines | 43 |
Code Lines | 28 |
Lines | 0 |
Ratio | 0 % |
Changes | 2 | ||
Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
16 | public static function buildQuery(Builder $query, array $condition) |
||
17 | { |
||
18 | // 获取模型定义的搜索域 |
||
19 | $model = $query->getModel(); |
||
20 | $searchField = []; |
||
21 | if (property_exists($model, 'searchField')) { |
||
22 | $searchField = $model::$searchField; |
||
23 | } |
||
24 | |||
25 | foreach ($condition as $k => $v) { |
||
26 | if (!is_array($v) && isset($searchField[$k]['searchType'])) { |
||
27 | $condition[$k] = [$searchField[$k]['searchType'], $v]; |
||
28 | } |
||
29 | } |
||
30 | |||
31 | foreach ($condition as $k => $v) { |
||
32 | $type = 'like'; |
||
33 | $value = $v; |
||
34 | if (is_array($v)) { |
||
35 | list($type, $value) = $v; |
||
36 | } |
||
37 | $value = trim($value); |
||
38 | // 搜索值为空字符串则忽略该条件 |
||
39 | if ($value === '') { |
||
40 | continue; |
||
41 | } |
||
42 | |||
43 | if ($k === 'created_at' || |
||
44 | $k === 'updated_at' || |
||
45 | (isset($searchField[$k]['showType']) && $searchField[$k]['showType'] === 'datetime') |
||
46 | ) { |
||
47 | $dates = explode(' ~ ', $value); |
||
48 | if (count($dates) === 2) { |
||
49 | $query->whereBetween($k, [ |
||
50 | Carbon::parse($dates[0])->startOfDay(), |
||
51 | Carbon::parse($dates[1])->endOfDay(), |
||
52 | ]); |
||
53 | } |
||
54 | } elseif (isset($searchField[$k]['searchType']) && $searchField[$k]['searchType'] === 'whereRaw') { |
||
55 | $queryParams = array_pad([], substr_count($searchField[$k]['searchCondition'], '?'), $value); |
||
56 | $query->whereRaw($searchField[$k]['searchCondition'], $queryParams); |
||
57 | } else { |
||
58 | $query->where($k, $type, $type === 'like' ? "%{$value}%" : $value); |
||
59 | } |
||
63 |