eddy8 /
LightCMS
| Total Complexity | 52 |
| Total Lines | 325 |
| Duplicated Lines | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Complex classes like MenuController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use MenuController, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 22 | class MenuController extends Controller |
||
| 23 | { |
||
| 24 | protected $formNames = [ |
||
| 25 | 'name', 'pid', 'status', 'order', 'route', 'group', 'remark', 'url', 'is_lock_name', 'route_params' |
||
| 26 | ]; |
||
| 27 | |||
| 28 | public function __construct() |
||
| 29 | { |
||
| 30 | parent::__construct(); |
||
| 31 | |||
| 32 | $this->breadcrumb[] = ['title' => '菜单管理', 'url' => route('admin::menu.index')]; |
||
| 33 | } |
||
| 34 | |||
| 35 | /** |
||
| 36 | * 菜单管理-菜单列表 |
||
| 37 | * |
||
| 38 | */ |
||
| 39 | public function index() |
||
| 40 | { |
||
| 41 | $this->breadcrumb[] = ['title' => '菜单列表', 'url' => '']; |
||
| 42 | return view('admin.menu.index', ['breadcrumb' => $this->breadcrumb]); |
||
| 43 | } |
||
| 44 | |||
| 45 | /** |
||
| 46 | * 菜单管理-菜单列表数据 |
||
| 47 | * |
||
| 48 | * @param Request $request |
||
| 49 | * @return array |
||
| 50 | */ |
||
| 51 | public function list(Request $request) |
||
| 52 | { |
||
| 53 | $perPage = (int) $request->get('limit', 50); |
||
| 54 | $action = $request->get('action'); |
||
| 55 | $this->formNames[] = 'created_at'; |
||
| 56 | $condition = $request->only($this->formNames); |
||
| 57 | |||
| 58 | if (isset($condition['pid'])) { |
||
| 59 | $condition['pid'] = ['=', $condition['pid']]; |
||
| 60 | } else { |
||
| 61 | if ($action !== 'search') { |
||
| 62 | $condition['pid'] = ['=', 0]; |
||
| 63 | } |
||
| 64 | } |
||
| 65 | |||
| 66 | $data = MenuRepository::list($perPage, $condition); |
||
| 67 | |||
| 68 | return $data; |
||
| 69 | } |
||
| 70 | |||
| 71 | /** |
||
| 72 | * 菜单管理-新增菜单 |
||
| 73 | * |
||
| 74 | */ |
||
| 75 | public function create() |
||
| 76 | { |
||
| 77 | $this->breadcrumb[] = ['title' => '新增菜单', 'url' => '']; |
||
| 78 | return view('admin.menu.add', ['breadcrumb' => $this->breadcrumb]); |
||
| 79 | } |
||
| 80 | |||
| 81 | /** |
||
| 82 | * 菜单管理-保存菜单 |
||
| 83 | * |
||
| 84 | * @param MenuRequest $request |
||
| 85 | * @return array |
||
| 86 | */ |
||
| 87 | public function save(MenuRequest $request) |
||
| 88 | { |
||
| 89 | try { |
||
| 90 | MenuRepository::add(array_merge($request->only($this->formNames), ['guard_name' => 'admin'])); |
||
| 91 | event(new MenuUpdated()); |
||
| 92 | return [ |
||
| 93 | 'code' => 0, |
||
| 94 | 'msg' => '新增成功', |
||
| 95 | 'redirect' => true |
||
| 96 | ]; |
||
| 97 | } catch (QueryException $e) { |
||
| 98 | return [ |
||
| 99 | 'code' => 1, |
||
| 100 | 'msg' => '新增失败：' . (Str::contains($e->getMessage(), 'Duplicate entry') ? '当前菜单已存在' : '其它错误'), |
||
| 101 | 'redirect' => false |
||
| 102 | ]; |
||
| 103 | } |
||
| 104 | } |
||
| 105 | |||
| 106 | /** |
||
| 107 | * 菜单管理-编辑菜单 |
||
| 108 | * |
||
| 109 | * @param int $id |
||
| 110 | */ |
||
| 111 | public function edit($id) |
||
| 117 | } |
||
| 118 | |||
| 119 | /** |
||
| 120 | * 菜单管理-更新菜单 |
||
| 121 | * |
||
| 122 | * @param MenuRequest $request |
||
| 123 | * @param int $id |
||
| 124 | * @return array |
||
| 125 | */ |
||
| 126 | public function update(MenuRequest $request, $id) |
||
| 127 | { |
||
| 128 | $data = array_merge( |
||
| 129 | [ |
||
| 130 | 'is_lock_name' => Menu::UNLOCK_NAME, |
||
| 131 | 'status' => Menu::STATUS_DISABLE |
||
| 132 | ], |
||
| 133 | $request->only($this->formNames) |
||
| 134 | ); |
||
| 135 | |||
| 136 | try { |
||
| 137 | MenuRepository::update($id, $data); |
||
| 138 | event(new MenuUpdated()); |
||
| 139 | return [ |
||
| 140 | 'code' => 0, |
||
| 141 | 'msg' => '编辑成功', |
||
| 142 | 'redirect' => true |
||
| 143 | ]; |
||
| 144 | } catch (QueryException $e) { |
||
| 145 | return [ |
||
| 146 | 'code' => 1, |
||
| 147 | 'msg' => '编辑失败：' . (Str::contains($e->getMessage(), 'Duplicate entry') ? '当前菜单已存在' : '其它错误'), |
||
| 148 | 'redirect' => false |
||
| 149 | ]; |
||
| 150 | } |
||
| 151 | } |
||
| 152 | |||
| 153 | /** |
||
| 154 | * 菜单管理-删除菜单 |
||
| 155 | * |
||
| 156 | * @param int $id |
||
| 157 | * @return array |
||
| 158 | */ |
||
| 159 | public function delete($id) |
||
| 174 | ]; |
||
| 175 | } |
||
| 176 | } |
||
| 177 | |||
| 178 | /** |
||
| 179 | * 菜单管理-自动更新菜单 |
||
| 180 | * |
||
| 181 | * @return array |
||
| 182 | * @throws \ReflectionException |
||
| 183 | */ |
||
| 184 | public function discovery() |
||
| 185 | { |
||
| 186 | $addNum = 0; |
||
| 187 | $updateNum = 0; |
||
| 188 | |||
| 189 | foreach (Route::getRoutes()->getRoutesByName() as $k => $v) { |
||
| 190 | if (Str::startsWith($k, 'admin::')) { |
||
| 191 | // 取方法的第一行注释作为菜单的名称、分组名。格式：分组名称-菜单名称。未写分组名称，则注释直接作为菜单名称。未写注释则选用uri作为菜单名称。 |
||
| 192 | $action = explode('@', $v->getActionName()); |
||
| 193 | if (!method_exists($action[0], $action[1])) { |
||
| 194 | continue; |
||
| 195 | } |
||
| 196 | $reflection = new \ReflectionMethod($action[0], $action[1]); |
||
| 197 | $comment = trim(array_get(explode("\n", $reflection->getDocComment()), 1, ''), " \t\n\r\0\x0B*"); |
||
|
Bug
introduced
by
|
|||
| 198 | if ($comment === '') { |
||
| 199 | $data['name'] = $v->uri; |
||
| 200 | $data['group'] = ''; |
||
| 201 | } else { |
||
| 202 | if (Str::contains($comment, '-')) { |
||
| 203 | $arr = explode('-', $comment); |
||
| 204 | $data['name'] = trim($arr[1]); |
||
| 205 | $data['group'] = trim($arr[0]); |
||
| 206 | } else { |
||
| 207 | $data['name'] = trim($comment); |
||
| 208 | $data['group'] = ''; |
||
| 209 | } |
||
| 210 | } |
||
| 211 | |||
| 212 | $data['route'] = $k; |
||
| 213 | $data['guard_name'] = 'admin'; |
||
| 214 | if (in_array('GET', $v->methods) && !Str::contains($v->uri, '{')) { |
||
| 215 | $data['status'] = Menu::STATUS_ENABLE; |
||
| 216 | } else { |
||
| 217 | $data['status'] = Menu::STATUS_DISABLE; |
||
| 218 | } |
||
| 219 | try { |
||
| 220 | $data['url'] = route($k, [], false); |
||
| 221 | } catch (UrlGenerationException $e) { |
||
| 222 | $data['url'] = ''; |
||
| 223 | } |
||
| 224 | |||
| 225 | try { |
||
| 226 | $model = MenuRepository::exist($k); |
||
| 227 | if ($model) { |
||
| 228 | if (($model->is_lock_name == Menu::UNLOCK_NAME && |
||
| 229 | ($model->name != $data['name'] || $model->group != $data['group'])) || |
||
| 230 | ($data['url'] != '' && $model->url != $data['url'])) { |
||
| 231 | unset($data['status']); |
||
| 232 | MenuRepository::update($model->id, $data); |
||
| 233 | $updateNum++; |
||
| 234 | } |
||
| 235 | } else { |
||
| 236 | MenuRepository::add($data); |
||
| 237 | $addNum++; |
||
| 238 | } |
||
| 239 | } catch (QueryException $e) { |
||
| 240 | if ($addNum > 0 || $updateNum > 0) { |
||
| 241 | event(new MenuUpdated()); |
||
| 242 | } |
||
| 243 | |||
| 244 | if ($e->getCode() == 23000) { |
||
| 245 | return [ |
||
| 246 | 'code' => 1, |
||
| 247 | 'msg' => "唯一性冲突：请检查菜单名称或路由名称。name: {$data['name']} route: {$data['route']}", |
||
| 248 | ]; |
||
| 249 | } else { |
||
| 250 | return [ |
||
| 251 | 'code' => 2, |
||
| 252 | 'msg' => $e->getMessage(), |
||
| 253 | ]; |
||
| 254 | } |
||
| 255 | } |
||
| 256 | } |
||
| 257 | } |
||
| 258 | |||
| 259 | if ($addNum > 0 || $updateNum > 0) { |
||
| 260 | event(new MenuUpdated()); |
||
| 261 | } |
||
| 262 | return [ |
||
| 263 | 'code' => 0, |
||
| 264 | 'msg' => "更新成功。新增菜单数：{$addNum}，更新菜单数：{$updateNum}。", |
||
| 265 | 'redirect' => true |
||
| 266 | ]; |
||
| 267 | } |
||
| 268 | |||
| 269 | /** |
||
| 270 | * 菜单管理-批量操作 |
||
| 271 | */ |
||
| 272 | public function batch(Request $request) |
||
| 347 | ]; |
||
| 348 | } |
||
| 349 | } |
||
| 350 |
Loading history...