eddiriarte / console-select

src/Traits/SelectableInputs.php

<?php

This file is missing a doc comment.

The PHP open tag does not have a corresponding PHP close tag

Filename "SelectableInputs.php" doesn't match the expected filename "selectableinputs.php"

namespace EddIriarte\Console\Traits;

Missing file doc comment

use EddIriarte\Console\Helpers\SelectionHelper;
use EddIriarte\Console\Inputs\CheckboxInput;
use EddIriarte\Console\Inputs\RadioInput;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

trait SelectableInputs

Missing class doc comment

{

Opening brace should be on the same line as the declaration for trait SelectableInputs

    public function enableSelectHelper(InputInterface $input, OutputInterface $output)

Expected 2 blank lines before function; 0 found

Missing function doc comment

    {

Opening brace should be on the same line as the declaration

        $this->getHelperSet()->set(

It seems like getHelperSet() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            new SelectionHelper($input, $output)
        );
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end enableSelectHelper()

    public function select(string $message, array $options, bool $allowMultiple = true)

Missing function doc comment

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of true please use TRUE.

    {

Opening brace should be on the same line as the declaration

        $helper = $this->getHelper('selection');

It seems like getHelper() must be provided by classes using this trait. How about adding it as abstract method to this trait?

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

        $question = $allowMultiple ? new CheckboxInput($message, $options) : new RadioInput($message, $options);

The value of a comparison must not be assigned to a variable

Inline IF statements are not allowed

Inline shorthand IF statement requires brackets around comparison

        return $helper->select($question);
    }

Expected 2 blank lines after function; 0 found

Expected 1 blank line before closing function brace; 0 found

Expected //end select()

}

As per coding style, files should not end with a newline character.