SelectHandler::tryCellNavigation() - Code Metrics - eddiriarte/console-select - Measure and Improve Code Quality continuously with Scrutinizer

SelectHandler::tryCellNavigation() B
last analyzed 2020-10-20 07:24 UTC

↳ Parent: SelectHandler

Complexity

Conditions	7
Paths	6

Size

Total Lines	22
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	7.0099

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	16
c	1
b	0
f	0
dl	0
loc	22
ccs	16
cts	17
cp	0.9412
rs	8.8333
cc	7
nc	6
nop	1
crap	7.0099

<?php

Coding Style introduced 2019-12-15 17:23 UTC by

This file is missing a doc comment.

Coding Style introduced 2019-12-15 17:23 UTC by

The PHP open tag does not have a corresponding PHP close tag

Coding Style introduced 2019-12-15 17:23 UTC by

Filename "SelectHandler.php" doesn't match the expected filename "selecthandler.php"

namespace EddIriarte\Console\Handlers;

Coding Style introduced 2019-12-15 17:23 UTC by

Missing file doc comment

use Symfony\Component\Console\Output\OutputInterface;

use Symfony\Component\Console\Terminal;

use EddIriarte\Console\Inputs\Interfaces\SelectInput;

/**

 * Class SelectHandler

 * @package Lazzier\Helpers

Coding Style Documentation introduced 2019-12-15 17:23 UTC by

@package tag is not allowed in class comment

Coding Style introduced 2019-12-15 17:23 UTC by

There must be exactly one blank line before the tags in a doc comment

 * @author Eduardo Iriarte <eddiriarte[at]gmail[dot]com>

Coding Style Documentation introduced 2019-12-15 17:23 UTC by

@author tag is not allowed in class comment

Coding Style introduced 2019-12-15 17:23 UTC by

Content of the @author tag must be in the form "Display Name <[email protected]>"

Coding Style introduced 2019-12-15 17:23 UTC by

Tag value indented incorrectly; expected 2 spaces but found 1

*/

Coding Style introduced 2019-12-15 17:23 UTC by

Missing @category tag in class comment

Coding Style introduced 2019-12-15 17:23 UTC by

Missing @license tag in class comment

Coding Style introduced 2019-12-15 17:23 UTC by

Missing @link tag in class comment

class SelectHandler

Coding Style introduced 2019-12-15 17:23 UTC by

Opening brace should be on the same line as the declaration for class SelectHandler

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Missing short description in doc comment

     * @var resource

*/

    protected $stream;

Coding Style introduced 2019-12-15 17:23 UTC by

Protected member variable "stream" must contain a leading underscore

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 1 blank line before member var; 0 found

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Missing short description in doc comment

     * @var OutputInterface

*/

    protected $output;

Coding Style introduced 2019-12-15 17:23 UTC by

Protected member variable "output" must contain a leading underscore

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Missing short description in doc comment

     * @var SelectInput

*/

    protected $question;

Coding Style introduced 2019-12-15 17:23 UTC by

Protected member variable "question" must contain a leading underscore

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Missing short description in doc comment

     * @var int

Bug introduced 2019-12-15 17:23 UTC by

Expected "integer" but found "int" for @var tag in member variable comment

*/

    protected $row;

Coding Style introduced 2019-12-15 17:23 UTC by

Protected member variable "row" must contain a leading underscore

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Missing short description in doc comment

     * @var int

Bug introduced 2019-12-15 17:23 UTC by

Expected "integer" but found "int" for @var tag in member variable comment

*/

    protected $column;

Coding Style introduced 2019-12-15 17:23 UTC by

Protected member variable "column" must contain a leading underscore

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Missing short description in doc comment

     * @var bool

Bug introduced 2019-12-15 17:23 UTC by

Expected "boolean" but found "bool" for @var tag in member variable comment

*/

    protected $firstRun;

Coding Style introduced 2019-12-15 17:23 UTC by

Protected member variable "firstRun" must contain a leading underscore

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Missing short description in doc comment

     * @var int

Bug introduced 2019-12-15 17:23 UTC by

Expected "integer" but found "int" for @var tag in member variable comment

*/

    protected $terminalWidth;

Coding Style introduced 2019-12-15 17:23 UTC by

Protected member variable "terminalWidth" must contain a leading underscore

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Parameter $stream should have a doc-comment as per coding-style.

     * SelectStreamHandler constructor.

     * @param SelectInput $question

Coding Style introduced 2019-12-15 17:23 UTC by

There must be exactly one blank line before the tags in a doc comment

Coding Style introduced 2019-12-15 17:23 UTC by

Missing parameter comment

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 5 spaces after parameter type; 1 found

     * @param OutputInterface $output

Coding Style introduced 2019-12-15 17:23 UTC by

Missing parameter comment

     * @param $stream

Coding Style Documentation introduced 2019-12-15 17:23 UTC by

Missing parameter name

*/

    public function __construct(SelectInput $question, OutputInterface $output, $stream)

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 2 blank lines before function; 1 found

introduced 2019-12-15 17:23 UTC by

Type hint "stream" missing for

Coding Style introduced 2019-12-15 17:23 UTC by

Opening brace should be on the same line as the declaration

        $this->row = 0;

Coding Style introduced 2019-12-15 17:23 UTC by

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

        $this->column = 0;

Coding Style introduced 2019-12-15 17:23 UTC by

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

        $this->question = $question;

        $this->output = $output;

Coding Style introduced 2019-12-15 17:23 UTC by

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

        $this->stream = $stream;

Coding Style introduced 2019-12-15 17:23 UTC by

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected //end __construct()

/**

     * Navigates through option items.

     * @return array

*/

    public function handle(): array

Coding Style introduced 2019-12-15 17:23 UTC by

Opening brace should be on the same line as the declaration

        $this->firstRun = true;

Coding Style introduced 2019-12-15 17:23 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of true please use TRUE.

        $this->output->writeln(

            '<info>' . $this->question->getMessage() . '</info> [<comment>SPACE=select</>, <comment>ENTER=submit</>]'

Coding Style introduced 2019-12-15 17:23 UTC by

Concat operator must not be surrounded by spaces

);

        $this->repaint();

        $sttyMode = shell_exec('stty -g');

        // Disable icanon (so we can fread each keypress) and echo (we'll do echoing here instead)

Coding Style introduced 2019-12-15 17:23 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

        shell_exec('stty -icanon -echo');

        // Read a keypress

Coding Style introduced 2019-12-15 17:23 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

        while (!feof($this->stream)) {

Coding Style introduced 2019-12-15 17:23 UTC by

There must be a single space after a NOT operator; 0 found

            $char = fread($this->stream, 1);

            if (" " === $char) {

Coding Style Comprehensibility introduced 2019-12-15 17:23 UTC by

The string literal does not require double quotes, as per coding-style, please use single quotes.

                $this->tryCellSelection();

            } elseif ("\033" === $char) {

Coding Style introduced 2019-12-15 17:23 UTC by

Usage of ELSEIF not allowed; use ELSE IF instead

                $this->tryCellNavigation($char);

            } elseif (10 === ord($char)) {

Coding Style introduced 2019-12-15 17:23 UTC by

Usage of ELSEIF not allowed; use ELSE IF instead

                //TODO handle valid state...

Coding Style Best Practice introduced 2019-12-15 17:23 UTC by

Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker.

Coding Style introduced 2019-12-15 17:23 UTC by

No space found before comment text; expected "// TODO handle valid state..." but found "//TODO handle valid state..."

                $this->clear();

                $this->output->write('> ' . join(', ', $this->question->getSelections()));

Coding Style introduced 2019-12-15 17:23 UTC by

Concat operator must not be surrounded by spaces

                $this->output->write($char);

                break;

            $this->repaint();

100

        // Reset stty so it behaves normally again

Coding Style introduced 2019-12-15 17:23 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

101

        shell_exec(sprintf('stty %s', $sttyMode));

102

103

        $this->output->writeln(' ');

104

105

        return $this->question->getSelections();

106

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected //end handle()

107

108

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Missing short description in doc comment

Coding Style introduced 2019-12-15 17:23 UTC by

Parameter $row should have a doc-comment as per coding-style.

Coding Style introduced 2019-12-15 17:23 UTC by

Parameter $column should have a doc-comment as per coding-style.

109

     * @param $row

Coding Style Documentation introduced 2019-12-15 17:23 UTC by

Missing parameter name

110

     * @param $column

Coding Style Documentation introduced 2019-12-15 17:23 UTC by

Missing parameter name

111

     * @return bool

Coding Style introduced 2019-12-15 17:23 UTC by

Expected "boolean" but found "bool" for function return type

112

*/

113

    public function exists($row, $column): bool

introduced 2019-12-15 17:23 UTC by

Type hint "row" missing for

introduced 2019-12-15 17:23 UTC by

Type hint "column" missing for

114

Coding Style introduced 2019-12-15 17:23 UTC by

Opening brace should be on the same line as the declaration

115

        return $this->question->hasEntryAt($row, $column);

Bug introduced 2018-05-23 19:02 UTC by

The method hasEntryAt() does not exist on EddIriarte\Console\Inputs\Interfaces\SelectInput. Since it exists in all sub-types, consider adding an abstract or default implementation to EddIriarte\Console\Inputs\Interfaces\SelectInput. ( Ignorable by Annotation )

116

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected //end exists()

117

118

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Doc comment is empty

119

120

*/

Coding Style introduced 2019-12-15 17:23 UTC by

Missing @return tag in function comment

121

    protected function up(): void

122

Coding Style introduced 2019-12-15 17:23 UTC by

Opening brace should be on the same line as the declaration

123

        if ($this->exists($this->row - 1, $this->column)) {

Coding Style introduced 2019-12-15 17:23 UTC by

Arithmetic operation must be bracketed

124

            $this->row -= 1;

125

126

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected //end up()

127

128

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Doc comment is empty

129

130

*/

Coding Style introduced 2019-12-15 17:23 UTC by

Missing @return tag in function comment

131

    protected function down(): void

132

Coding Style introduced 2019-12-15 17:23 UTC by

Opening brace should be on the same line as the declaration

133

        if ($this->exists($this->row + 1, $this->column)) {

Coding Style introduced 2019-12-15 17:23 UTC by

Arithmetic operation must be bracketed

134

            $this->row += 1;

135

136

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected //end down()

137

138

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Doc comment is empty

139

140

*/

Coding Style introduced 2019-12-15 17:23 UTC by

Missing @return tag in function comment

141

    protected function left(): void

142

Coding Style introduced 2019-12-15 17:23 UTC by

Opening brace should be on the same line as the declaration

143

        if ($this->exists($this->row, $this->column - 1)) {

Coding Style introduced 2019-12-15 17:23 UTC by

Arithmetic operation must be bracketed

144

            $this->column -= 1;

145

146

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected //end left()

147

148

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Doc comment is empty

149

150

*/

Coding Style introduced 2019-12-15 17:23 UTC by

Missing @return tag in function comment

151

    protected function right(): void

152

Coding Style introduced 2019-12-15 17:23 UTC by

Opening brace should be on the same line as the declaration

153

        if ($this->exists($this->row, $this->column + 1)) {

Coding Style introduced 2019-12-15 17:23 UTC by

Arithmetic operation must be bracketed

154

            $this->column += 1;

155

156

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected //end right()

157

158

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Doc comment is empty

159

160

*/

Coding Style introduced 2019-12-15 17:23 UTC by

Missing @return tag in function comment

161

    protected function tryCellSelection(): void

162

Coding Style introduced 2019-12-15 17:23 UTC by

Opening brace should be on the same line as the declaration

163

        // Try to select cell.

164

        if ($this->exists($this->row, $this->column)) {

165

            $option = $this->question->getEntryAt($this->row, $this->column);

Bug introduced 2018-05-23 19:02 UTC by

The method getEntryAt() does not exist on EddIriarte\Console\Inputs\Interfaces\SelectInput. Since it exists in all sub-types, consider adding an abstract or default implementation to EddIriarte\Console\Inputs\Interfaces\SelectInput. ( Ignorable by Annotation )

166

            $this->question->select($option);

167

168

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected //end tryCellSelection()

169

170

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Missing short description in doc comment

Coding Style introduced 2019-12-15 17:23 UTC by

Parameter $char should have a doc-comment as per coding-style.

171

     * @param $char

Coding Style Documentation introduced 2019-12-15 17:23 UTC by

Missing parameter name

172

*/

Coding Style introduced 2019-12-15 17:23 UTC by

Missing @return tag in function comment

173

    protected function tryCellNavigation($char): void

introduced 2019-12-15 17:23 UTC by

Type hint "char" missing for

174

Coding Style introduced 2019-12-15 17:23 UTC by

Opening brace should be on the same line as the declaration

175

        // Did we read an escape sequence?

176

        $char .= fread($this->stream, 2);

177

        if (empty($char[2]) || !in_array($char[2], ['A', 'B', 'C', 'D'])) {

Coding Style introduced 2019-12-15 17:23 UTC by

There must be a single space after a NOT operator; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Short array syntax is not allowed

178

            // Input stream was not an arrow key.

179

            return;

180

181

182

        switch ($char[2]) {

Coding Style introduced 2019-12-15 17:23 UTC by

All SWITCH statements must contain a DEFAULT case

183

            case 'A': // go up!

Coding Style introduced 2019-12-15 17:23 UTC by

Line indented incorrectly; expected 8 spaces, found 12

Coding Style introduced 2019-12-15 17:23 UTC by

Blank lines are not allowed after CASE statements

Coding Style introduced 2019-12-15 17:23 UTC by

Comments may not appear after statements

Coding Style Documentation introduced 2019-12-15 17:23 UTC by

Inline comments must start with a capital letter

184

                $this->up();

185

                break;

Coding Style introduced 2019-12-15 17:23 UTC by

Case breaking statement must be indented 4 spaces from SWITCH keyword

Coding Style introduced 2019-12-15 17:23 UTC by

Case breaking statements must be followed by a single blank line

186

            case 'B': // go down!

Coding Style introduced 2019-12-15 17:23 UTC by

Line indented incorrectly; expected 8 spaces, found 12

Coding Style introduced 2019-12-15 17:23 UTC by

Blank lines are not allowed after CASE statements

Coding Style introduced 2019-12-15 17:23 UTC by

Comments may not appear after statements

Coding Style Documentation introduced 2019-12-15 17:23 UTC by

Inline comments must start with a capital letter

187

                $this->down();

188

                break;

Coding Style introduced 2019-12-15 17:23 UTC by

Case breaking statement must be indented 4 spaces from SWITCH keyword

Coding Style introduced 2019-12-15 17:23 UTC by

Case breaking statements must be followed by a single blank line

189

            case 'C': // go right!

Coding Style introduced 2019-12-15 17:23 UTC by

Line indented incorrectly; expected 8 spaces, found 12

Coding Style introduced 2019-12-15 17:23 UTC by

Blank lines are not allowed after CASE statements

Coding Style introduced 2019-12-15 17:23 UTC by

Comments may not appear after statements

Coding Style Documentation introduced 2019-12-15 17:23 UTC by

Inline comments must start with a capital letter

190

                $this->right();

191

                break;

Coding Style introduced 2019-12-15 17:23 UTC by

Case breaking statement must be indented 4 spaces from SWITCH keyword

Coding Style introduced 2019-12-15 17:23 UTC by

Case breaking statements must be followed by a single blank line

192

            case 'D': // go left!

Coding Style introduced 2019-12-15 17:23 UTC by

Line indented incorrectly; expected 8 spaces, found 12

Coding Style introduced 2019-12-15 17:23 UTC by

Blank lines are not allowed after CASE statements

Coding Style introduced 2019-12-15 17:23 UTC by

Comments may not appear after statements

Coding Style Documentation introduced 2019-12-15 17:23 UTC by

Inline comments must start with a capital letter

193

                $this->left();

194

                break;

Coding Style introduced 2019-12-15 17:23 UTC by

Case breaking statement must be indented 4 spaces from SWITCH keyword

195

196

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected //end tryCellNavigation()

197

198

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Doc comment is empty

199

200

*/

Coding Style introduced 2019-12-15 17:23 UTC by

Missing @return tag in function comment

201

    public function repaint(): void

202

Coding Style introduced 2019-12-15 17:23 UTC by

Opening brace should be on the same line as the declaration

203

        $message = $this->message();

204

        if (!$this->firstRun) {

Coding Style introduced 2019-12-15 17:23 UTC by

There must be a single space after a NOT operator; 0 found

205

            $this->clear();

206

207

208

        $this->firstRun = false;

Coding Style introduced 2019-12-15 17:23 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of false please use FALSE.

209

        $this->output->write($message);

210

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected //end repaint()

211

212

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Doc comment is empty

213

214

*/

Coding Style introduced 2019-12-15 17:23 UTC by

Missing @return tag in function comment

215

    public function clear(): void

216

Coding Style introduced 2019-12-15 17:23 UTC by

Opening brace should be on the same line as the declaration

217

        // Move the cursor to the beginning of the line

Coding Style introduced 2019-12-15 17:23 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

218

        $this->output->write("\x0D");

219

        // Erase the line

Coding Style introduced 2019-12-15 17:23 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

220

        $this->output->write("\x1B[2K");

221

        // Erase previous lines

Coding Style introduced 2019-12-15 17:23 UTC by

Inline comments must end in full-stops, exclamation marks, or question marks

222

        $lines = $this->question->getChunksCount() - 1;

Bug introduced 2018-05-23 19:02 UTC by

The method getChunksCount() does not exist on EddIriarte\Console\Inputs\Interfaces\SelectInput. Since it exists in all sub-types, consider adding an abstract or default implementation to EddIriarte\Console\Inputs\Interfaces\SelectInput. ( Ignorable by Annotation )

Coding Style introduced 2019-12-15 17:23 UTC by

Arithmetic operation must be bracketed

223

        if ($lines > 0) {

224

            $this->output->write(str_repeat("\x1B[1A\x1B[2K", $lines));

225

226

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected //end clear()

227

228

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Missing short description in doc comment

229

     * @return string

230

*/

231

    protected function message(): string

232

Coding Style introduced 2019-12-15 17:23 UTC by

Opening brace should be on the same line as the declaration

233

        $chunkSize = $this->chunkSize();

Coding Style introduced 2019-12-15 17:23 UTC by

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

234

        $chunks = $this->question->getChunks($chunkSize);

Bug introduced 2018-05-23 19:02 UTC by

The method getChunks() does not exist on EddIriarte\Console\Inputs\Interfaces\SelectInput. Since it exists in all sub-types, consider adding an abstract or default implementation to EddIriarte\Console\Inputs\Interfaces\SelectInput. ( Ignorable by Annotation )

Coding Style introduced 2019-12-15 17:23 UTC by

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

235

        $columnSpace = floor(($this->terminalWidth() - ($chunkSize * 5)) / $chunkSize);

236

        return join(PHP_EOL, array_map(function ($entries) use ($chunks, $columnSpace) {

Coding Style introduced 2019-12-15 17:23 UTC by

The opening parenthesis of a multi-line function call should be the last content on the line.

237

            $hasCursor = (bool) ($this->row === array_search($entries, $chunks));

Coding Style introduced 2019-12-15 17:23 UTC by

The value of a comparison must not be assigned to a variable

Coding Style introduced 2019-12-15 17:23 UTC by

A cast statement should not be followed as per the coding-style.

238

            return $this->makeRow($entries, ($hasCursor ? $this->column : -10), $columnSpace);

Coding Style introduced 2019-12-15 17:23 UTC by

Inline IF statements are not allowed

Coding Style introduced 2019-12-15 17:23 UTC by

Inline shorthand IF statement requires brackets around comparison

Bug introduced 2019-12-15 17:23 UTC by

$columnSpace of type double is incompatible with the type integer expected by parameter $columnSpace of EddIriarte\Console\Handl...electHandler::makeRow(). ( Ignorable by Annotation )

239

        }, $chunks));

Coding Style introduced 2019-12-15 17:23 UTC by

For multi-line function calls, the closing parenthesis should be on a new line.

240

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected //end message()

241

242

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Missing short description in doc comment

Coding Style introduced 2019-12-15 17:23 UTC by

Parameter $columnSpace should have a doc-comment as per coding-style.

243

     * @param array $entries

Coding Style introduced 2019-12-15 17:23 UTC by

Missing parameter comment

244

     * @param int $activeColumn

Coding Style introduced 2019-12-15 17:23 UTC by

Missing parameter comment

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 3 spaces after parameter type; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected "integer" but found "int" for parameter type

245

     * @return mixed

246

*/

247

    protected function makeRow(array $entries, int $activeColumn, int $columnSpace)

248

Coding Style introduced 2019-12-15 17:23 UTC by

Opening brace should be on the same line as the declaration

249

        return array_reduce($entries, function ($carry, $item) use ($entries, $activeColumn, $columnSpace) {

Coding Style introduced 2019-12-15 17:23 UTC by

The opening parenthesis of a multi-line function call should be the last content on the line.

250

            $isActive = ($activeColumn === array_search($item, $entries));

Coding Style introduced 2019-12-15 17:23 UTC by

The value of a comparison must not be assigned to a variable

251

            return $carry . $this->makeCell($item, $isActive, $columnSpace);

Coding Style introduced 2019-12-15 17:23 UTC by

Concat operator must not be surrounded by spaces

252

        }, '');

Coding Style introduced 2019-12-15 17:23 UTC by

For multi-line function calls, the closing parenthesis should be on a new line.

253

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected //end makeRow()

254

255

/**

Coding Style introduced 2019-12-15 17:23 UTC by

Missing short description in doc comment

256

     * @param string $option

Coding Style introduced 2019-12-15 17:23 UTC by

Missing parameter comment

257

     * @param bool $hasCursor

Coding Style introduced 2019-12-15 17:23 UTC by

Missing parameter comment

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 3 spaces after parameter type; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected "boolean" but found "bool" for parameter type

258

     * @param int $maxWidth

Coding Style introduced 2019-12-15 17:23 UTC by

Missing parameter comment

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 4 spaces after parameter type; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected "integer" but found "int" for parameter type

259

     * @return string

260

*/

261

    protected function makeCell(string $option, bool $hasCursor = false, int $maxWidth = 20): string

Coding Style introduced 2019-12-15 17:23 UTC by

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of false please use FALSE.

262

Coding Style introduced 2019-12-15 17:23 UTC by

Opening brace should be on the same line as the declaration

263

        $selected = $this->question->isSelected($option);

264

        $name = substr($option, 0, ($maxWidth - 1));

Coding Style introduced 2019-12-15 17:23 UTC by

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

265

266

        return sprintf(

267

            $hasCursor ? ' <hl> %1$s %2$s </hl>' : ' <%3$s> %1$s %2$s </%3$s>',

Coding Style introduced 2019-12-15 17:23 UTC by

Inline IF statements are not allowed

Coding Style introduced 2019-12-15 17:23 UTC by

Inline shorthand IF statement requires brackets around comparison

268

            ($selected ? '●' : '○'),

Coding Style introduced 2019-12-15 17:23 UTC by

Inline IF statements are not allowed

Coding Style introduced 2019-12-15 17:23 UTC by

Inline shorthand IF statement requires brackets around comparison

269

            $name . str_repeat(' ', $maxWidth - mb_strlen($name)),

Coding Style introduced 2019-12-15 17:23 UTC by

Concat operator must not be surrounded by spaces

Coding Style introduced 2019-12-15 17:23 UTC by

Arithmetic operation must be bracketed

270

            ($selected ? 'info' : 'comment')

Coding Style introduced 2019-12-15 17:23 UTC by

Inline IF statements are not allowed

Coding Style introduced 2019-12-15 17:23 UTC by

Inline shorthand IF statement requires brackets around comparison

271

);

272

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected //end makeCell()

273

274

    public function terminalWidth()

Coding Style introduced 2019-12-15 17:23 UTC by

Missing function doc comment

275

Coding Style introduced 2019-12-15 17:23 UTC by

Opening brace should be on the same line as the declaration

276

        return (new Terminal)->getWidth();

277

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 2 blank lines after function; 1 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected //end terminalWidth()

278

279

    public function chunkSize()

Coding Style introduced 2019-12-15 17:23 UTC by

Missing function doc comment

280

Coding Style introduced 2019-12-15 17:23 UTC by

Opening brace should be on the same line as the declaration

281

        $max = $this->terminalWidth();

Coding Style introduced 2019-12-15 17:23 UTC by

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

282

        $largest = array_reduce($this->question->getOptions(), 'max', 0);

283

284

        if ($largest > ($max / 2)) {

285

            return 1;

286

        } elseif ($largest > ($max / 3)) {

Coding Style introduced 2019-12-15 17:23 UTC by

Usage of ELSEIF not allowed; use ELSE IF instead

287

            return 2;

288

        } else {

289

            return 3;

290

291

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 2 blank lines after function; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected 1 blank line before closing function brace; 0 found

Coding Style introduced 2019-12-15 17:23 UTC by

Expected //end chunkSize()

292

Coding Style introduced 2019-12-15 17:23 UTC by

Expected //end class

Coding Style introduced 2019-12-15 17:23 UTC by

As per coding style, files should not end with a newline character.

293

eddiriarte / console-select

SelectHandler::tryCellNavigation() B last analyzed 2020-10-20 07:24 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

SelectHandler::tryCellNavigation() B
last analyzed 2020-10-20 07:24 UTC