CasUser::getSalt() - Code Metrics - Inspection of "refactor: Remove deprecations for next major relea..." - ecphp/cas-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f2694b...92ebee )

by Pol

created 2021-02-18 14:17 UTC

CasUser::getSalt() A

↳ Parent: CasUser

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
ccs	0
cts	0
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace EcPhp\CasBundle\Security\Core\User;

final class CasUser implements CasUserInterface
{
    /**
     * The user storage.
     *
     * @var array<mixed>
     */
    private array $storage;

    /**
     * CasUser constructor.
     *
     * @param array<mixed> $data
     */
    public function __construct(array $data)
    {
        $this->storage = $data;
    }

    /**
     * {@inheritdoc}
     */
    public function eraseCredentials(): void
    {
    }

    /**
     * {@inheritdoc}
     */
    public function get(string $key, $default = null)
    {
        return $this->getStorage()[$key] ?? $default;
    }

    /**
     * {@inheritdoc}
     */
    public function getAttribute(string $key, $default = null)
    {
        return $this->getStorage()['attributes'][$key] ?? $default;
    }

    /**
     * {@inheritdoc}
     */
    public function getAttributes(): array
    {
        return $this->get('attributes', []);
    }

    /**
     * {@inheritdoc}
     */
    public function getPassword(): ?string
    {
        return null;
    }

    /**
     * {@inheritdoc}
     */
    public function getPgt(): ?string
    {
        return $this->get('proxyGrantingTicket');
    }

    /**
     * {@inheritdoc}
     */
    public function getRoles(): array
    {
        return ['ROLE_CAS_AUTHENTICATED'];
    }

    /**
     * {@inheritdoc}
     */
    public function getSalt(): ?string
    {
        return null;
    }

    /**
     * {@inheritdoc}
     */
    public function getUsername(): string
    {
        return $this->get('user');

    }

    /**
     * Get the storage.
     *
     * @return array<mixed>
     */
    private function getStorage(): array
    {
        return $this->storage;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace EcPhp\CasBundle\Security\Core\User;
6
7		final class CasUser implements CasUserInterface
8		{
9		/**
10		* The user storage.
11		*
12		* @var array<mixed>
13		*/
14		private array $storage;
15
16		/**
17		* CasUser constructor.
18		*
19		* @param array<mixed> $data
20		*/
21		public function __construct(array $data)
22		{
23		$this->storage = $data;
24	9	}
25
26	9	/**
27	9	* {@inheritdoc}
28		*/
29		public function eraseCredentials(): void
30		{
31		}
32
33		/**
34		* {@inheritdoc}
35		*/
36		public function get(string $key, $default = null)
37		{
38		return $this->getStorage()[$key] ?? $default;
39	3	}
40
41	3	/**
42		* {@inheritdoc}
43		*/
44		public function getAttribute(string $key, $default = null)
45		{
46		return $this->getStorage()['attributes'][$key] ?? $default;
47	1	}
48
49	1	/**
50		* {@inheritdoc}
51		*/
52		public function getAttributes(): array
53		{
54		return $this->get('attributes', []);
55	1	}
56
57	1	/**
58		* {@inheritdoc}
59		*/
60		public function getPassword(): ?string
61		{
62		return null;
63		}
64
65		/**
66		* {@inheritdoc}
67		*/
68		public function getPgt(): ?string
69		{
70		return $this->get('proxyGrantingTicket');
71	1	}
72
73	1	/**
74		* {@inheritdoc}
75		*/
76		public function getRoles(): array
77		{
78		return ['ROLE_CAS_AUTHENTICATED'];
79	1	}
80
81	1	/**
82		* {@inheritdoc}
83		*/
84		public function getSalt(): ?string
85		{
86		return null;
87		}
88
89		/**
90		* {@inheritdoc}
91		*/
92		public function getUsername(): string
93		{
94		return $this->get('user');
		0 ignored issues – show Bug Best Practice introduced 2020-01-30 10:21 UTC by Report Bug Copy Issue Report The expression `return $this->get('user')` could return the type `null` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
95		}
96
97		/**
98		* Get the storage.
99		*
100		* @return array<mixed>
101		*/
102		private function getStorage(): array
103		{
104		return $this->storage;
105		}
106		}
107

ecphp / cas-bundle

Push — master ( f2694b...92ebee )

CasUser::getSalt() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like