Stack::__construct() - Code Metrics - Inspection of "Refactoring" - eclipxe13/generic-collections - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#5)

by Carlos C

created 2016-06-03 05:20 UTC

Stack::__construct() A

↳ Parent: Stack

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	7
Ratio	100 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	7
loc	7
ccs	6
cts	6
cp	1
rs	9.4285
cc	1
eloc	5
nc	1
nop	3
crap	1

<?php namespace GenericCollections;

use GenericCollections\Abstracts\AbstractStack;
use GenericCollections\Interfaces\StackInterface;
use GenericCollections\Traits\ElementTypeProperty;
use GenericCollections\Traits\OptionsProperty;
use GenericCollections\Utils\TypeProperty;

/**
 * Generic Stack implementation (LIFO behavior)
 *
 * Options:
 * - Defaults: not allow nulls, allow duplicates, identical comparisons
 *
 * It is not recommended to allow nulls since several methods
 * (element, peek, poll)
 * returns null if not found or empty
 *
 * It is not recommended to set unique values option, this will search inside the
 * container on every insert and it could be expensive on large containers
 *
 * @package GenericCollections
 */
class Stack extends AbstractStack implements StackInterface

{
    use ElementTypeProperty;
    use OptionsProperty;

    /**
     * @param string $elementType
     * @param array $elements
     * @param int $options
     */
    public function __construct($elementType, array $elements = [], $options = 0)
    {
        $this->options = new Options($options);
        $this->elementType = new TypeProperty($elementType, $this->optionAllowNullMembers());
        $this->createStorageObject();
        $this->addAll($elements);
    }
}


1			<?php namespace GenericCollections;
2
3			use GenericCollections\Abstracts\AbstractStack;
4			use GenericCollections\Interfaces\StackInterface;
5			use GenericCollections\Traits\ElementTypeProperty;
6			use GenericCollections\Traits\OptionsProperty;
7			use GenericCollections\Utils\TypeProperty;
8
9			/**
10			* Generic Stack implementation (LIFO behavior)
11			*
12			* Options:
13			* - Defaults: not allow nulls, allow duplicates, identical comparisons
14			*
15			* It is not recommended to allow nulls since several methods
16			* (element, peek, poll)
17			* returns null if not found or empty
18			*
19			* It is not recommended to set unique values option, this will search inside the
20			* container on every insert and it could be expensive on large containers
21			*
22			* @package GenericCollections
23			*/
24		View Code Duplication	class Stack extends AbstractStack implements StackInterface
			0 ignored issues – show Duplication introduced 2016-06-01 04:10 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25			{
26			use ElementTypeProperty;
27			use OptionsProperty;
28
29			/**
30			* @param string $elementType
31			* @param array $elements
32			* @param int $options
33			*/
34	24		public function __construct($elementType, array $elements = [], $options = 0)
35			{
36	24		$this->options = new Options($options);
37	24		$this->elementType = new TypeProperty($elementType, $this->optionAllowNullMembers());
38	24		$this->createStorageObject();
39	24		$this->addAll($elements);
40	24		}
41			}
42

eclipxe13 / generic-collections

Pull Request — master (#5)

Stack::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like