View GitHub Repository symfony-layer

Schedule Inspection
Subscribe
Passed
Push — master ( d3b643...7b5fb9 )
by Darío
10:33 queued 08:00
created

SymfonyAdapter::request()   A

↳ Parent: SymfonyAdapter

Complexity

Conditions 3
Paths 5

Size

Total Lines 13
Code Lines 8

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 8
CRAP Score 3

Importance

Changes 0
Metric Value
eloc 8
c 0
b 0
f 0
dl 0
loc 13
ccs 8
cts 8
cp 1
rs 10
cc 3
nc 5
nop 1
crap 3
1 
<?php
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
namespace EasyHttp\SymfonyLayer;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
use EasyHttp\LayerContracts\Contracts\HttpClientAdapter;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
use EasyHttp\LayerContracts\Contracts\HttpClientRequest;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
use EasyHttp\LayerContracts\Contracts\HttpClientResponse;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
use EasyHttp\LayerContracts\Exceptions\HttpClientException;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
use Symfony\Component\HttpClient\Exception\ClientException;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
use Symfony\Component\HttpClient\Exception\RedirectionException;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
use Symfony\Component\HttpClient\Exception\ServerException;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
use Symfony\Component\HttpClient\Exception\TransportException;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
use Symfony\Contracts\HttpClient\Exception\TransportExceptionInterface;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
use Symfony\Contracts\HttpClient\HttpClientInterface;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
class SymfonyAdapter implements HttpClientAdapter

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
{

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
    protected HttpClientInterface $client;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    20
                

                                    
                             14                         
                
                
                
    public function __construct(HttpClientInterface $client)

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                
    {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    22
                

                                    
                             14                         
                
                
                
        $this->client = $client;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    23
                

                                    
                             14                         
                
                
                
    }

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    24
                

                                    
                                                    
                
                
                

            


            
                                                                        
                            
            
                                    
            
            

                
                    25
                

                                    
                             14                         
                
                
                
    public function request(HttpClientRequest $request): HttpClientResponse

            


            
                                                                        
                            
            
                                    
            
            

                
                    26
                

                                    
                                                    
                
                
                
    {

            


            
                                                                        
                            
            
                                    
            
            

                
                    27
                

                                    
                                                    
                
                
                
        try {

            


            
                                                                        
                            
            
                                    
            
            

                
                    28
                

                                    
                             14                         
                
                
                
            $response = $this->client->request($request->getMethod(), $request->getUri(), $request->options());

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                        

                                        
The method options() does not exist on EasyHttp\LayerContracts\...racts\HttpClientRequest. It seems like you code against a sub-type of EasyHttp\LayerContracts\...racts\HttpClientRequest such as EasyHttp\SymfonyLayer\SymfonyRequest.
                                                                                   (
                                     Ignorable by Annotation
                                )
                                

                                    
 If this is a false-positive, you can also ignore this issue in your code via the ignore-call   annotation

                                    

                                        

                                            28
                                            
                                                
            $response = $this->client->request($request->getMethod(), $request->getUri(), $request->/** @scrutinizer ignore-call */ options());

                                        

                                                                            

                                

                                                                                                                                                                                                                                                                                        

                    
                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                                        
                            
            
                                    
            
            

                
                    29
                

                                    
                                                    
                
                
                

            


            
                                                                        
                            
            
                                    
            
            

                
                    30
                

                                    
                             12                         
                
                
                
            return new SymfonyResponse($response, $response->getContent());

            


            
                                                                        
                            
            
                                    
            
            

                
                    31
                

                                    
                             3                         
                
                
                
        } catch (ClientException | RedirectionException $exception) {

            


            
                                                                        
                            
            
                                    
            
            

                
                    32
                

                                    
                             1                         
                
                
                
            $response = $exception->getResponse();

            


            
                                                                        
                            
            
                                    
            
            

                
                    33
                

                                    
                             2                         
                
                
                
        } catch (ServerException | TransportException | TransportExceptionInterface $exception) {

            


            
                                                                        
                            
            
                                    
            
            

                
                    34
                

                                    
                             2                         
                
                
                
            throw HttpClientException::fromThrowable($exception);

            


            
                                                                        
                            
            
                                    
            
            

                
                    35
                

                                    
                                                    
                
                
                
        }

            


            
                                                                        
                            
            
                                    
            
            

                
                    36
                

                                    
                                                    
                
                
                

            


            
                                                                        
                            
            
                                    
            
            

                
                    37
                

                                    
                             1                         
                
                
                
        return new SymfonyResponse($response);

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    38
                

                                    
                                                    
                
                
                
    }

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    39
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    40