PathMatchExpectation::from() - Code Metrics - Inspection of "fix: ignore expectation when is not defined" - easy-http/mock-builder - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/refactor-to-reduce-com... ( 586015...c592a9 )

by Darío

created 2022-05-04 17:14 UTC

PathMatchExpectation::from() A

↳ Parent: PathMatchExpectation

Complexity

Conditions	3
Paths	1

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	4
c	2
b	0
f	0
dl	0
loc	9
ccs	5
cts	5
cp	1
rs	10
cc	3
nc	1
nop	1
crap	3

<?php

namespace EasyHttp\MockBuilder\Expectations;

use EasyHttp\MockBuilder\Expectation;
use GuzzleHttp\Promise\RejectedPromise;
use Psr\Http\Message\RequestInterface;

class PathMatchExpectation
{
    public static function from(Expectation $expectation): callable
    {
        return function ($request) use ($expectation) {
            /** @var RequestInterface $request */
            if (!is_null($expectation->getPathRegex()) && !self::matches($expectation, $request)) {
                return new RejectedPromise('path does not match expectation');
            }

            return $request;
        };
    }

    private static function matches($expectation, $request): bool
    {
        return preg_match($expectation->getPathRegex(), $request->getUri()->getPath(), $matches);

    }
}


1		<?php
2
3		namespace EasyHttp\MockBuilder\Expectations;
4
5		use EasyHttp\MockBuilder\Expectation;
6		use GuzzleHttp\Promise\RejectedPromise;
7		use Psr\Http\Message\RequestInterface;
8
9		class PathMatchExpectation
10		{
11	109	public static function from(Expectation $expectation): callable
12		{
13	109	return function ($request) use ($expectation) {
14		/** @var RequestInterface $request */
15	107	if (!is_null($expectation->getPathRegex()) && !self::matches($expectation, $request)) {
16	1	return new RejectedPromise('path does not match expectation');
17		}
18
19	106	return $request;
20		};
21		}
22
23	2	private static function matches($expectation, $request): bool
24		{
25	2	return preg_match($expectation->getPathRegex(), $request->getUri()->getPath(), $matches);
		0 ignored issues – show Bug Best Practice introduced 2022-05-04 17:16 UTC by Report Bug Copy Issue Report The expression `return preg_match($expec...)->getPath(), $matches)` returns the type `integer` which is incompatible with the type-hinted return `boolean`. Loading history...
26		}
27		}
28

easy-http / mock-builder

Push — feature/refactor-to-reduce-com... ( 586015...c592a9 )

PathMatchExpectation::from() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like