Issues (7)

src/Station.php (3 issues)

1
<?php
2
3
namespace Earnould\LaravelVeloApi;
4
5
use Earnould\LaravelVeloApi\Facades\VeloStations;
0 ignored issues
show
This use statement conflicts with another class in this namespace, Earnould\LaravelVeloApi\VeloStations. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
6
7
class Station
8
{
9
    protected $values = [];
10
11 3
    public function __construct(array $args)
12
    {
13 3
        $this->values = $args;
14 3
    }
15
16 1
    public function refreshStatus()
17
    {
18 1
        $statuses = VeloStations::statuses();
0 ignored issues
show
The method statuses() does not exist on Earnould\LaravelVeloApi\Facades\VeloStations. Since you implemented __callStatic, consider adding a @method annotation. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

18
        /** @scrutinizer ignore-call */ 
19
        $statuses = VeloStations::statuses();
Loading history...
19 1
        $this->setStatus($statuses->firstWhere('id', $this->id));
0 ignored issues
show
Bug Best Practice introduced by
The property id does not exist on Earnould\LaravelVeloApi\Station. Since you implemented __get, consider adding a @property annotation.
Loading history...
20
21 1
        return $this;
22
    }
23
24 2
    public function setStatus(array $status)
25
    {
26 2
        $this->values = array_merge($this->values, $status);
27 2
    }
28
29 2
    public function __get($key)
30
    {
31 2
        if (! isset($this->values[$key])) {
32 1
            return;
33
        }
34
35 2
        return $this->values[$key];
36
    }
37
}
38