App\Modules\Posts\Api\Controller\PostsCommandController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Test Coverage

Coverage

87.5%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	deletePost()	0	9	2
A	updatePost()	0	9	2
A	__construct()	0	4	1
A	createPost()	0	5	1

<?php

namespace App\Modules\Posts\Api\Controller;

use App\Infrastructure\Security\Permission;
use App\Modules\Posts\Api\Command\CreatePostCommand;
use App\Modules\Posts\Api\Command\DeletePostCommand;
use App\Modules\Posts\Api\Command\UpdatePostCommand;
use App\Modules\Posts\Api\PostsApiInterface;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Uid\Ulid;

#[Route('/api/admin/posts')]
class PostsCommandController extends AbstractController
{
    /**
     * @param PostsApiInterface $postsApi
     */
    public function __construct(
        private PostsApiInterface $postsApi
    )
    {
    }

    /**
     * @param CreatePostCommand $command
     * @return Response
     */
    #[Route('/', methods: ['POST'])]
    public function createPost(CreatePostCommand $command): Response
    {
        return $this->json(
            $this->postsApi->createPost($command)
        );
    }

    /**
     * @param UpdatePostCommand $command
     * @param string $id
     * @return Response
     */
    #[Route('/{id}', methods: ['PUT'])]
    public function updatePost(UpdatePostCommand $command, string $id): Response
    {
        $command->setId(new Ulid($id));
        if(!$this->isGranted(Permission::EDIT, $command)) {
            throw new UnauthorizedHttpException(Permission::EDIT);
        }
        $this->postsApi->updatePost($command);

It seems like $command can also be of type null; however, parameter $command of App\Modules\Posts\Api\PostsApiInterface::updatePost() does only seem to accept App\Modules\Posts\Api\Command\UpdatePostCommand, maybe add an additional type check?

        return new Response();
    }

    /**
     * @param string $id
     * @return Response
     */
    #[Route('/{id}', methods: ['DELETE'])]
    public function deletePost(string $id): Response
    {
        $command = new DeletePostCommand(new Ulid($id));
        if(!$this->isGranted(Permission::DELETE, $command)) {
            throw new UnauthorizedHttpException(Permission::DELETE);
        }
        $this->postsApi->deletePost($command);

It seems like $command can also be of type null; however, parameter $command of App\Modules\Posts\Api\PostsApiInterface::deletePost() does only seem to accept App\Modules\Posts\Api\Command\DeletePostCommand, maybe add an additional type check?

        return new Response();
    }

}