SecurityIntegrationTest::createAuthenticatedClient() - Code Metrics - Inspection of "code style" - eXsio/php-symfony-arch - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( e090ab...58e8d0 )

by Slawomir

created 2021-11-26 08:45 UTC

createAuthenticatedClient() A

↳ Parent: SecurityIntegrationTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	4
c	0
b	0
f	0
nc	1
nop	0
dl	0
loc	7
rs	10

<?php

namespace App\Tests\Modules\Security\Integration;

use App\Tests\TestUtils\IntegrationTest;
use DusanKasan\Knapsack\Collection;
use Symfony\Bundle\FrameworkBundle\KernelBrowser;

abstract class SecurityIntegrationTest extends IntegrationTest
{

    protected ?string $token = null;

    /**
     * Create a client with a default Authorization header.
     *
     *
     * @return KernelBrowser
     */
    protected function createAuthenticatedClient(): KernelBrowser
    {
        $client = static::createClient();
        $client->setServerParameter('HTTP_Authorization', sprintf('Bearer %s',
                $this->createToken($client))
        );
        return $client;
    }

    private function createToken(KernelBrowser $client): string
    {
        $client->request(
            'POST',
            '/api/login_check',
            array(),
            array(),
            array('CONTENT_TYPE' => 'application/json'),
            json_encode(array(
                'username' => self::DEFAULT_USER_ID,
                'password' => self::DEFAULT_USER_PASSWORD,
            ))
        );
        $cookies = $client->getResponse()->headers->getCookies();
        $bearer = Collection::from($cookies)
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
            ->find(function ($c) {
                return $c->getName() == "BEARER";
            });
        if ($bearer == null) {

            $this->fail("Unable to Authenticate in Test");
        }
        $this->token = $bearer->getValue();
        return $this->token;
    }
}

1			<?php
2
3			namespace App\Tests\Modules\Security\Integration;
4
5			use App\Tests\TestUtils\IntegrationTest;
6			use DusanKasan\Knapsack\Collection;
7			use Symfony\Bundle\FrameworkBundle\KernelBrowser;
8
9			abstract class SecurityIntegrationTest extends IntegrationTest
10			{
11
12			protected ?string $token = null;
13
14			/**
15			* Create a client with a default Authorization header.
16			*
17			*
18			* @return KernelBrowser
19			*/
20			protected function createAuthenticatedClient(): KernelBrowser
21			{
22			$client = static::createClient();
23			$client->setServerParameter('HTTP_Authorization', sprintf('Bearer %s',
24			$this->createToken($client))
25			);
26			return $client;
27			}
28
29			private function createToken(KernelBrowser $client): string
30			{
31			$client->request(
32			'POST',
33			'/api/login_check',
34			array(),
35			array(),
36			array('CONTENT_TYPE' => 'application/json'),
37			json_encode(array(
38			'username' => self::DEFAULT_USER_ID,
39			'password' => self::DEFAULT_USER_PASSWORD,
40			))
41			);
42			$cookies = $client->getResponse()->headers->getCookies();
43			$bearer = Collection::from($cookies)
			1 ignored issue – show Bug introduced 2021-11-25 10:27 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$bearer` is correct as `DusanKasan\Knapsack\Coll...ion(...) { /* ... */ })` targeting `DusanKasan\Knapsack\Collection::find()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
44			->find(function ($c) {
45			return $c->getName() == "BEARER";
46			});
47			if ($bearer == null) {
			1 ignored issue – show introduced 2021-11-25 10:27 UTC by Report Bug Copy Issue Report The condition `$bearer == null` is always `true`. Loading history...
48			$this->fail("Unable to Authenticate in Test");
49			}
50			$this->token = $bearer->getValue();
51			return $this->token;
52			}
53			}

eXsio / php-symfony-arch

Push — main ( e090ab...58e8d0 )

createAuthenticatedClient() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like