JukeboxWindowFactory::__construct() - Code Metrics - Inspection of "Merge pull request #103 from eXpansionPluginPack/j..." - eXpansionPluginPack/eXpansion2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (220ce5)

by De Cramer

created 2017-08-02 13:35 UTC

JukeboxWindowFactory::__construct() A

↳ Parent: JukeboxWindowFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	23
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	23
ccs	0
cts	22
cp	0
rs	9.0856
c	0
b	0
f	0
cc	1
eloc	20
nc	1
nop	11
crap	2

How to fix Many Parameters

<?php


namespace eXpansion\Bundle\Maps\Plugins\Gui;

use eXpansion\Bundle\Acme\Plugins\Gui\WindowFactory;
use eXpansion\Bundle\LocalRecords\Entity\Record;
use eXpansion\Bundle\Maps\Plugins\Jukebox;
use eXpansion\Bundle\Maps\Services\JukeboxService;
use eXpansion\Framework\AdminGroups\Helpers\AdminGroups;
use eXpansion\Framework\Core\Helpers\Time;
use eXpansion\Framework\Core\Model\Gui\Grid\DataCollectionFactory;
use eXpansion\Framework\Core\Model\Gui\Grid\GridBuilder;
use eXpansion\Framework\Core\Model\Gui\Grid\GridBuilderFactory;
use eXpansion\Framework\Core\Model\Gui\ManialinkInterface;
use eXpansion\Framework\Core\Model\Gui\WindowFactoryContext;
use eXpansion\Framework\Core\Model\UserGroups\Group;
use eXpansion\Framework\Core\Plugins\Gui\GridWindowFactory;
use eXpansion\Framework\Gui\Components\uiButton;
use FML\Controls\Frame;
use Maniaplanet\DedicatedServer\Structures\Map;


/**
 * Class RecordsWindowFactory
 *
 * @package eXpansion\Bundle\LocalRecords\Plugins\Gui;
 * @author  reaby
 */
class JukeboxWindowFactory extends GridWindowFactory
{
    public $sizeX;
    public $sizeY;

    /** @var GridBuilderFactory */
    protected $gridBuilderFactory;

    /** @var DataCollectionFactory */
    protected $dataCollectionFactory;

    /** @var Time */
    protected $timeFormatter;
    /**
     * @var Jukebox
     */
    private $jukeboxPlugin;
    /**
     * @var JukeboxService
     */
    private $jukeboxService;
    /**
     * @var AdminGroups
     */
    private $adminGroups;

    /**
     * MapsWindowFactory constructor.
     * @param $name
     * @param $sizeX
     * @param $sizeY
     * @param null $posX
     * @param null $posY
     * @param WindowFactoryContext $context
     * @param GridBuilderFactory $gridBuilderFactory
     * @param DataCollectionFactory $dataCollectionFactory
     * @param Time $time
     * @param JukeboxService $jukeboxService
     * @param AdminGroups $adminGroups
     */
    public function __construct(
        $name,
        $sizeX,
        $sizeY,
        $posX,
        $posY,
        WindowFactoryContext $context,
        GridBuilderFactory $gridBuilderFactory,
        DataCollectionFactory $dataCollectionFactory,
        Time $time,
        JukeboxService $jukeboxService,
        AdminGroups $adminGroups
    ) {
        parent::__construct($name, $sizeX, $sizeY, $posX, $posY, $context);

        $this->gridBuilderFactory = $gridBuilderFactory;
        $this->dataCollectionFactory = $dataCollectionFactory;
        $this->timeFormatter = $time;
        $this->sizeX = $sizeX;
        $this->sizeY = $sizeY;
        $this->jukeboxService = $jukeboxService;
        $this->adminGroups = $adminGroups;
    }

    public function setJukeboxPlugin(Jukebox $plugin)
    {
        $this->jukeboxPlugin = $plugin;
    }

    /**
     * @param ManialinkInterface $manialink
     * @return void
     */
    protected function createGrid(ManialinkInterface $manialink)
    {
        $collection = $this->dataCollectionFactory->create($this->getData());
        $collection->setPageSize(20);

        $queueButton = $this->uiFactory->createButton('drop', uiButton::TYPE_DEFAULT);
        $queueButton->setTextColor("000")->setSize(12, 5)->setTranslate(true);

        $gridBuilder = $this->gridBuilderFactory->create();
        $gridBuilder->setManialink($manialink)
            ->setDataCollection($collection)
            ->setManialinkFactory($this)
            ->addTextColumn(
                'index',
                'expansion_maps.gui.window.column.index',
                1,
                true,
                false
            )->addTextColumn(
                'name',
                'expansion_maps.gui.window.column.name',
                3,
                true,
                false
            )->addTextColumn(
                'time',
                'expansion_maps.gui.window.column.goldtime',
                2,
                true,
                false
            )->addTextColumn(
                'nickname',
                'expansion_maps.gui.window.column.nickname',
                3,
                true,
                false
            )
            ->addActionColumn('map', 'expansion_maps.gui.window.column.drop', 2, array($this, 'callbackDropMap'),
                $queueButton);
        $contentFrame = $manialink->getContentFrame();
        $this->setGridSize($contentFrame->getWidth(), $contentFrame->getHeight() - 12);
        $this->setGridPosition(0, -10);
        $manialink->setData('grid', $gridBuilder);
    }

    public function callbackClear($login)
    {
        $this->jukeboxPlugin->clear($login);
        $group = $this->groupFactory->createForPlayer($login);
        $this->update($group);
    }

    public function callbackDrop($login)
    {

        $this->jukeboxPlugin->drop($login, null);
        $group = $this->groupFactory->createForPlayer($login);
        $this->update($group);
    }

    public function callbackDropMap($login, $params, $args)
    {
        $this->jukeboxPlugin->drop($login, $args['map']);
        $group = $this->groupFactory->createForPlayer($login);
        $this->update($group);
    }

    public function createContent(ManialinkInterface $manialink)
    {
        parent::createContent($manialink);

        $line = $this->uiFactory->createLayoutLine(0, 0, [], 2);

        $dropButton = $this->uiFactory->createButton("expansion_maps.gui.button.drop", uiButton::TYPE_DECORATED);
        $dropButton->setAction($this->actionFactory->createManialinkAction($manialink, [$this, 'callbackDrop'], null));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $line->addChild($dropButton);

        $clearButton = $this->uiFactory->createButton("expansion_maps.gui.button.clear");
        $clearButton->setAction($this->actionFactory->createManialinkAction($manialink, [$this, 'callbackClear'],
            null))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setFocusColor('f00')
            ->setBorderColor('d00')
            ->setTextColor('fff')
            ->setTranslate(true);

        if ($this->adminGroups->hasPermission($manialink->getUserGroup(), "jukebox")) {
            $line->addChild($clearButton);
        }
        $manialink->addChild($line);
    }

    protected function updateContent(ManialinkInterface $manialink)
    {
        $this->updateMaps();
        parent::updateContent($manialink);
    }

    public function updateMaps()
    {
        /**
         * @var string $i
         * @var Map $map
         */
        $this->setData([]);

        $i = 1;
        $data = [];
        foreach ($this->jukeboxService->getMapQueue() as $idx => $jbMap) {
            $map = $jbMap->getMap();
            $data[] = [
                'index' => $i++,
                'name' => $map->name,
                'nickname' => $jbMap->getPlayer()->getNickName(),
                'time' => $this->timeFormatter->timeToText($map->goldTime, true),
                'map' => $jbMap,
            ];
        }
        $this->setData($data);
    }


}


1			<?php
2
3
4			namespace eXpansion\Bundle\Maps\Plugins\Gui;
5
6			use eXpansion\Bundle\Acme\Plugins\Gui\WindowFactory;
7			use eXpansion\Bundle\LocalRecords\Entity\Record;
8			use eXpansion\Bundle\Maps\Plugins\Jukebox;
9			use eXpansion\Bundle\Maps\Services\JukeboxService;
10			use eXpansion\Framework\AdminGroups\Helpers\AdminGroups;
11			use eXpansion\Framework\Core\Helpers\Time;
12			use eXpansion\Framework\Core\Model\Gui\Grid\DataCollectionFactory;
13			use eXpansion\Framework\Core\Model\Gui\Grid\GridBuilder;
14			use eXpansion\Framework\Core\Model\Gui\Grid\GridBuilderFactory;
15			use eXpansion\Framework\Core\Model\Gui\ManialinkInterface;
16			use eXpansion\Framework\Core\Model\Gui\WindowFactoryContext;
17			use eXpansion\Framework\Core\Model\UserGroups\Group;
18			use eXpansion\Framework\Core\Plugins\Gui\GridWindowFactory;
19			use eXpansion\Framework\Gui\Components\uiButton;
20			use FML\Controls\Frame;
21			use Maniaplanet\DedicatedServer\Structures\Map;
22
23
24			/**
25			* Class RecordsWindowFactory
26			*
27			* @package eXpansion\Bundle\LocalRecords\Plugins\Gui;
28			* @author reaby
29			*/
30			class JukeboxWindowFactory extends GridWindowFactory
31			{
32			public $sizeX;
33			public $sizeY;
34
35			/** @var GridBuilderFactory */
36			protected $gridBuilderFactory;
37
38			/** @var DataCollectionFactory */
39			protected $dataCollectionFactory;
40
41			/** @var Time */
42			protected $timeFormatter;
43			/**
44			* @var Jukebox
45			*/
46			private $jukeboxPlugin;
47			/**
48			* @var JukeboxService
49			*/
50			private $jukeboxService;
51			/**
52			* @var AdminGroups
53			*/
54			private $adminGroups;
55
56			/**
57			* MapsWindowFactory constructor.
58			* @param $name
59			* @param $sizeX
60			* @param $sizeY
61			* @param null $posX
62			* @param null $posY
63			* @param WindowFactoryContext $context
64			* @param GridBuilderFactory $gridBuilderFactory
65			* @param DataCollectionFactory $dataCollectionFactory
66			* @param Time $time
67			* @param JukeboxService $jukeboxService
68			* @param AdminGroups $adminGroups
69			*/
70			public function __construct(
71			$name,
72			$sizeX,
73			$sizeY,
74			$posX,
75			$posY,
76			WindowFactoryContext $context,
77			GridBuilderFactory $gridBuilderFactory,
78			DataCollectionFactory $dataCollectionFactory,
79			Time $time,
80			JukeboxService $jukeboxService,
81			AdminGroups $adminGroups
82			) {
83			parent::__construct($name, $sizeX, $sizeY, $posX, $posY, $context);
84
85			$this->gridBuilderFactory = $gridBuilderFactory;
86			$this->dataCollectionFactory = $dataCollectionFactory;
87			$this->timeFormatter = $time;
88			$this->sizeX = $sizeX;
89			$this->sizeY = $sizeY;
90			$this->jukeboxService = $jukeboxService;
91			$this->adminGroups = $adminGroups;
92			}
93
94			public function setJukeboxPlugin(Jukebox $plugin)
95			{
96			$this->jukeboxPlugin = $plugin;
97			}
98
99			/**
100			* @param ManialinkInterface $manialink
101			* @return void
102			*/
103			protected function createGrid(ManialinkInterface $manialink)
104			{
105			$collection = $this->dataCollectionFactory->create($this->getData());
106			$collection->setPageSize(20);
107
108			$queueButton = $this->uiFactory->createButton('drop', uiButton::TYPE_DEFAULT);
109			$queueButton->setTextColor("000")->setSize(12, 5)->setTranslate(true);
110
111			$gridBuilder = $this->gridBuilderFactory->create();
112			$gridBuilder->setManialink($manialink)
113			->setDataCollection($collection)
114			->setManialinkFactory($this)
115			->addTextColumn(
116			'index',
117			'expansion_maps.gui.window.column.index',
118			1,
119			true,
120			false
121			)->addTextColumn(
122			'name',
123			'expansion_maps.gui.window.column.name',
124			3,
125			true,
126			false
127			)->addTextColumn(
128			'time',
129			'expansion_maps.gui.window.column.goldtime',
130			2,
131			true,
132			false
133			)->addTextColumn(
134			'nickname',
135			'expansion_maps.gui.window.column.nickname',
136			3,
137			true,
138			false
139			)
140			->addActionColumn('map', 'expansion_maps.gui.window.column.drop', 2, array($this, 'callbackDropMap'),
141			$queueButton);
142			$contentFrame = $manialink->getContentFrame();
143			$this->setGridSize($contentFrame->getWidth(), $contentFrame->getHeight() - 12);
144			$this->setGridPosition(0, -10);
145			$manialink->setData('grid', $gridBuilder);
146			}
147
148			public function callbackClear($login)
149			{
150			$this->jukeboxPlugin->clear($login);
151			$group = $this->groupFactory->createForPlayer($login);
152			$this->update($group);
153			}
154
155			public function callbackDrop($login)
156			{
157
158			$this->jukeboxPlugin->drop($login, null);
159			$group = $this->groupFactory->createForPlayer($login);
160			$this->update($group);
161			}
162
163			public function callbackDropMap($login, $params, $args)
164			{
165			$this->jukeboxPlugin->drop($login, $args['map']);
166			$group = $this->groupFactory->createForPlayer($login);
167			$this->update($group);
168			}
169
170			public function createContent(ManialinkInterface $manialink)
171			{
172			parent::createContent($manialink);
173
174			$line = $this->uiFactory->createLayoutLine(0, 0, [], 2);
175
176			$dropButton = $this->uiFactory->createButton("expansion_maps.gui.button.drop", uiButton::TYPE_DECORATED);
177			$dropButton->setAction($this->actionFactory->createManialinkAction($manialink, [$this, 'callbackDrop'], null));
			0 ignored issues – show Documentation introduced 2017-08-01 13:07 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
178			$line->addChild($dropButton);
179
180			$clearButton = $this->uiFactory->createButton("expansion_maps.gui.button.clear");
181			$clearButton->setAction($this->actionFactory->createManialinkAction($manialink, [$this, 'callbackClear'],
182			null))
			0 ignored issues – show Documentation introduced 2017-08-01 13:07 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
183			->setFocusColor('f00')
184			->setBorderColor('d00')
185			->setTextColor('fff')
186			->setTranslate(true);
187
188			if ($this->adminGroups->hasPermission($manialink->getUserGroup(), "jukebox")) {
189			$line->addChild($clearButton);
190			}
191			$manialink->addChild($line);
192			}
193
194			protected function updateContent(ManialinkInterface $manialink)
195			{
196			$this->updateMaps();
197			parent::updateContent($manialink);
198			}
199
200			public function updateMaps()
201			{
202			/**
203			* @var string $i
204			* @var Map $map
205			*/
206			$this->setData([]);
207
208			$i = 1;
209			$data = [];
210			foreach ($this->jukeboxService->getMapQueue() as $idx => $jbMap) {
211			$map = $jbMap->getMap();
212			$data[] = [
213			'index' => $i++,
214			'name' => $map->name,
215			'nickname' => $jbMap->getPlayer()->getNickName(),
216			'time' => $this->timeFormatter->timeToText($map->goldTime, true),
217			'map' => $jbMap,
218			];
219			}
220			$this->setData($data);
221			}
222
223
224			}
225

eXpansionPluginPack / eXpansion2

Branch — master (220ce5)

JukeboxWindowFactory::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like