eXpansion\Bundle\JoinLeaveMessages\Plugins\JoinLeaveMessages

Complexity

Total Complexity

8

Size/Duplication

Total Lines	66
Duplicated Lines	21.21 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	onRun()	0	5	1
A	onPlayerConnect()	7	7	2
A	onPlayerDisconnect()	7	7	2
A	onPlayerInfoChanged()	0	3	1
A	onPlayerAlliesChanged()	0	3	1

<?php

namespace eXpansion\Bundle\JoinLeaveMessages\Plugins;

use eXpansion\Core\DataProviders\Listener\PlayerDataListenerInterface;
use eXpansion\Core\Services\Console;
use eXpansion\Core\Storage\Data\Player;
use Maniaplanet\DedicatedServer\Connection;

class JoinLeaveMessages implements PlayerDataListenerInterface
{
    /** @var Connection  */
    protected $connection;
    /** @var Console  */
    protected $console;
    /** @var bool  */
    private $enabled = true;

    /**
     * JoinLeaveMessages constructor.
     *
     * @param Connection $connection
     * @param Console $console
     */
    function __construct(Connection $connection, Console $console)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->connection = $connection;
        $this->console = $console;
    }

    /**
     * @inheritdoc
     */
    public function onRun()
    {
        // @todo make this callback work!
        $this->enabled = true;
    }

    /**
     * @inheritdoc
     */
    public function onPlayerConnect(Player $player)

This method seems to be duplicated in your project.

    {
        $msg = '$fffHello, ' . $player->getNickName() . '  $n$fff($888' . $player->getLogin() . '$fff)';
        if ($this->enabled) {
            $this->connection->chatSendServerMessage($msg);
        }
    }

    /**
     * @inheritdoc
     */
    public function onPlayerDisconnect(Player $player, $disconnectionReason)

This method seems to be duplicated in your project.

    {
        $msg = '$fffSee you, ' . $player->getNickName() . '  $n$fff($888' . $player->getLogin() . '$fff)';
        if ($this->enabled) {
            $this->connection->chatSendServerMessage($msg);
        }
    }

    /**
     * @inheritdoc
     */
    public function onPlayerInfoChanged(Player $oldPlayer, Player $player)
    {
    }

    /**
     * @inheritdoc
     */
    public function onPlayerAlliesChanged(Player $oldPlayer, Player $player)
    {
    }
}