Maps::onExpansionMapChange() - Code Metrics - Inspection of "Adds maps plugin, custom chat and more admin comma..." - eXpansionPluginPack/eXpansion2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#75)

unknown

created 2017-07-19 18:27 UTC

Maps::onExpansionMapChange() A

↳ Parent: Maps

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	3
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	1
nc	1
nop	2
crap	2

<?php

namespace eXpansion\Bundle\Maps\Plugins;

use eXpansion\Framework\AdminGroups\Helpers\AdminGroups;
use eXpansion\Framework\Core\DataProviders\Listener\MapDataListenerInterface;
use eXpansion\Framework\Core\Plugins\StatusAwarePluginInterface;
use eXpansion\Framework\Core\Services\Console;
use eXpansion\Framework\Core\Storage\MapStorage;
use Maniaplanet\DedicatedServer\Connection;


class Maps implements MapDataListenerInterface, StatusAwarePluginInterface
{
    /** @var Connection */
    protected $connection;

    /** @var Console */
    protected $console;

    /** @var AdminGroups */
    protected $adminGroups;

    /** @var bool */
    protected $enabled = true;

    /** @var MapStorage */
    protected $mapStorage;

    function __construct(Connection $connection, Console $console, AdminGroups $adminGroups, MapStorage $mapStorage)

    {
        $this->connection = $connection;
        $this->console = $console;
        $this->adminGroups = $adminGroups;
        $this->mapStorage = $mapStorage;
    }

    /**
     * Set the status of the plugin
     *
     * @param boolean $status
     *
     * @return void
     */
    public function setStatus($status)
    {
        if (!$status) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}

        }
    }

    /**
     * @return array
     */
    public function getMaps()
    {
        return $this->mapStorage->getMaps();
    }

    /**
     * @param \Maniaplanet\DedicatedServer\Structures\Map[] $oldMaps
     * @param string $currentMapUid
     * @param string $nextMapUid
     * @param bool $isListModified
     * @return mixed|void
     */
    public function onMapListModified($oldMaps, $currentMapUid, $nextMapUid, $isListModified)
    {

    }

    public function onExpansionMapChange($currentMap, $previousMap)
    {
        // TODO: Implement onExpansionMapChange() method.
    }

    public function onExpansionNextMapChange($nextMap, $previousNextMap)
    {
        // TODO: Implement onExpansionNextMapChange() method.
    }
}


1			<?php
2
3			namespace eXpansion\Bundle\Maps\Plugins;
4
5			use eXpansion\Framework\AdminGroups\Helpers\AdminGroups;
6			use eXpansion\Framework\Core\DataProviders\Listener\MapDataListenerInterface;
7			use eXpansion\Framework\Core\Plugins\StatusAwarePluginInterface;
8			use eXpansion\Framework\Core\Services\Console;
9			use eXpansion\Framework\Core\Storage\MapStorage;
10			use Maniaplanet\DedicatedServer\Connection;
11
12
13			class Maps implements MapDataListenerInterface, StatusAwarePluginInterface
14			{
15			/** @var Connection */
16			protected $connection;
17
18			/** @var Console */
19			protected $console;
20
21			/** @var AdminGroups */
22			protected $adminGroups;
23
24			/** @var bool */
25			protected $enabled = true;
26
27			/** @var MapStorage */
28			protected $mapStorage;
29
30			function __construct(Connection $connection, Console $console, AdminGroups $adminGroups, MapStorage $mapStorage)
			0 ignored issues – show Best Practice introduced 2017-07-19 18:30 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
31			{
32			$this->connection = $connection;
33			$this->console = $console;
34			$this->adminGroups = $adminGroups;
35			$this->mapStorage = $mapStorage;
36			}
37
38			/**
39			* Set the status of the plugin
40			*
41			* @param boolean $status
42			*
43			* @return void
44			*/
45			public function setStatus($status)
46			{
47			if (!$status) {
			0 ignored issues – show Unused Code introduced 2017-07-19 18:30 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
48
49			}
50			}
51
52			/**
53			* @return array
54			*/
55			public function getMaps()
56			{
57			return $this->mapStorage->getMaps();
58			}
59
60			/**
61			* @param \Maniaplanet\DedicatedServer\Structures\Map[] $oldMaps
62			* @param string $currentMapUid
63			* @param string $nextMapUid
64			* @param bool $isListModified
65			* @return mixed\|void
66			*/
67			public function onMapListModified($oldMaps, $currentMapUid, $nextMapUid, $isListModified)
68			{
69
70			}
71
72			public function onExpansionMapChange($currentMap, $previousMap)
73			{
74			// TODO: Implement onExpansionMapChange() method.
75			}
76
77			public function onExpansionNextMapChange($nextMap, $previousNextMap)
78			{
79			// TODO: Implement onExpansionNextMapChange() method.
80			}
81			}
82

eXpansionPluginPack / eXpansion2

Pull Request — master (#75)

Maps::onExpansionMapChange() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like