eXpansion\Bundle\AdminChat\ChatCommand\AdminShuffleCommand

Complexity

Total Complexity

6

Size/Duplication

Total Lines	96
Duplicated Lines	25 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	24	24	1
B	execute()	0	35	5

<?php

namespace eXpansion\Bundle\AdminChat\ChatCommand;

use eXpansion\Framework\AdminGroups\Helpers\AdminGroups;
use eXpansion\Framework\AdminGroups\Model\AbstractAdminChatCommand;
use eXpansion\Framework\Core\Helpers\ChatNotification;
use eXpansion\Framework\Core\Helpers\Time;
use eXpansion\Framework\Core\Storage\MapStorage;
use eXpansion\Framework\Core\Storage\PlayerStorage;
use Maniaplanet\DedicatedServer\Connection;
use Psr\Log\LoggerInterface;
use Symfony\Component\Console\Input\InputInterface;

/**
 * Class ReasonUserCommand
 *
 * @author  Reaby
 * @package eXpansion\Bundle\AdminChat\ChatCommand
 */
class AdminShuffleCommand extends AbstractAdminChatCommand
{
    /** @var ChatNotification */
    private $chatNotification;

    /** @var PlayerStorage */
    private $playerStorage;

    /**
     * @var MapStorage
     */
    private $mapStorage;
    /**
     * @var Connection
     */
    private $connection;

    /**
     * AdminCommand constructor.
     *
     * @param                  $command
     * @param string           $permission
     * @param array            $aliases
     * @param ChatNotification $functionName

There is no parameter named $functionName. Was it maybe removed?

     * @param AdminGroups      $adminGroupsHelper
     * @param Connection       $connection
     * @param ChatNotification $chatNotification
     * @param PlayerStorage    $playerStorage
     * @param LoggerInterface  $logger
     * @param Time             $timeHelper

There is no parameter named $timeHelper. Was it maybe removed?

     * @param MapStorage       $mapStorage
     */
    public function __construct(

This method seems to be duplicated in your project.

        $command,
        $permission,
        array $aliases = [],
        AdminGroups $adminGroupsHelper,
        ChatNotification $chatNotification,
        PlayerStorage $playerStorage,
        LoggerInterface $logger,
        Connection $connection,
        MapStorage $mapStorage
    ) {
        parent::__construct(
            $command,
            $permission,
            $aliases = [],
            $adminGroupsHelper
        );

        $this->chatNotification = $chatNotification;
        $this->playerStorage = $playerStorage;
        $this->mapStorage = $mapStorage;
        $this->adminGroupsHelper = $adminGroupsHelper;
        $this->connection = $connection;
    }

    /**
     * @inheritdoc
     */
    public function execute($login, InputInterface $input)
    {
        $player = $this->playerStorage->getPlayerInfo($login)->getNickName();

$player is not used, you could remove the assignment.

        $allMaps = [];
        foreach ($this->mapStorage->getMaps() as $map) {
            $maps[] = $map->fileName;

$maps was never initialized. Although not strictly required by PHP, it is generally a good practice to add $maps = array(); before regardless.

            $allMaps[] = $map->fileName;
            if (count($maps) > 250) {
                $this->connection->removeMapList($maps);

The variable $maps does not seem to be defined for all execution paths leading up to this point.

                $maps = [];
            }
        }
        // for remaining maps, which didn't fit to 200
        $this->connection->removeMapList($maps);
        $this->connection->executeMulticall();

        shuffle($allMaps);

        $maps = [];
        foreach ($allMaps as $x => $mapFile) {
            $maps[] = $mapFile;
            if (count($maps) > 250) {
                $this->connection->insertMapList($maps, true);
            }
        }
        // for remaining maps, which didn't fit to 200
        $this->connection->insertMapList($maps, true);
        $this->connection->executeMulticall();

        $level = $this->adminGroupsHelper->getLoginGroupLabel($login);
        $admin = $this->playerStorage->getPlayerInfo($login)->getNickName();
        $this->chatNotification->sendMessage('expansion_admin_chat.shuffle.msg', null,
            ["%adminLevel%" => $level, "%admin%" => $admin]);

    }
}