eXpansion\Bundle\AdminChat\ChatCommand\ReasonUserCommand

Complexity

Total Complexity

5

Size/Duplication

Total Lines	139
Duplicated Lines	23.02 %

Coupling/Cohesion

Components	2
Dependencies	10

Test Coverage

Coverage

89.74%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	0	11	1
A	execute()	0	32	3
A	__construct()	32	32	1

<?php

namespace eXpansion\Bundle\AdminChat\ChatCommand;

use eXpansion\Framework\AdminGroups\Helpers\AdminGroups;
use eXpansion\Framework\Core\Helpers\ChatNotification;
use eXpansion\Framework\Core\Helpers\Time;
use eXpansion\Framework\Core\Helpers\TMString;
use eXpansion\Framework\Core\Services\DedicatedConnection\Factory;
use eXpansion\Framework\Core\Storage\PlayerStorage;
use Maniaplanet\DedicatedServer\Connection;
use Maniaplanet\DedicatedServer\Xmlrpc\Exception as DedicatedException;
use Psr\Log\LoggerInterface;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;

/**
 * Class ReasonUserCommand
 *
 * @author    de Cramer Oliver<oliverde8@gmail.com>
 * @copyright 2017 eXpansion
 * @package   eXpansion\Bundle\AdminChat\ChatCommand
 */
class ReasonUserCommand extends AbstractConnectionCommand
{
    /**
     * Description of the login parameter
     *
     * @var string
     */
    protected $parameterLoginDescription;

    /**
     * Description of the reason parameter.
     *
     * @var string
     */
    protected $parameterReasonDescription;

    /**
     * Description of the command.
     *
     * @var string
     */
    protected $description;

    /**
     * Message to display in chat.
     *
     * @var string
     */
    protected $chatMessage;

    /**
     * Name of the dedicated function to call.
     *
     * @var string
     */
    protected $functionName;

    /**
     * ReasonUserCommand constructor.
     *
     * @param $command
     * @param $permission
     * @param array $aliases
     * @param $functionName
     * @param $parameterLoginDescription
     * @param $parameterReasonDescription
     * @param AdminGroups $adminGroupsHelper
     * @param Factory $factory
     * @param ChatNotification $chatNotification
     * @param PlayerStorage $playerStorage
     * @param LoggerInterface $logger
     * @param Time $timeHelper
     */
    public function __construct(

This method seems to be duplicated in your project.

        $command,
        $permission,
        array $aliases = [],
        $functionName,
        $parameterLoginDescription,
        $parameterReasonDescription,
        AdminGroups $adminGroupsHelper,
        Factory $factory,
        ChatNotification $chatNotification,
        PlayerStorage $playerStorage,
        LoggerInterface $logger,
        Time $timeHelper
    ) {
        parent::__construct(
            $command,
            $permission,
            $aliases,
            $adminGroupsHelper,
            $factory,
            $chatNotification,
            $playerStorage,
            $logger,
            $timeHelper
        );

        $this->description = 'expansion_admin_chat.'.strtolower($functionName).'.description';
        $this->chatMessage = 'expansion_admin_chat.'.strtolower($functionName).'.msg';
        $this->functionName = $functionName;
        $this->parameterLoginDescription = $parameterLoginDescription;
        $this->parameterReasonDescription = $parameterReasonDescription;
    }


    /**
     * @inheritdoc
     */
    protected function configure()
    {
        parent::configure();

        $this->inputDefinition->addArgument(
            new InputArgument('login', InputArgument::REQUIRED, $this->parameterLoginDescription)
        );
        $this->inputDefinition->addArgument(
            new InputArgument('reason', InputArgument::REQUIRED, $this->parameterReasonDescription)
        );
    }


    /**
     * @inheritdoc
     */
    public function execute($login, InputInterface $input)
    {
        $nickName = $this->playerStorage->getPlayerInfo($login)->getNickName();
        $playerLogin = $input->getArgument('login');
        $reason = $input->getArgument('reason');
        $group = $this->getGroupLabel($login);

        $playerNickName = $this->playerStorage->getPlayerInfo($playerLogin)->getNickName();

It seems like $playerLogin defined by $input->getArgument('login') on line 133 can also be of type array<integer,string> or null; however, eXpansion\Framework\Core\Storage\PlayerStorage::getPlayerInfo() does only seem to accept string, maybe add an additional type check?

        try {
            $this->factory->getConnection()->{$this->functionName}($playerLogin, $reason);
            $this->chatNotification->sendMessage(
                $this->chatMessage,
                $this->isPublic ? null : $login,
                ['%adminLevel%' => $group, '%admin%' => $nickName, '%player%' => $playerNickName, "%reason%" => $reason]
            );

            $logMessage = $this->chatNotification->getMessage($this->chatMessage,
                [
                    '%adminLevel%' => $group,
                    '%admin%' => $nickName,
                    '%player%' => $playerNickName,
                    "%reason%" => $reason
                ], "en");
            $this->logger->info("[".$login."] ".TMString::trimStyles($logMessage));


        } catch (DedicatedException $e) {
            $this->logger->error("Error on admin command", ["exception" => $e]);
            $this->chatNotification->sendMessage("expansion_admin_chat.dedicatedexception", $login,
                ["%message%" => $e->getMessage()]);
        }
    }
}