eXpansion\Framework\Core\Helpers\Http

Complexity

Total Complexity

6

Size/Duplication

Total Lines	96
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

20.59%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	call()	0	7	1
A	get()	0	9	1
A	post()	0	20	2
A	process()	0	10	1

<?php

namespace eXpansion\Framework\Core\Helpers;

use eXpansion\Framework\Core\Helpers\JobRunner\Factory;
use eXpansion\Framework\Core\Helpers\Structures\HttpRequest;
use eXpansion\Framework\Core\Helpers\Structures\HttpResult;
use eXpansion\Framework\Core\Services\Application\AbstractApplication;
use oliverde8\AsynchronousJobs\Job\CallbackCurl;
use oliverde8\AsynchronousJobs\JobRunner;

/**
 * Class Http
 *
 * @author    de Cramer Oliver<oldec@smile.fr>
 * @copyright 2017 Smile
 * @package eXpansion\Framework\Core\Helpers
 */
class Http
{

    /** @var Factory */
    protected $factory;

    /**
     * Http constructor.
     *
     * @param Factory $factory
     */
    public function __construct(Factory $factory)
    {
        $this->factory = $factory;
    }

    /**
     * Make a http query.
     *
     * @param string $url
     * @param callable $callback
     * @param null|mixed $additionalData If you need to pass additional metadata.
     *                                   You will get this back in the callback.
     * @param array $options curl options array
     */
    public function call($url, $callback, $additionalData = null, $options = [])
    {
        $curlJob = $this->factory->createCurlJob($url, $callback, $additionalData, $options);

        // Start job execution.
        $this->factory->startJob($curlJob);
    }

    /**
     * Make a get http query.
     *
     * @param string $url address
     * @param callable $callback callback
     * @param null|mixed $additionalData If you need to pass additional metadata.
     *                                          You will get this back in the callback.
     * @param array $options Single dimensional array of curl_setopt key->values
     */
    public function get($url, callable $callback, $additionalData = null, $options = [])
    {
        $options[CURLOPT_FOLLOWLOCATION] = true;
        $options[CURLOPT_USERAGENT] = "eXpansionPluginPack v " . AbstractApplication::EXPANSION_VERSION;

        $additionalData['callback'] = $callback;

        $this->call($url, [$this, 'process'], $additionalData, $options);
    }

    /**
     * Make a post http query.
     *
     * @param string $url address
     * @param array $postFields array<string, string>
     * @param callable $callback callback with returning datas
     * @param null|mixed $additionalData If you need to pass additional metadata.
     *                                   You will get this back in the callback.
     * @param array $options Single dimensional array of curl_setopt key->values
     */
    public function post($url, $postFields, callable $callback, $additionalData = null, $options = [])
    {
        $options[CURLOPT_POST] = true;
        $options[CURLOPT_FOLLOWLOCATION] = true;
        $options[CURLOPT_USERAGENT] = "eXpansionPluginPack v " . AbstractApplication::EXPANSION_VERSION;

        $query = '';
        if (!empty($postFields)) {
            $query = '?'.http_build_query($postFields);
        }
        $options[CURLOPT_URL] = $url;
        $options[CURLOPT_POSTFIELDS] = $query;

        $additionalData['callback'] = $callback;

        $curlJob = $this->factory->createCurlJob($url, [$this, 'process'], $additionalData, $options, $postFields);

        // Start job execution.
        $this->factory->startJob($curlJob);
    }

    public function process(HttpRequest $curl)
    {
        $data = $curl->getData();
        $additionalData = $curl->getAdditionalData();

Are you sure the assignment to $additionalData is correct as $curl->getAdditionalData() (which targets eXpansion\Framework\Core\Helpers\Structures\HttpRequest::getAdditionalData()) seems to always return null.

        $callback = $additionalData['callback'];
        unset($additionalData['callback']);

        $obj = new HttpResult($data['response'], $data['curlInfo'], $curl->getCurlError(), $additionalData);
        call_user_func($callback, $obj);
    }


}