eXpansion\Framework\GameCurrencyBundle\ChatCommand\Donate

Complexity

Total Complexity

3

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	14	1
A	configure()	0	9	1
A	execute()	0	13	1

<?php

namespace eXpansion\Framework\GameCurrencyBundle\ChatCommand;

use eXpansion\Framework\Core\Helpers\ChatNotification;
use eXpansion\Framework\Core\Model\ChatCommand\AbstractChatCommand;
use eXpansion\Framework\Core\Storage\GameDataStorage;
use eXpansion\Framework\Core\Storage\PlayerStorage;
use eXpansion\Framework\GameCurrencyBundle\Plugins\Gui\BillWindow;
use eXpansion\Framework\GameCurrencyBundle\Services\GameCurrencyService;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;

/**
 *
 * @author  reaby
 */
class Donate extends AbstractChatCommand
{
    /** @var BillWindow */
    private $billWindow;

The property $billWindow is not used and could be removed.

    /**
     * @var GameCurrencyService
     */
    private $currencyService;
    /**
     * @var GameDataStorage
     */
    private $gameDataStorage;
    /**
     * @var ChatNotification
     */
    private $chatNotification;
    /**
     * @var PlayerStorage
     */
    private $playerStorage;

    /**
     * ScriptPanel constructor.
     *
     * @param                      $command
     * @param array                $aliases
     * @param GameCurrencyService  $currencyService
     * @param GameDataStorage      $gameDataStorage
     * @param ChatNotification     $chatNotification
     * @param PlayerStorage        $playerStorage
     */
    public function __construct(
        $command,
        array $aliases = [],
        GameCurrencyService $currencyService,
        GameDataStorage $gameDataStorage,
        ChatNotification $chatNotification,
        PlayerStorage $playerStorage
    ) {
        parent::__construct($command, $aliases);
        $this->currencyService = $currencyService;
        $this->gameDataStorage = $gameDataStorage;
        $this->chatNotification = $chatNotification;
        $this->playerStorage = $playerStorage;
    }

    protected function configure()
    {
        parent::configure();

        $this->inputDefinition->addArgument(
            new InputArgument('amount', InputArgument::REQUIRED, "amount to donate")
        );

    }


    /**
     * @inheritdoc
     */
    public function execute($login, InputInterface $input)
    {
        $amount = $input->getArgument("amount");
        $bill = $this->currencyService->createBill($login, $amount,
            $this->gameDataStorage->getSystemInfo()->serverLogin, "");
        $this->currencyService->sendBill($bill, function () use ($bill, $login) {

It seems like $bill defined by $this->currencyService->createBill($login, $amount, $this->gameDataStorage->getSystemInfo()->serverLogin, '') on line 81 can also be of type false; however, eXpansion\Framework\GameCurrencyBundle\Services\GameCurrencyService::sendBill() does only seem to accept object<eXpansion\Framework\GameCurrencyBundle\Model\Gamecurrency>, did you maybe forget to handle an error condition?

            $player = $this->playerStorage->getPlayerInfo($login);
            $amount = $bill->getAmount();
            $this->chatNotification->sendMessage('|info|{info}Server received {variable}'.$amount.'p {info}donation from {variable}'.$player->getNickName());
        }, function ($error) use ($login) {
            $this->chatNotification->sendMessage("|error|{info}Error while processing your donation: {error}".$error, $login);
        });
    }
}