WindowFactory::createContent() - Code Metrics - Inspection of "Scrollables" - eXpansionPluginPack/eXpansion2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#100)

unknown

created 2017-07-28 17:57 UTC

WindowFactory::createContent() B

↳ Parent: WindowFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	77
Code Lines	52

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	77
rs	8.9342
cc	2
eloc	52
nc	2
nop	1

How to fix Long Method

<?php

namespace eXpansion\Bundle\Acme\Plugins\Gui;

use eXpansion\Framework\Core\Model\Gui\ManialinkInterface;
use eXpansion\Framework\Core\Plugins\Gui\WindowFactory as BaseWindowFactory;
use eXpansion\Framework\Gui\Components\uiButton;
use eXpansion\Framework\Gui\Components\uiCheckbox;
use eXpansion\Framework\Gui\Components\uiDropdown;
use eXpansion\Framework\Gui\Components\uiInput;
use eXpansion\Framework\Gui\Components\uiLabel;
use eXpansion\Framework\Gui\Components\uiTextbox;
use eXpansion\Framework\Gui\Components\uiTooltip;
use eXpansion\Framework\Gui\Layouts\layoutLine;
use eXpansion\Framework\Gui\Layouts\layoutRow;
use eXpansion\Framework\Gui\Layouts\layoutScrollable;
use FML\Controls\Quad;

class WindowFactory extends BaseWindowFactory
{

    protected function createContent(ManialinkInterface $manialink)
    {
        parent::createContent($manialink);

        $tooltip = new uiTooltip();
        $manialink->addChild($tooltip);

        $label = new uiLabel("Test", uiLabel::TYPE_NORMAL);
        $tooltip->addTooltip($label, "tooltip test");

        $manialink->addChild($label);

        $checkbox = new uiCheckbox("test checkbox 1", "checkbox1");
        $tooltip->addTooltip($checkbox, "testing 123");

        $checkbox2 = new uiCheckbox("test checkbox 2", "checkbox2");
        $tooltip->addTooltip($checkbox2, "testing");
        $line1 = new layoutRow(0, 0, [$checkbox, $checkbox2], 0);

        $ok = new uiButton("Apply", uiButton::TYPE_DECORATED);
        $tooltip->addTooltip($ok, "ridicolously long description text is here!");
        $ok->setAction($this->actionFactory->createManialinkAction($manialink, [$this, 'ok'], ["ok" => "ok"]));

        $cancel = new uiButton("Cancel");
        $cancel->setAction($this->actionFactory->createManialinkAction($manialink, [$this, 'ok'], ["ok" => "cancel"]));

        $line2 = new layoutLine(0, 0, [$ok, $cancel], 1);

        $line3 = new layoutRow(55, 0, [], 1);

        for ($x = 0; $x < 10; $x++) {
            $btn = new uiCheckbox('box'.$x, 'cb_'.$x);
            $btn->setPosition(0, 0);
            $tooltip->addTooltip($btn, "long description that should go over the bounding box".$x);
            $line3->addChild($btn);
        }
        $btn = new uiCheckbox('box11', 'cb_11');
        $btn->setPosition(20, 0);
        $line3->addChild($btn);

        $btn = new uiCheckbox('box11', 'cb_11');
        $btn->setPosition(50, 0);
        $line3->addChild($btn);

        $scrollable = new layoutScrollable($line3, 55, 30);
        $scrollable->setAxis(true, true);
        $manialink->addChild($scrollable);


        $row = new layoutRow(0, -10, [$line1, $line2], 0);

        $scrollable = new layoutScrollable($row, 40, 30);
        $scrollable->setAxis(true, true);
        $manialink->addChild($scrollable);


        $dropdown = new uiDropdown("dropdown", ["option1" => 1, "option2" => 2]);
        $dropdown->setPosition(97, 0);
        $tooltip->addTooltip($dropdown, "test");
        $manialink->addChild($dropdown);

        $dropdown = new uiDropdown("style", ["tech" => "tech", "fullspeed" => "fullspeed", "speedtech" => "speedtech"]);
        $dropdown->setPosition(130, 0);
        $manialink->addChild($dropdown);


        $input = new uiInput("input1", "test text", 30, "Password");
        $input->setPosition(130, -20);
        $tooltip->addTooltip($input, "test");
        $manialink->addChild($input);

        $input = new uiTextbox("input2", "test\ntest2\ntest3\nest4\ntest5", 5, 30);
        $input->setPosition(130, -30);
        $tooltip->addTooltip($input, "test2");
        $manialink->addChild($input);

    }


    public function ok($login, $params, $args)

    {
        // do nothing at the moment
    }

}


1			<?php
2
3			namespace eXpansion\Bundle\Acme\Plugins\Gui;
4
5			use eXpansion\Framework\Core\Model\Gui\ManialinkInterface;
6			use eXpansion\Framework\Core\Plugins\Gui\WindowFactory as BaseWindowFactory;
7			use eXpansion\Framework\Gui\Components\uiButton;
8			use eXpansion\Framework\Gui\Components\uiCheckbox;
9			use eXpansion\Framework\Gui\Components\uiDropdown;
10			use eXpansion\Framework\Gui\Components\uiInput;
11			use eXpansion\Framework\Gui\Components\uiLabel;
12			use eXpansion\Framework\Gui\Components\uiTextbox;
13			use eXpansion\Framework\Gui\Components\uiTooltip;
14			use eXpansion\Framework\Gui\Layouts\layoutLine;
15			use eXpansion\Framework\Gui\Layouts\layoutRow;
16			use eXpansion\Framework\Gui\Layouts\layoutScrollable;
17			use FML\Controls\Quad;
18
19			class WindowFactory extends BaseWindowFactory
20			{
21
22			protected function createContent(ManialinkInterface $manialink)
23			{
24			parent::createContent($manialink);
25
26			$tooltip = new uiTooltip();
27			$manialink->addChild($tooltip);
28
29			$label = new uiLabel("Test", uiLabel::TYPE_NORMAL);
30			$tooltip->addTooltip($label, "tooltip test");
31
32			$manialink->addChild($label);
33
34			$checkbox = new uiCheckbox("test checkbox 1", "checkbox1");
35			$tooltip->addTooltip($checkbox, "testing 123");
36
37			$checkbox2 = new uiCheckbox("test checkbox 2", "checkbox2");
38			$tooltip->addTooltip($checkbox2, "testing");
39			$line1 = new layoutRow(0, 0, [$checkbox, $checkbox2], 0);
40
41			$ok = new uiButton("Apply", uiButton::TYPE_DECORATED);
42			$tooltip->addTooltip($ok, "ridicolously long description text is here!");
43			$ok->setAction($this->actionFactory->createManialinkAction($manialink, [$this, 'ok'], ["ok" => "ok"]));
44
45			$cancel = new uiButton("Cancel");
46			$cancel->setAction($this->actionFactory->createManialinkAction($manialink, [$this, 'ok'], ["ok" => "cancel"]));
47
48			$line2 = new layoutLine(0, 0, [$ok, $cancel], 1);
49
50			$line3 = new layoutRow(55, 0, [], 1);
51
52			for ($x = 0; $x < 10; $x++) {
53			$btn = new uiCheckbox('box'.$x, 'cb_'.$x);
54			$btn->setPosition(0, 0);
55			$tooltip->addTooltip($btn, "long description that should go over the bounding box".$x);
56			$line3->addChild($btn);
57			}
58			$btn = new uiCheckbox('box11', 'cb_11');
59			$btn->setPosition(20, 0);
60			$line3->addChild($btn);
61
62			$btn = new uiCheckbox('box11', 'cb_11');
63			$btn->setPosition(50, 0);
64			$line3->addChild($btn);
65
66			$scrollable = new layoutScrollable($line3, 55, 30);
67			$scrollable->setAxis(true, true);
68			$manialink->addChild($scrollable);
69
70
71			$row = new layoutRow(0, -10, [$line1, $line2], 0);
72
73			$scrollable = new layoutScrollable($row, 40, 30);
74			$scrollable->setAxis(true, true);
75			$manialink->addChild($scrollable);
76
77
78			$dropdown = new uiDropdown("dropdown", ["option1" => 1, "option2" => 2]);
79			$dropdown->setPosition(97, 0);
80			$tooltip->addTooltip($dropdown, "test");
81			$manialink->addChild($dropdown);
82
83			$dropdown = new uiDropdown("style", ["tech" => "tech", "fullspeed" => "fullspeed", "speedtech" => "speedtech"]);
84			$dropdown->setPosition(130, 0);
85			$manialink->addChild($dropdown);
86
87
88			$input = new uiInput("input1", "test text", 30, "Password");
89			$input->setPosition(130, -20);
90			$tooltip->addTooltip($input, "test");
91			$manialink->addChild($input);
92
93			$input = new uiTextbox("input2", "test\ntest2\ntest3\nest4\ntest5", 5, 30);
94			$input->setPosition(130, -30);
95			$tooltip->addTooltip($input, "test2");
96			$manialink->addChild($input);
97
98			}
99
100
101			public function ok($login, $params, $args)
			0 ignored issues – show Unused Code introduced 2017-07-26 12:41 UTC by Report Bug Copy Issue Report The parameter `$login` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-07-26 12:41 UTC by Report Bug Copy Issue Report The parameter `$params` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-07-26 12:41 UTC by Report Bug Copy Issue Report The parameter `$args` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
102			{
103			// do nothing at the moment
104			}
105
106			}
107

eXpansionPluginPack / eXpansion2

Pull Request — master (#100)

WindowFactory::createContent() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like