RaceRecords::onPlayerEndLap() - Code Metrics - Inspection of "Localrecords" - eXpansionPluginPack/eXpansion2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#68)

by De Cramer

created 2017-06-05 15:36 UTC

RaceRecords::onPlayerEndLap() A

↳ Parent: RaceRecords

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	2
cts	2
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	9
crap	1

How to fix Many Parameters

<?php

namespace eXpansion\Bundle\LocalRecords\Plugins;

use eXpansion\Framework\GameTrackmania\DataProviders\Listener\BaseDataListenerInterface as TmBaseDataListenerInterface;

/**
 * Class RaceRecords
 *
 * @package eXpansion\Bundle\LocalRecords\Plugins;
 * @author  oliver de Cramer <[email protected]>
 */
class RaceRecords extends BaseRecords implements TmBaseDataListenerInterface
{
    /**
     * @param string $login       Login of the player that crossed the CP point
     * @param int    $time        Server time when the event occured,
     * @param int    $raceTime    Total race time in milliseconds
     * @param int    $stuntsScore Stunts score
     * @param int    $cpInRace    Number of checkpoints crossed since the beginning of the race
     * @param int[]  $curCps      Checkpoints times since the beginning of the race
     * @param string $blockId     Id of the checkpoint block
     * @param string $speed       Speed of the player in km/h
     * @param string $distance    Distance traveled by the player
     */
    public function onPlayerEndRace(
        $login,
        $time,
        $raceTime,
        $stuntsScore,
        $cpInRace,
        $curCps,
        $blockId,
        $speed,
        $distance
    )
    {
        $eventData = $this->recordsHandler->addRecord($login, $raceTime, $cpInRace);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        if ($eventData) {
            $this->dispatchEvent($eventData);
        }
    }

    /**
     * @param string $login       Login of the player that crossed the CP point
     * @param int    $time        Server time when the event occured,
     * @param int    $lapTime     Lap time in milliseconds
     * @param int    $stuntsScore Stunts score
     * @param int    $cpInLap     Number of checkpoints crossed since the beginning of the lap
     * @param int[]  $curLapCps   Checkpoints time since the beginning of the lap
     * @param string $blockId     Id of the checkpoint block
     * @param string $speed       Speed of the player in km/h
     * @param string $distance    Distance traveled by the player
     */
    public function onPlayerEndLap(
        $login,
        $time,
        $lapTime,
        $stuntsScore,
        $cpInLap,
        $curLapCps,
        $blockId,
        $speed,
        $distance
    )
    {
        // Nothing to do.
    }

    /**
     * @param string $login       Login of the player that crossed the CP point
     * @param int    $time        Server time when the event occured,
     * @param int    $raceTime    Total race time in milliseconds
     * @param int    $lapTime     Lap time in milliseconds
     * @param int    $stuntsScore Stunts score
     * @param int    $cpInRace    Number of checkpoints crossed since the beginning of the race
     * @param int    $cpInLap     Number of checkpoints crossed since the beginning of the lap
     * @param int[]  $curCps      Checkpoints times since the beginning of the race
     * @param int[]  $curLapCps   Checkpoints time since the beginning of the lap
     * @param string $blockId     Id of the checkpoint block
     * @param string $speed       Speed of the player in km/h
     * @param string $distance    Distance traveled by the player
     */
    public function onPlayerWayPoint(
        $login,
        $time,
        $raceTime,
        $lapTime,
        $stuntsScore,
        $cpInRace,
        $cpInLap,
        $curCps,
        $curLapCps,
        $blockId,
        $speed,
        $distance
    )
    {
        // Nothing to do.
    }
}

1		<?php
2
3		namespace eXpansion\Bundle\LocalRecords\Plugins;
4
5		use eXpansion\Framework\GameTrackmania\DataProviders\Listener\BaseDataListenerInterface as TmBaseDataListenerInterface;
6
7		/**
8		* Class RaceRecords
9		*
10		* @package eXpansion\Bundle\LocalRecords\Plugins;
11		* @author oliver de Cramer <[email protected]>
12		*/
13		class RaceRecords extends BaseRecords implements TmBaseDataListenerInterface
14		{
15		/**
16		* @param string $login Login of the player that crossed the CP point
17		* @param int $time Server time when the event occured,
18		* @param int $raceTime Total race time in milliseconds
19		* @param int $stuntsScore Stunts score
20		* @param int $cpInRace Number of checkpoints crossed since the beginning of the race
21		* @param int[] $curCps Checkpoints times since the beginning of the race
22		* @param string $blockId Id of the checkpoint block
23		* @param string $speed Speed of the player in km/h
24		* @param string $distance Distance traveled by the player
25		*/
26	2	public function onPlayerEndRace(
27		$login,
28		$time,
29		$raceTime,
30		$stuntsScore,
31		$cpInRace,
32		$curCps,
33		$blockId,
34		$speed,
35		$distance
36		)
37		{
38	2	$eventData = $this->recordsHandler->addRecord($login, $raceTime, $cpInRace);
		0 ignored issues – show Documentation introduced 2017-06-05 15:40 UTC by Report Bug Copy Issue Report `$cpInRace` is of type `integer`, but the function expects a `array<integer,integer>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
39
40	2	if ($eventData) {
41	1	$this->dispatchEvent($eventData);
42		}
43	2	}
44
45		/**
46		* @param string $login Login of the player that crossed the CP point
47		* @param int $time Server time when the event occured,
48		* @param int $lapTime Lap time in milliseconds
49		* @param int $stuntsScore Stunts score
50		* @param int $cpInLap Number of checkpoints crossed since the beginning of the lap
51		* @param int[] $curLapCps Checkpoints time since the beginning of the lap
52		* @param string $blockId Id of the checkpoint block
53		* @param string $speed Speed of the player in km/h
54		* @param string $distance Distance traveled by the player
55		*/
56	1	public function onPlayerEndLap(
57		$login,
58		$time,
59		$lapTime,
60		$stuntsScore,
61		$cpInLap,
62		$curLapCps,
63		$blockId,
64		$speed,
65		$distance
66		)
67		{
68		// Nothing to do.
69	1	}
70
71		/**
72		* @param string $login Login of the player that crossed the CP point
73		* @param int $time Server time when the event occured,
74		* @param int $raceTime Total race time in milliseconds
75		* @param int $lapTime Lap time in milliseconds
76		* @param int $stuntsScore Stunts score
77		* @param int $cpInRace Number of checkpoints crossed since the beginning of the race
78		* @param int $cpInLap Number of checkpoints crossed since the beginning of the lap
79		* @param int[] $curCps Checkpoints times since the beginning of the race
80		* @param int[] $curLapCps Checkpoints time since the beginning of the lap
81		* @param string $blockId Id of the checkpoint block
82		* @param string $speed Speed of the player in km/h
83		* @param string $distance Distance traveled by the player
84		*/
85	1	public function onPlayerWayPoint(
86		$login,
87		$time,
88		$raceTime,
89		$lapTime,
90		$stuntsScore,
91		$cpInRace,
92		$cpInLap,
93		$curCps,
94		$curLapCps,
95		$blockId,
96		$speed,
97		$distance
98		)
99		{
100		// Nothing to do.
101		}
102		}

eXpansionPluginPack / eXpansion2

Pull Request — master (#68)

RaceRecords::onPlayerEndLap() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like