NbPlayers::__construct() - Code Metrics - Inspection of "Feature/389 info window" - eXpansionPluginPack/eXpansion2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#404)

by De Cramer

created 2020-03-13 11:37 UTC

NbPlayers::__construct() A

↳ Parent: NbPlayers

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	0
cts	11
cp	0
rs	9.8666
c	0
b	0
f	0
cc	1
nc	1
nop	5
crap	2

<?php

namespace eXpansion\Bundle\ServerInformation\Services\ServerInformation;

use eXpansion\Bundle\ServerInformation\Ui\Factory\ServerInformationLineFactory;
use eXpansion\Framework\AdminGroups\Helpers\AdminGroups;
use eXpansion\Framework\Core\Storage\GameDataStorage;
use eXpansion\Framework\Core\Storage\PlayerStorage;
use FML\Controls\Control;

class NbPlayers extends AbstractServerInformation
{
    /** @var GameDataStorage */
    protected $dataStorage;

    /** @var PlayerStorage */
    protected $players;

    public function __construct(
        ServerInformationLineFactory $serverInformationLineFactory,
        AdminGroups $adminGroupHelper,
        GameDataStorage $dataStorage,
        PlayerStorage $players,
        $requiredPermission = null
    ) {
        parent::__construct($serverInformationLineFactory, $adminGroupHelper, $requiredPermission);

        $this->dataStorage = $dataStorage;
        $this->players = $players;
    }

    /**
     * @inheritdoc
     */
    public function getInformation(string $login): Control

    {
        $nbPlayer = count($this->players->getPlayers());
        $players = "$nbPlayer / {$this->dataStorage->getServerOptions()->currentMaxPlayers}";

        return $this->serverInformationLineFactory->create("expansion_server_information.nb_players", $players);
    }
}


1		<?php
2
3		namespace eXpansion\Bundle\ServerInformation\Services\ServerInformation;
4
5		use eXpansion\Bundle\ServerInformation\Ui\Factory\ServerInformationLineFactory;
6		use eXpansion\Framework\AdminGroups\Helpers\AdminGroups;
7		use eXpansion\Framework\Core\Storage\GameDataStorage;
8		use eXpansion\Framework\Core\Storage\PlayerStorage;
9		use FML\Controls\Control;
10
11		class NbPlayers extends AbstractServerInformation
12		{
13		/** @var GameDataStorage */
14		protected $dataStorage;
15
16		/** @var PlayerStorage */
17		protected $players;
18
19		public function __construct(
20		ServerInformationLineFactory $serverInformationLineFactory,
21		AdminGroups $adminGroupHelper,
22		GameDataStorage $dataStorage,
23		PlayerStorage $players,
24		$requiredPermission = null
25		) {
26		parent::__construct($serverInformationLineFactory, $adminGroupHelper, $requiredPermission);
27
28		$this->dataStorage = $dataStorage;
29		$this->players = $players;
30		}
31
32		/**
33		* @inheritdoc
34		*/
35	View Code Duplication	public function getInformation(string $login): Control
		0 ignored issues – show Duplication introduced 2020-03-13 11:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		$nbPlayer = count($this->players->getPlayers());
38		$players = "$nbPlayer / {$this->dataStorage->getServerOptions()->currentMaxPlayers}";
39
40		return $this->serverInformationLineFactory->create("expansion_server_information.nb_players", $players);
41		}
42		}
43

eXpansionPluginPack / eXpansion2

Pull Request — master (#404)

NbPlayers::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like