MemoryWidgetFactory::updateContent() - Code Metrics - Inspection of "Votemanager" - eXpansionPluginPack/eXpansion2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#152)

unknown

created 2017-12-03 14:57 UTC

MemoryWidgetFactory::updateContent() B

↳ Parent: MemoryWidgetFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	24
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	24
rs	8.9713
c	0
b	0
f	0
cc	1
eloc	13
nc	1
nop	1

<?php

namespace eXpansion\Bundle\Acme\Plugins\Gui;

use eXpansion\Bundle\Acme\Plugins\Test;
use eXpansion\Framework\Core\Model\Gui\ManialinkInterface;
use eXpansion\Framework\Core\Model\Gui\Widget;
use eXpansion\Framework\Core\Plugins\Gui\WidgetFactory;

use FML\Controls\Label;
use FML\Script\Script;
use FML\Script\ScriptLabel;

class MemoryWidgetFactory extends WidgetFactory
{
    /** @var  Label */
    protected $memoryMessage;

    public static $exp_hash;

    /**
     * @param ManialinkInterface|Widget $manialink
     */
    protected function createContent(ManialinkInterface $manialink)
    {

        $this->memoryMessage = new Label();
        $this->memoryMessage->setTextPrefix('$s')->setText("waiting data...");
        $manialink->addChild($this->memoryMessage);

        self::$exp_hash = uniqid("exp");
    }

    protected function updateContent(ManialinkInterface $manialink)
    {

        $this->memoryMessage->setText(Test::$memoryMsg);
        $now = uniqid("exp2");
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $message = "Time now:".date("h:i:s");




        $hash = self::$exp_hash;

        $script = new Script();
        $script->addCustomScriptLabel(ScriptLabel::OnInit,
            '
           declare Text '.$hash.' for LocalUser = Text;
           '.$hash.' = "'.$message.'";
           declare Text '.$hash.'_check for LocalUser = "";
           '.$hash.'_check = "$now";
           '
        );
        $manialink->getFmlManialink()->setScript($script);
    }

}


1			<?php
2
3			namespace eXpansion\Bundle\Acme\Plugins\Gui;
4
5			use eXpansion\Bundle\Acme\Plugins\Test;
6			use eXpansion\Framework\Core\Model\Gui\ManialinkInterface;
7			use eXpansion\Framework\Core\Model\Gui\Widget;
8			use eXpansion\Framework\Core\Plugins\Gui\WidgetFactory;
9
10			use FML\Controls\Label;
11			use FML\Script\Script;
12			use FML\Script\ScriptLabel;
13
14			class MemoryWidgetFactory extends WidgetFactory
15			{
16			/** @var Label */
17			protected $memoryMessage;
18
19			public static $exp_hash;
20
21			/**
22			* @param ManialinkInterface\|Widget $manialink
23			*/
24			protected function createContent(ManialinkInterface $manialink)
25			{
26
27			$this->memoryMessage = new Label();
28			$this->memoryMessage->setTextPrefix('$s')->setText("waiting data...");
29			$manialink->addChild($this->memoryMessage);
30
31			self::$exp_hash = uniqid("exp");
32			}
33
34			protected function updateContent(ManialinkInterface $manialink)
35			{
36
37			$this->memoryMessage->setText(Test::$memoryMsg);
38			$now = uniqid("exp2");
			0 ignored issues – show Unused Code introduced 2017-11-11 21:50 UTC by Report Bug Copy Issue Report `$now` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
39
40			$message = "Time now:".date("h:i:s");
41
42
43
44
45			$hash = self::$exp_hash;
46
47			$script = new Script();
48			$script->addCustomScriptLabel(ScriptLabel::OnInit,
49			'
50			declare Text '.$hash.' for LocalUser = Text;
51			'.$hash.' = "'.$message.'";
52			declare Text '.$hash.'_check for LocalUser = "";
53			'.$hash.'_check = "$now";
54			'
55			);
56			$manialink->getFmlManialink()->setScript($script);
57			}
58
59			}
60

eXpansionPluginPack / eXpansion2

Pull Request — master (#152)

MemoryWidgetFactory::updateContent() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like