eXpansion\Framework\MlComposeBundle\UiComponents\FmlComponent

Complexity

Total Complexity

8

Size/Duplication

Total Lines	71
Duplicated Lines	11.27 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
C	display()	8	46	7

<?php

namespace eXpansion\Framework\MlComposeBundle\UiComponents;

use eXpansion\Framework\Core\Model\Gui\ManialinkInterface;
use eXpansion\Framework\Core\Plugins\Gui\ActionFactory;
use FML\Controls\Control;
use FML\Controls\Frame;
use oliverde8\AssociativeArraySimplified\AssociativeArray;
use Oliverde8\PageCompose\Block\BlockDefinitionInterface;
use Oliverde8\PageCompose\Service\UiComponents;
use Oliverde8\PageCompose\UiComponent\AbstractUiComponent;
use Symfony\Component\ExpressionLanguage\ExpressionLanguage;
use Symfony\Component\PropertyAccess\PropertyAccess;

/**
 * Class BaseFmlComponent
 *
 * @author    de Cramer Oliver<oiverde8@gmail.com>
 * @copyright 2018 Oliverde8
 * @package eXpansion\Framework\MlComposeBundle\UiComponents
 */
class  FmlComponent extends AbstractUiComponent

Expected 1 space between class keyword and class name; 2 found

{
    /**
     * @var ActionFactory
     */
    protected $actionFactory;
    protected $fmlClass;

    public function __construct(UiComponents $uiComponents, ActionFactory $actionFactory, $fmlClass)
    {
        parent::__construct($uiComponents);
        $this->propertAccess = PropertyAccess::createPropertyAccessor();

The property propertAccess does not exist. Did you maybe forget to declare it?

        $this->actionFactory = $actionFactory;
        $this->fmlClass = $fmlClass;
    }

    /**
     * Display the component.
     *
     * @param BlockDefinitionInterface $blockDefinition
     * @param array ...$args
     *
     * @return string
     */
    public function display(BlockDefinitionInterface $blockDefinition, ...$args)
    {
        $expressionLanguage = new ExpressionLanguage();
        $configuration = new AssociativeArray($blockDefinition->getConfiguration());
        $class = $this->fmlClass;

        $arguments = [
            'factory' => $args[0],
            'manialink' => $args[1],
            'args' => $args,
        ];

        /** @var Control  $component */
        $component = new $class($configuration->get('id', $blockDefinition->getUniqueKey()));

        foreach ($blockDefinition->getSubBlocks() as $block) {
            /** @var Frame  $component */
            $component->addChild($this->uiComponents->display($block, ...$args));

$this->uiComponents->display($block, ...$args) is of type null|string, but the function expects a object<FML\Types\Renderable>.

        }

        foreach ($configuration->get('expr', []) as $key => $value) {
            $function = ucwords("set$key");
            $component->$function($expressionLanguage->evaluate($value, $arguments));
        }

        foreach ($configuration->get('args', []) as $key => $value) {

This code seems to be duplicated across your project.

            $function = ucwords("set$key");
            $component->$function(...$value);
        }

        foreach ($configuration->get('def', []) as $key => $value) {

This code seems to be duplicated across your project.

            $function = ucwords("set$key");
            $component->$function($value);
        }

        if ($args[1] instanceof ManialinkInterface) {

The class eXpansion\Framework\Core\Model\Gui\ManialinkInterface does not exist. Did you forget a USE statement, or did you not list all dependencies?

            if ($configuration->get('action')) {
                $callback = [$configuration->get('action/0/service', $args[0]), $configuration->get('action/0/method')];
                $this->actionFactory->createManialinkAction($args[1], $callback, [], false);
            }
        } else {

This else statement is empty and can be removed.

            // Log warning!
        }

        return $component;
    }
}