eXpansionPluginPack /
eXpansion2
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 13 | View Code Duplication | class LapsRecords extends BaseRecords implements TmBaseDataListenerInterface |
|
|
|
|||
| 14 | { |
||
| 15 | /** |
||
| 16 | * @param string $login Login of the player that crossed the CP point |
||
| 17 | * @param int $time Server time when the event occured, |
||
| 18 | * @param int $raceTime Total race time in milliseconds |
||
| 19 | * @param int $stuntsScore Stunts score |
||
| 20 | * @param int $cpInRace Number of checkpoints crossed since the beginning of the race |
||
| 21 | * @param int[] $curCps Checkpoints times since the beginning of the race |
||
| 22 | * @param string $blockId Id of the checkpoint block |
||
| 23 | * @param string $speed Speed of the player in km/h |
||
| 24 | * @param string $distance Distance traveled by the player |
||
| 25 | */ |
||
| 26 | 1 | public function onPlayerEndRace( |
|
| 39 | |||
| 40 | /** |
||
| 41 | * @param string $login Login of the player that crossed the CP point |
||
| 42 | * @param int $time Server time when the event occured, |
||
| 43 | * @param int $lapTime Lap time in milliseconds |
||
| 44 | * @param int $stuntsScore Stunts score |
||
| 45 | * @param int $cpInLap Number of checkpoints crossed since the beginning of the lap |
||
| 46 | * @param int[] $curLapCps Checkpoints time since the beginning of the lap |
||
| 47 | * @param string $blockId Id of the checkpoint block |
||
| 48 | * @param string $speed Speed of the player in km/h |
||
| 49 | * @param string $distance Distance traveled by the player |
||
| 50 | */ |
||
| 51 | 1 | public function onPlayerEndLap( |
|
| 52 | $login, |
||
| 53 | $time, |
||
| 54 | $lapTime, |
||
| 55 | $stuntsScore, |
||
| 56 | $cpInLap, |
||
| 57 | $curLapCps, |
||
| 58 | $blockId, |
||
| 59 | $speed, |
||
| 60 | $distance |
||
| 61 | ) { |
||
| 62 | 1 | $eventData = $this->recordsHandler->addRecord($login, $lapTime, $curLapCps); |
|
| 63 | |||
| 64 | 1 | if ($eventData) { |
|
| 65 | 1 | $this->dispatchEvent($eventData); |
|
| 66 | } |
||
| 67 | 1 | } |
|
| 68 | |||
| 69 | /** |
||
| 70 | * @param string $login Login of the player that crossed the CP point |
||
| 71 | * @param int $time Server time when the event occured, |
||
| 72 | * @param int $raceTime Total race time in milliseconds |
||
| 73 | * @param int $lapTime Lap time in milliseconds |
||
| 74 | * @param int $stuntsScore Stunts score |
||
| 75 | * @param int $cpInRace Number of checkpoints crossed since the beginning of the race |
||
| 76 | * @param int $cpInLap Number of checkpoints crossed since the beginning of the lap |
||
| 77 | * @param int[] $curCps Checkpoints times since the beginning of the race |
||
| 78 | * @param int[] $curLapCps Checkpoints time since the beginning of the lap |
||
| 79 | * @param string $blockId Id of the checkpoint block |
||
| 80 | * @param string $speed Speed of the player in km/h |
||
| 81 | * @param string $distance Distance traveled by the player |
||
| 82 | */ |
||
| 83 | 1 | public function onPlayerWayPoint( |
|
| 99 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.