VoteWidgetFactory::__construct() - Code Metrics - Inspection of "Dedimania & alot of other changes" - eXpansionPluginPack/eXpansion2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#307)

unknown

created 2018-03-03 19:24 UTC

VoteWidgetFactory::__construct() A

↳ Parent: VoteWidgetFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	14
nc	1
nop	9
dl	0
loc	18
ccs	0
cts	6
cp	0
crap	2
rs	9.4285
c	0
b	0
f	0

How to fix Many Parameters

<?php

namespace eXpansion\Bundle\VoteManager\Plugins\Gui\Widget;

use eXpansion\Bundle\VoteManager\Services\VoteService;
use eXpansion\Framework\Core\Model\Gui\ManialinkInterface;
use eXpansion\Framework\Core\Model\Gui\Widget;
use eXpansion\Framework\Core\Model\Gui\WidgetFactoryContext;
use eXpansion\Framework\Core\Plugins\Gui\WidgetFactory;
use eXpansion\Framework\Gui\Builders\WidgetBackground;
use eXpansion\Framework\Gui\Components\Animation;
use eXpansion\Framework\Gui\Components\Button;
use eXpansion\Framework\Gui\Components\Label;
use eXpansion\Framework\Gui\Ui\Factory;
use FML\Controls\Frame;
use FML\Controls\Quad;
use FML\Script\ScriptLabel;

class VoteWidgetFactory extends WidgetFactory
{

    const x = 90;
    const y = 20;
    /** @var Label */
    protected $label;
    /**
     * @var VoteService
     */
    private $voteService;

    /**
     * @var UpdateVoteWidgetFactory
     */
    private $updateVoteWidgetFactory;


    /***
     * MenuFactory constructor.
     *
     * @param                         $name
     * @param                         $sizeX
     * @param                         $sizeY
     * @param null                    $posX
     * @param null                    $posY
     * @param WidgetFactoryContext    $context
     * @param Factory                 $uiFactory
     * @param VoteService             $voteService
     * @param UpdateVoteWidgetFactory $updateVoteWidgetFactory
     */
    public function __construct(
        $name,
        $sizeX,
        $sizeY,
        $posX,
        $posY,
        WidgetFactoryContext $context,
        Factory $uiFactory,
        VoteService $voteService,
        UpdateVoteWidgetFactory $updateVoteWidgetFactory

    ) {
        parent::__construct($name, $sizeX, $sizeY, $posX, $posY, $context);

        $this->uiFactory = $uiFactory;
        $this->voteService = $voteService;
        $this->updateVoteWidgetFactory = $updateVoteWidgetFactory;
    }

    /**
     * @param Widget|ManialinkInterface $manialink
     */
    protected function createContent(ManialinkInterface $manialink)
    {
        $frame = Frame::create();
        $frame->setScale(0.8);
        $manialink->addChild($frame);

        $label = $this->uiFactory->createLabel($this->voteService->getCurrentVote()->getQuestion(), Label::TYPE_HEADER);
        $label->setTextColor("fff")
            ->setPosition(self::x / 2, -1)
            ->setTextSize(4)
            ->setAlign("center", "top")
            ->setTranslate(true);
        $this->label = $label;
        $frame->addChild($this->label);

        $btnPosition = -9;
        $btn = $this->uiFactory->createButton(" F1", Button::TYPE_DEFAULT);
        $btn->setSize(18, 6)->setPosition(1, $btnPosition)
            ->setId("ButtonYes")
            ->setBackgroundColor("0f09");
        $btn->setAction(
            $this->actionFactory->createManialinkAction($manialink, [$this, "callbackYes"], null)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
        $frame->addChild($btn);

        $btn = $this->uiFactory->createButton(" F2", Button::TYPE_DEFAULT);
        $btn->setSize(18, 6)->setPosition(self::x - 19, $btnPosition)
            ->setId("ButtonNo")
           ->setBackgroundColor("f009");
        $btn->setAction(
            $this->actionFactory->createManialinkAction($manialink, [$this, "callbackNo"], null)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
        $frame->addChild($btn);

        $quad = Quad::create();
        $quad->setAlign("center", "center2");
        $quad->setSize(0.5, 9);
        $quad->setPosition(self::x / 2, $btnPosition - 3)
            ->setBackgroundColor("fff");
        $frame->addChild($quad);

        $quad = Quad::create("yes");
        $quad->setAlign("left", "top");
        $quad->setSize((self::x - 20 * 2) / 2, 6);
        $quad->setPosition(20, $btnPosition)
            ->setBackgroundColor("0f09");
        $frame->addChild($quad);

        $quad = Quad::create("no");
        $quad->setAlign("right", "top");
        $quad->setSize((self::x - 20 * 2) / 2, 6);
        $quad->setPosition(self::x - 20, $btnPosition)
            ->setBackgroundColor("0000");
        $frame->addChild($quad);

        $animation = $this->uiFactory->createAnimation();
        $manialink->addChild($animation);

        $quad = Quad::create("timer");
        $quad->setSize(self::x - 4, 1);
        $quad->setPosition(2, -self::y + 1)
            ->setAlign("left", "bottom")
            ->setBackgroundColor("fffa");
        $frame->addChild($quad);

        $animation->addAnimation($quad,
            "size='0 1'",
            $this->voteService->getCurrentVote()->getDuration() * 1000,
            0,
            Animation::Linear);


        $bg = new WidgetBackground(90, 20);
        $frame->addChild($bg);

        $x = self::x;
        $manialink->getFmlManialink()->getScript()->addCustomScriptLabel(ScriptLabel::KeyPress,
            <<<EOL
            
            if (Event.KeyName == "F1") {
                TriggerButtonClick("ButtonYes");                            
            }
            
            if (Event.KeyName == "F2") {
               TriggerButtonClick("ButtonNo");                                 
            }
EOL
        );

        $manialink->getFmlManialink()->getScript()->addCustomScriptLabel(ScriptLabel::OnInit,

            <<<EOL
            declare Real SizeX = 1. * ($x - 40) ;
            declare CMlQuad BgYes = (Page.GetFirstChild("yes") as CMlQuad);
            declare CMlQuad BgNo = (Page.GetFirstChild("no") as CMlQuad);
            {$this->updateVoteWidgetFactory->getScriptInitialization()}                                                                       
EOL
        );

        $variable = $this->updateVoteWidgetFactory->getVariable('VoteUpdater')->getVariableName();
        $onChange = $this->updateVoteWidgetFactory->getScriptOnChange(/** @lang text */
            <<<EOL
            
               declare Integer Yes = {$variable}["yes"];
               declare Integer No = {$variable}["no"];
               declare Real Total = 1. * (Yes + No);
               
               if (Total > 0) {
                    declare Real Ratio = 1. * (Yes / Total);
                    AnimMgr.Add(BgYes, "<elem size=\""^( SizeX * Ratio )^" 6\" />", 250, CAnimManager::EAnimManagerEasing::QuadInOut);               
                    AnimMgr.Add(BgNo, "<elem size=\""^( SizeX  * (1. - Ratio) )^" 6\" />", 250, CAnimManager::EAnimManagerEasing::QuadInOut);                                         
               }
               
EOL
        );

        $manialink->getFmlManialink()->getScript()->addCustomScriptLabel(ScriptLabel::Loop, $onChange);
    }

    public function callbackYes($manialink, $login, $entries, $args)
    {
        if ($this->voteService->getCurrentVote()) {
            $this->voteService->getCurrentVote()->castYes($login);
        }

    }

    public function callbackNo($manialink, $login, $entries, $args)
    {
        if ($this->voteService->getCurrentVote()) {
            $this->voteService->getCurrentVote()->castNo($login);
        }
    }

}


1			<?php
2
3			namespace eXpansion\Bundle\VoteManager\Plugins\Gui\Widget;
4
5			use eXpansion\Bundle\VoteManager\Services\VoteService;
6			use eXpansion\Framework\Core\Model\Gui\ManialinkInterface;
7			use eXpansion\Framework\Core\Model\Gui\Widget;
8			use eXpansion\Framework\Core\Model\Gui\WidgetFactoryContext;
9			use eXpansion\Framework\Core\Plugins\Gui\WidgetFactory;
10			use eXpansion\Framework\Gui\Builders\WidgetBackground;
11			use eXpansion\Framework\Gui\Components\Animation;
12			use eXpansion\Framework\Gui\Components\Button;
13			use eXpansion\Framework\Gui\Components\Label;
14			use eXpansion\Framework\Gui\Ui\Factory;
15			use FML\Controls\Frame;
16			use FML\Controls\Quad;
17			use FML\Script\ScriptLabel;
18
19			class VoteWidgetFactory extends WidgetFactory
20			{
21
22			const x = 90;
23			const y = 20;
24			/** @var Label */
25			protected $label;
26			/**
27			* @var VoteService
28			*/
29			private $voteService;
30
31			/**
32			* @var UpdateVoteWidgetFactory
33			*/
34			private $updateVoteWidgetFactory;
35
36
37			/***
38			* MenuFactory constructor.
39			*
40			* @param $name
41			* @param $sizeX
42			* @param $sizeY
43			* @param null $posX
44			* @param null $posY
45			* @param WidgetFactoryContext $context
46			* @param Factory $uiFactory
47			* @param VoteService $voteService
48			* @param UpdateVoteWidgetFactory $updateVoteWidgetFactory
49			*/
50			public function __construct(
51			$name,
52			$sizeX,
53			$sizeY,
54			$posX,
55			$posY,
56			WidgetFactoryContext $context,
57			Factory $uiFactory,
58			VoteService $voteService,
59			UpdateVoteWidgetFactory $updateVoteWidgetFactory
60
61			) {
62			parent::__construct($name, $sizeX, $sizeY, $posX, $posY, $context);
63
64			$this->uiFactory = $uiFactory;
65			$this->voteService = $voteService;
66			$this->updateVoteWidgetFactory = $updateVoteWidgetFactory;
67			}
68
69			/**
70			* @param Widget\|ManialinkInterface $manialink
71			*/
72			protected function createContent(ManialinkInterface $manialink)
73			{
74			$frame = Frame::create();
75			$frame->setScale(0.8);
76			$manialink->addChild($frame);
77
78			$label = $this->uiFactory->createLabel($this->voteService->getCurrentVote()->getQuestion(), Label::TYPE_HEADER);
79			$label->setTextColor("fff")
80			->setPosition(self::x / 2, -1)
81			->setTextSize(4)
82			->setAlign("center", "top")
83			->setTranslate(true);
84			$this->label = $label;
85			$frame->addChild($this->label);
86
87			$btnPosition = -9;
88			$btn = $this->uiFactory->createButton(" F1", Button::TYPE_DEFAULT);
89			$btn->setSize(18, 6)->setPosition(1, $btnPosition)
90			->setId("ButtonYes")
91			->setBackgroundColor("0f09");
92			$btn->setAction(
93			$this->actionFactory->createManialinkAction($manialink, [$this, "callbackYes"], null)
			0 ignored issues – show Documentation introduced 2017-12-03 15:00 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
94			);
95			$frame->addChild($btn);
96
97			$btn = $this->uiFactory->createButton(" F2", Button::TYPE_DEFAULT);
98			$btn->setSize(18, 6)->setPosition(self::x - 19, $btnPosition)
99			->setId("ButtonNo")
100			->setBackgroundColor("f009");
101			$btn->setAction(
102			$this->actionFactory->createManialinkAction($manialink, [$this, "callbackNo"], null)
			0 ignored issues – show Documentation introduced 2017-12-03 15:00 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
103			);
104			$frame->addChild($btn);
105
106			$quad = Quad::create();
107			$quad->setAlign("center", "center2");
108			$quad->setSize(0.5, 9);
109			$quad->setPosition(self::x / 2, $btnPosition - 3)
110			->setBackgroundColor("fff");
111			$frame->addChild($quad);
112
113			$quad = Quad::create("yes");
114			$quad->setAlign("left", "top");
115			$quad->setSize((self::x - 20 * 2) / 2, 6);
116			$quad->setPosition(20, $btnPosition)
117			->setBackgroundColor("0f09");
118			$frame->addChild($quad);
119
120			$quad = Quad::create("no");
121			$quad->setAlign("right", "top");
122			$quad->setSize((self::x - 20 * 2) / 2, 6);
123			$quad->setPosition(self::x - 20, $btnPosition)
124			->setBackgroundColor("0000");
125			$frame->addChild($quad);
126
127			$animation = $this->uiFactory->createAnimation();
128			$manialink->addChild($animation);
129
130			$quad = Quad::create("timer");
131			$quad->setSize(self::x - 4, 1);
132			$quad->setPosition(2, -self::y + 1)
133			->setAlign("left", "bottom")
134			->setBackgroundColor("fffa");
135			$frame->addChild($quad);
136
137			$animation->addAnimation($quad,
138			"size='0 1'",
139			$this->voteService->getCurrentVote()->getDuration() * 1000,
140			0,
141			Animation::Linear);
142
143
144			$bg = new WidgetBackground(90, 20);
145			$frame->addChild($bg);
146
147			$x = self::x;
148			$manialink->getFmlManialink()->getScript()->addCustomScriptLabel(ScriptLabel::KeyPress,
149			<<<EOL
150
151			if (Event.KeyName == "F1") {
152			TriggerButtonClick("ButtonYes");
153			}
154
155			if (Event.KeyName == "F2") {
156			TriggerButtonClick("ButtonNo");
157			}
158			EOL
159			);
160
161			$manialink->getFmlManialink()->getScript()->addCustomScriptLabel(ScriptLabel::OnInit,
162
163			<<<EOL
164			declare Real SizeX = 1. * ($x - 40) ;
165			declare CMlQuad BgYes = (Page.GetFirstChild("yes") as CMlQuad);
166			declare CMlQuad BgNo = (Page.GetFirstChild("no") as CMlQuad);
167			{$this->updateVoteWidgetFactory->getScriptInitialization()}
168			EOL
169			);
170
171			$variable = $this->updateVoteWidgetFactory->getVariable('VoteUpdater')->getVariableName();
172			$onChange = $this->updateVoteWidgetFactory->getScriptOnChange(/** @lang text */
173			<<<EOL
174
175			declare Integer Yes = {$variable}["yes"];
176			declare Integer No = {$variable}["no"];
177			declare Real Total = 1. * (Yes + No);
178
179			if (Total > 0) {
180			declare Real Ratio = 1. * (Yes / Total);
181			AnimMgr.Add(BgYes, "<elem size=\""^( SizeX * Ratio )^" 6\" />", 250, CAnimManager::EAnimManagerEasing::QuadInOut);
182			AnimMgr.Add(BgNo, "<elem size=\""^( SizeX * (1. - Ratio) )^" 6\" />", 250, CAnimManager::EAnimManagerEasing::QuadInOut);
183			}
184
185			EOL
186			);
187
188			$manialink->getFmlManialink()->getScript()->addCustomScriptLabel(ScriptLabel::Loop, $onChange);
189			}
190
191			public function callbackYes($manialink, $login, $entries, $args)
192			{
193			if ($this->voteService->getCurrentVote()) {
194			$this->voteService->getCurrentVote()->castYes($login);
195			}
196
197			}
198
199			public function callbackNo($manialink, $login, $entries, $args)
200			{
201			if ($this->voteService->getCurrentVote()) {
202			$this->voteService->getCurrentVote()->castNo($login);
203			}
204			}
205
206			}
207

eXpansionPluginPack / eXpansion2

Pull Request — master (#307)

VoteWidgetFactory::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like