eXpansionMlComposeExtension::processBlock() - Code Metrics - Inspection of "WIP: feature #275 - Prototype idea for Gui Builder" - eXpansionPluginPack/eXpansion2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#341)

by De Cramer

created 2018-04-19 15:04 UTC

eXpansionMlComposeExtension::processBlock() C

↳ Parent: eXpansionMlComposeExtension

Complexity

Conditions	11
Paths	112

Size

Total Lines	55
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	55
rs	6.2857
c	0
b	0
f	0
cc	11
eloc	33
nc	112
nop	3

How to fix Long Method Complexity

<?php

namespace eXpansion\Framework\MlComposeBundle\DependencyInjection;

use Oliverde8\PageCompose\Service\BlockDefinitions;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
use Symfony\Component\DependencyInjection\Reference;
use Symfony\Component\Finder\Finder;
use Symfony\Component\HttpKernel\DependencyInjection\Extension;


/**
 * Class eXpansionMlComposeExtension
 *
 * @author    de Cramer Oliver<[email protected]>
 * @copyright 2018 Oliverde8
 * @package eXpansion\Framework\MlComposeBundle\DependencyInjection
 */
class eXpansionMlComposeExtension extends Extension
{

    /**
     * @inheritdoc
     */
    public function load(array $configs, ContainerBuilder $container)
    {

        $loader = new YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
        $loader->load('services.yml');

        $bundles = $container->getParameter('kernel.bundles');
        $finder = new Finder();

        $pageLayout = [];

        foreach ($bundles as $bundle) {
            $reflection = new \ReflectionClass($bundle);
            $dir = dirname($reflection->getFilename()) . '/Resources/config/ml-compose/';

            if (is_dir($dir)) {
                $files = $finder->files()
                    ->name("*.xml")
                    ->in($dir);

                foreach ($files as $file) {
                    $pageLayout += $this->parseFile($file, $container);
                }
            }
        }

        $container->getDefinition(BlockDefinitions::class)->setArgument('$buildFactories', $pageLayout);
    }

    protected function parseFile($filePath, ContainerBuilder $container)
    {
        $xsdPath = realpath(__DIR__ . "/../Resources/config/page-compose.xsd");
        $dom = new \DOMDocument();
        $dom->loadXML(str_replace("exp:ml_compose_bundle:page-compose.xsd", $xsdPath, file_get_contents($filePath)));

        if (!$dom->schemaValidate($xsdPath)) {
            var_dump($errors = libxml_get_errors());

            echo "File contains errors";
            die(2);

            // TODO do this better.
        }

        $xml = simplexml_load_file($filePath);
        return $this->processBlock($xml, $container);
    }

    protected function processBlock(\SimpleXMLElement $element, ContainerBuilder $container, $parent = null) {
        $blockDefinition = [];

        if ($parent) {
            $blockDefinition['parent'] = $parent;
        }

        if (isset($element->attributes()['component'])) {
            $blockDefinition['component'] = (string) $element->attributes()['component'];
        } else {
            $blockDefinition['extends'] = (string) $element['@attributes']['extends'];
        }

        if (isset($element->attributes()['alias'])) {
            $blockDefinition['alias'] = (string) $element->attributes()['alias'];
        }

        foreach ($element->argument as $argument) {
            $name = (string) $argument->attributes()['name'];

            switch ($this->getXsiType($argument)) {
                case "expr":
                    $blockDefinition['config']['expr'][$name] = (string) $argument;
                    break;

                case "action":
                    $blockDefinition['config']['action'][$name]['method'] = (string)$argument->method[0];
                    if (isset($argument->service[0])) {
                        // Use symfony to actually get a reference.
                        $blockDefinition['config']['action'][$name]['service'] = new Reference((string)$argument->service[0]);
                    }
                    break;

                case "args":
                    $blockDefinition['config']['args'][$name] = [];
                    foreach ($argument->arg as $arg) {
                        $blockDefinition['config']['args'][$name][] = (string) $arg;
                    }
                    break;

                default:
                    $blockDefinition['config']['def'][$name] = (string) $argument;
            }
        }

        $blockDefinitions = [
            (string) $element->attributes()['id'] => $blockDefinition,
        ];

        foreach ($element->block as $block) {
            $blockDefinitions += $this->processBlock($block, $container, (string) $element->attributes()['id']);
        }

        return $blockDefinitions;
    }

    protected function getXsiType(\SimpleXMLElement $element)
    {
        $namespaces = $element->getNamespaces();

        if (isset($namespaces['xsi']) && isset($element->attributes($namespaces['xsi'])['type'])) {
            return (string) $element->attributes($element->getNamespaces()['xsi'])['type'];
        }

        return null;
    }

}

1			<?php
2
3			namespace eXpansion\Framework\MlComposeBundle\DependencyInjection;
4
5			use Oliverde8\PageCompose\Service\BlockDefinitions;
6			use Symfony\Component\Config\FileLocator;
7			use Symfony\Component\DependencyInjection\ContainerBuilder;
8			use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
9			use Symfony\Component\DependencyInjection\Reference;
10			use Symfony\Component\Finder\Finder;
11			use Symfony\Component\HttpKernel\DependencyInjection\Extension;
12
13
14			/**
15			* Class eXpansionMlComposeExtension
16			*
17			* @author de Cramer Oliver<[email protected]>
18			* @copyright 2018 Oliverde8
19			* @package eXpansion\Framework\MlComposeBundle\DependencyInjection
20			*/
21			class eXpansionMlComposeExtension extends Extension
22			{
23
24			/**
25			* @inheritdoc
26			*/
27			public function load(array $configs, ContainerBuilder $container)
28			{
29
30			$loader = new YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
31			$loader->load('services.yml');
32
33			$bundles = $container->getParameter('kernel.bundles');
34			$finder = new Finder();
35
36			$pageLayout = [];
37
38			foreach ($bundles as $bundle) {
39			$reflection = new \ReflectionClass($bundle);
40			$dir = dirname($reflection->getFilename()) . '/Resources/config/ml-compose/';
41
42			if (is_dir($dir)) {
43			$files = $finder->files()
44			->name("*.xml")
45			->in($dir);
46
47			foreach ($files as $file) {
48			$pageLayout += $this->parseFile($file, $container);
49			}
50			}
51			}
52
53			$container->getDefinition(BlockDefinitions::class)->setArgument('$buildFactories', $pageLayout);
54			}
55
56			protected function parseFile($filePath, ContainerBuilder $container)
57			{
58			$xsdPath = realpath(__DIR__ . "/../Resources/config/page-compose.xsd");
59			$dom = new \DOMDocument();
60			$dom->loadXML(str_replace("exp:ml_compose_bundle:page-compose.xsd", $xsdPath, file_get_contents($filePath)));
61
62			if (!$dom->schemaValidate($xsdPath)) {
63			var_dump($errors = libxml_get_errors());
			0 ignored issues – show Security Debugging Code introduced 2018-04-19 15:10 UTC by Report Bug Copy Issue Report `var_dump($errors = libxml_get_errors());` looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data. Loading history...
64			echo "File contains errors";
65			die(2);
			0 ignored issues – show Coding Style Compatibility introduced 2018-04-19 15:10 UTC by Report Bug Copy Issue Report The method `parseFile()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
66			// TODO do this better.
67			}
68
69			$xml = simplexml_load_file($filePath);
70			return $this->processBlock($xml, $container);
71			}
72
73			protected function processBlock(\SimpleXMLElement $element, ContainerBuilder $container, $parent = null) {
74			$blockDefinition = [];
75
76			if ($parent) {
77			$blockDefinition['parent'] = $parent;
78			}
79
80			if (isset($element->attributes()['component'])) {
81			$blockDefinition['component'] = (string) $element->attributes()['component'];
82			} else {
83			$blockDefinition['extends'] = (string) $element['@attributes']['extends'];
84			}
85
86			if (isset($element->attributes()['alias'])) {
87			$blockDefinition['alias'] = (string) $element->attributes()['alias'];
88			}
89
90			foreach ($element->argument as $argument) {
91			$name = (string) $argument->attributes()['name'];
92
93			switch ($this->getXsiType($argument)) {
94			case "expr":
95			$blockDefinition['config']['expr'][$name] = (string) $argument;
96			break;
97
98			case "action":
99			$blockDefinition['config']['action'][$name]['method'] = (string)$argument->method[0];
100			if (isset($argument->service[0])) {
101			// Use symfony to actually get a reference.
102			$blockDefinition['config']['action'][$name]['service'] = new Reference((string)$argument->service[0]);
103			}
104			break;
105
106			case "args":
107			$blockDefinition['config']['args'][$name] = [];
108			foreach ($argument->arg as $arg) {
109			$blockDefinition['config']['args'][$name][] = (string) $arg;
110			}
111			break;
112
113			default:
114			$blockDefinition['config']['def'][$name] = (string) $argument;
115			}
116			}
117
118			$blockDefinitions = [
119			(string) $element->attributes()['id'] => $blockDefinition,
120			];
121
122			foreach ($element->block as $block) {
123			$blockDefinitions += $this->processBlock($block, $container, (string) $element->attributes()['id']);
124			}
125
126			return $blockDefinitions;
127			}
128
129			protected function getXsiType(\SimpleXMLElement $element)
130			{
131			$namespaces = $element->getNamespaces();
132
133			if (isset($namespaces['xsi']) && isset($element->attributes($namespaces['xsi'])['type'])) {
134			return (string) $element->attributes($element->getNamespaces()['xsi'])['type'];
135			}
136
137			return null;
138			}
139
140			}

eXpansionPluginPack / eXpansion2

Pull Request — master (#341)

eXpansionMlComposeExtension::processBlock() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like