Player - Code Metrics - Inspection of "Merge pull request #10 from eXpansionPluginPack/od..." - eXpansionPluginPack/eXpansion2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cac559...b1b643 )

by De Cramer

created 2017-03-18 16:34 UTC

Player B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	500
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	46
lcom	1
cbo	0
dl	0
loc	500
ccs	93
cts	93
cp	1
rs	8.3999
c	0
b	0
f	0

45 Methods

Rating	Name	Size	Complexity
A	merge()	8	2
A	isIsConnected()	4	1
A	getNickName()	4	1
A	getPlayerId()	4	1
A	getTeamId()	4	1
A	isIsSpectator()	4	1
A	isIsInOfficialMode()	4	1
A	getLadderRanking()	4	1
A	getSpectatorStatus()	4	1
A	getFlags()	4	1
A	getForceSpectator()	4	1
A	isIsReferee()	4	1
A	isIsPodiumReady()	4	1
A	isIsUsingStereoscopy()	4	1
A	isIsManagedByAnOtherServer()	4	1
A	isIsServer()	4	1
A	isHasPlayerSlot()	4	1
A	isIsBroadcasting()	4	1
A	isHasJoinedGame()	4	1
A	isSpectator()	4	1
A	isTemporarySpectator()	4	1
A	isPureSpectator()	4	1
A	isAutoTarget()	4	1
A	getCurrentTargetId()	4	1
A	getPath()	4	1
A	getLanguage()	4	1
A	getClientVersion()	4	1
A	getClientTitleVersion()	4	1
A	getIPAddress()	4	1
A	getDownloadRate()	4	1
A	getUploadRate()	4	1
A	getAvatar()	4	1
A	getSkins()	4	1
A	getLadderStats()	4	1
A	getHoursSinceZoneInscription()	4	1
A	getBroadcasterLogin()	4	1
A	getAllies()	4	1
A	getClubLink()	4	1
A	getRank()	4	1
A	getBestTime()	4	1
A	getBestCheckpoints()	4	1
A	getScore()	4	1
A	getNbrLapsFinished()	4	1
A	getLadderScore()	4	1
A	getLogin()	4	1

How to fix Complexity

<?php
/**
 * Created by PhpStorm.
 * User: olive
 * Date: 12/03/2017
 * Time: 16:26
 */

namespace eXpansion\Core\Storage\Data;

/**
 * All data related to a player/spectator on the server.
 *
 * @package eXpansion\Core\Storage\Data
 */
class Player
{
    /** @var string */
    protected $login;

    /** @var bool */
    protected $isConnected = true;

    /** @var string */
    protected $nickName;

    /** @var int */
    protected $playerId;

    /** @var int */
    protected $teamId;

    /** @var bool */
    protected $isSpectator;

    /** @var bool */
    protected $isInOfficialMode;

    /** @var int */
    protected $ladderRanking;

    /** @var int */
    protected $spectatorStatus;

    /** @var int */
    protected $flags;

    /** @var int */
    protected $forceSpectator;

    /** @var bool */
    protected $isReferee;

    /** @var bool */
    protected $isPodiumReady;

    /** @var bool */
    protected $isUsingStereoscopy;

    /** @var bool */
    protected $isManagedByAnOtherServer;

    /** @var bool */
    protected $isServer;

    /** @var bool */
    protected $hasPlayerSlot;

    /** @var bool */
    protected $isBroadcasting;

    /** @var bool */
    protected $hasJoinedGame = false;

    /** @var bool */
    protected $spectator;

    /** @var bool */
    protected $temporarySpectator;

    /** @var bool */
    protected $pureSpectator;

    /** @var bool */
    protected $autoTarget;

    /** @var int */
    protected $currentTargetId;


    /** @var string */
    protected $path;

    /** @var string */
    protected $language;

    /** @var string */
    protected $clientVersion;

    /** @var string */
    protected $clientTitleVersion;

    /** @var string */
    protected $iPAddress;

    /** @var int */
    protected $downloadRate;

    /** @var int */
    protected $uploadRate;

    /** @var FileDesc */
    protected $avatar;

    /** @var Skin[] */
    protected $skins;

    /** @var mixed[] */
    protected $ladderStats;

    /** @var int */
    protected $hoursSinceZoneInscription;

    /** @var string */
    protected $broadcasterLogin;

    /** @var string[] */
    protected $allies = array();

    /** @var string */
    protected $clubLink;
    /** @var int */
    protected $rank;

    /** @var int */
    protected $bestTime;

    /** @var int[] */
    protected $bestCheckpoints;

    /** @var int */
    protected $score;

    /** @var int */
    protected $nbrLapsFinished;

    /** @var float */
    protected $ladderScore;

    /**
     * @return boolean
     */
    public function isIsConnected()
    {
        return $this->isConnected;
    }

    /**
     * @return string
     */
    public function getNickName()
    {
        return $this->nickName;
    }

    /**
     * @return int
     */
    public function getPlayerId()
    {
        return $this->playerId;
    }

    /**
     * @return int
     */
    public function getTeamId()
    {
        return $this->teamId;
    }

    /**
     * @return boolean
     */
    public function isIsSpectator()
    {
        return $this->isSpectator;
    }

    /**
     * @return boolean
     */
    public function isIsInOfficialMode()
    {
        return $this->isInOfficialMode;
    }

    /**
     * @return int
     */
    public function getLadderRanking()
    {
        return $this->ladderRanking;
    }

    /**
     * @return int
     */
    public function getSpectatorStatus()
    {
        return $this->spectatorStatus;
    }

    /**
     * @return int
     */
    public function getFlags()
    {
        return $this->flags;
    }

    /**
     * @return int
     */
    public function getForceSpectator()
    {
        return $this->forceSpectator;
    }

    /**
     * @return boolean
     */
    public function isIsReferee()
    {
        return $this->isReferee;
    }

    /**
     * @return boolean
     */
    public function isIsPodiumReady()
    {
        return $this->isPodiumReady;
    }

    /**
     * @return boolean
     */
    public function isIsUsingStereoscopy()
    {
        return $this->isUsingStereoscopy;
    }

    /**
     * @return boolean
     */
    public function isIsManagedByAnOtherServer()
    {
        return $this->isManagedByAnOtherServer;
    }

    /**
     * @return boolean
     */
    public function isIsServer()
    {
        return $this->isServer;
    }

    /**
     * @return boolean
     */
    public function isHasPlayerSlot()
    {
        return $this->hasPlayerSlot;
    }

    /**
     * @return boolean
     */
    public function isIsBroadcasting()
    {
        return $this->isBroadcasting;
    }

    /**
     * @return boolean
     */
    public function isHasJoinedGame()
    {
        return $this->hasJoinedGame;
    }

    /**
     * @return boolean
     */
    public function isSpectator()
    {
        return $this->spectator;
    }

    /**
     * @return boolean
     */
    public function isTemporarySpectator()
    {
        return $this->temporarySpectator;
    }

    /**
     * @return boolean
     */
    public function isPureSpectator()
    {
        return $this->pureSpectator;
    }

    /**
     * @return boolean
     */
    public function isAutoTarget()
    {
        return $this->autoTarget;
    }

    /**
     * @return int
     */
    public function getCurrentTargetId()
    {
        return $this->currentTargetId;
    }

    /**
     * @return string
     */
    public function getPath()
    {
        return $this->path;
    }

    /**
     * @return string
     */
    public function getLanguage()
    {
        return $this->language;
    }

    /**
     * @return string
     */
    public function getClientVersion()
    {
        return $this->clientVersion;
    }

    /**
     * @return string
     */
    public function getClientTitleVersion()
    {
        return $this->clientTitleVersion;
    }

    /**
     * @return string
     */
    public function getIPAddress()
    {
        return $this->iPAddress;
    }

    /**
     * @return int
     */
    public function getDownloadRate()
    {
        return $this->downloadRate;
    }

    /**
     * @return int
     */
    public function getUploadRate()
    {
        return $this->uploadRate;
    }

    /**
     * @return FileDesc
     */
    public function getAvatar()
    {
        return $this->avatar;
    }

    /**
     * @return Skin[]
     */
    public function getSkins()
    {
        return $this->skins;
    }

    /**
     * @return \mixed[]
     */
    public function getLadderStats()
    {
        return $this->ladderStats;
    }

    /**
     * @return int
     */
    public function getHoursSinceZoneInscription()
    {
        return $this->hoursSinceZoneInscription;
    }

    /**
     * @return string
     */
    public function getBroadcasterLogin()
    {
        return $this->broadcasterLogin;
    }

    /**
     * @return string[]
     */
    public function getAllies()
    {
        return $this->allies;
    }

    /**
     * @return string
     */
    public function getClubLink()
    {
        return $this->clubLink;
    }

    /**
     * @return int
     */
    public function getRank()
    {
        return $this->rank;
    }

    /**
     * @return int
     */
    public function getBestTime()
    {
        return $this->bestTime;
    }

    /**
     * @return integer[]
     */
    public function getBestCheckpoints()
    {
        return $this->bestCheckpoints;
    }

    /**
     * @return int
     */
    public function getScore()
    {
        return $this->score;
    }

    /**
     * @return int
     */
    public function getNbrLapsFinished()
    {
        return $this->nbrLapsFinished;
    }

    /**
     * @return float
     */
    public function getLadderScore()
    {
        return $this->ladderScore;
    }

    /**
     * @return string
     */
    public function getLogin()
    {
        return $this->login;
    }

    /**
     * @param \Maniaplanet\DedicatedServer\Structures\Player|array $data
     *
     * @return $this
     */
    function merge($data)

    {
        foreach ($data as $key => $value) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $this->$key = $value;
        }

        return $this;
    }
}


1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: olive
5		* Date: 12/03/2017
6		* Time: 16:26
7		*/
8
9		namespace eXpansion\Core\Storage\Data;
10
11		/**
12		* All data related to a player/spectator on the server.
13		*
14		* @package eXpansion\Core\Storage\Data
15		*/
16		class Player
17		{
18		/** @var string */
19		protected $login;
20
21		/** @var bool */
22		protected $isConnected = true;
23
24		/** @var string */
25		protected $nickName;
26
27		/** @var int */
28		protected $playerId;
29
30		/** @var int */
31		protected $teamId;
32
33		/** @var bool */
34		protected $isSpectator;
35
36		/** @var bool */
37		protected $isInOfficialMode;
38
39		/** @var int */
40		protected $ladderRanking;
41
42		/** @var int */
43		protected $spectatorStatus;
44
45		/** @var int */
46		protected $flags;
47
48		/** @var int */
49		protected $forceSpectator;
50
51		/** @var bool */
52		protected $isReferee;
53
54		/** @var bool */
55		protected $isPodiumReady;
56
57		/** @var bool */
58		protected $isUsingStereoscopy;
59
60		/** @var bool */
61		protected $isManagedByAnOtherServer;
62
63		/** @var bool */
64		protected $isServer;
65
66		/** @var bool */
67		protected $hasPlayerSlot;
68
69		/** @var bool */
70		protected $isBroadcasting;
71
72		/** @var bool */
73		protected $hasJoinedGame = false;
74
75		/** @var bool */
76		protected $spectator;
77
78		/** @var bool */
79		protected $temporarySpectator;
80
81		/** @var bool */
82		protected $pureSpectator;
83
84		/** @var bool */
85		protected $autoTarget;
86
87		/** @var int */
88		protected $currentTargetId;
89
90
91		/** @var string */
92		protected $path;
93
94		/** @var string */
95		protected $language;
96
97		/** @var string */
98		protected $clientVersion;
99
100		/** @var string */
101		protected $clientTitleVersion;
102
103		/** @var string */
104		protected $iPAddress;
105
106		/** @var int */
107		protected $downloadRate;
108
109		/** @var int */
110		protected $uploadRate;
111
112		/** @var FileDesc */
113		protected $avatar;
114
115		/** @var Skin[] */
116		protected $skins;
117
118		/** @var mixed[] */
119		protected $ladderStats;
120
121		/** @var int */
122		protected $hoursSinceZoneInscription;
123
124		/** @var string */
125		protected $broadcasterLogin;
126
127		/** @var string[] */
128		protected $allies = array();
129
130		/** @var string */
131		protected $clubLink;
132		/** @var int */
133		protected $rank;
134
135		/** @var int */
136		protected $bestTime;
137
138		/** @var int[] */
139		protected $bestCheckpoints;
140
141		/** @var int */
142		protected $score;
143
144		/** @var int */
145		protected $nbrLapsFinished;
146
147		/** @var float */
148		protected $ladderScore;
149
150		/**
151		* @return boolean
152		*/
153	1	public function isIsConnected()
154		{
155	1	return $this->isConnected;
156		}
157
158		/**
159		* @return string
160		*/
161	2	public function getNickName()
162		{
163	2	return $this->nickName;
164		}
165
166		/**
167		* @return int
168		*/
169	1	public function getPlayerId()
170		{
171	1	return $this->playerId;
172		}
173
174		/**
175		* @return int
176		*/
177	1	public function getTeamId()
178		{
179	1	return $this->teamId;
180		}
181
182		/**
183		* @return boolean
184		*/
185	1	public function isIsSpectator()
186		{
187	1	return $this->isSpectator;
188		}
189
190		/**
191		* @return boolean
192		*/
193	1	public function isIsInOfficialMode()
194		{
195	1	return $this->isInOfficialMode;
196		}
197
198		/**
199		* @return int
200		*/
201	1	public function getLadderRanking()
202		{
203	1	return $this->ladderRanking;
204		}
205
206		/**
207		* @return int
208		*/
209	1	public function getSpectatorStatus()
210		{
211	1	return $this->spectatorStatus;
212		}
213
214		/**
215		* @return int
216		*/
217	1	public function getFlags()
218		{
219	1	return $this->flags;
220		}
221
222		/**
223		* @return int
224		*/
225	1	public function getForceSpectator()
226		{
227	1	return $this->forceSpectator;
228		}
229
230		/**
231		* @return boolean
232		*/
233	1	public function isIsReferee()
234		{
235	1	return $this->isReferee;
236		}
237
238		/**
239		* @return boolean
240		*/
241	1	public function isIsPodiumReady()
242		{
243	1	return $this->isPodiumReady;
244		}
245
246		/**
247		* @return boolean
248		*/
249	1	public function isIsUsingStereoscopy()
250		{
251	1	return $this->isUsingStereoscopy;
252		}
253
254		/**
255		* @return boolean
256		*/
257	1	public function isIsManagedByAnOtherServer()
258		{
259	1	return $this->isManagedByAnOtherServer;
260		}
261
262		/**
263		* @return boolean
264		*/
265	2	public function isIsServer()
266		{
267	2	return $this->isServer;
268		}
269
270		/**
271		* @return boolean
272		*/
273	1	public function isHasPlayerSlot()
274		{
275	1	return $this->hasPlayerSlot;
276		}
277
278		/**
279		* @return boolean
280		*/
281	1	public function isIsBroadcasting()
282		{
283	1	return $this->isBroadcasting;
284		}
285
286		/**
287		* @return boolean
288		*/
289	1	public function isHasJoinedGame()
290		{
291	1	return $this->hasJoinedGame;
292		}
293
294		/**
295		* @return boolean
296		*/
297	5	public function isSpectator()
298		{
299	5	return $this->spectator;
300		}
301
302		/**
303		* @return boolean
304		*/
305	1	public function isTemporarySpectator()
306		{
307	1	return $this->temporarySpectator;
308		}
309
310		/**
311		* @return boolean
312		*/
313	1	public function isPureSpectator()
314		{
315	1	return $this->pureSpectator;
316		}
317
318		/**
319		* @return boolean
320		*/
321	1	public function isAutoTarget()
322		{
323	1	return $this->autoTarget;
324		}
325
326		/**
327		* @return int
328		*/
329	1	public function getCurrentTargetId()
330		{
331	1	return $this->currentTargetId;
332		}
333
334		/**
335		* @return string
336		*/
337	1	public function getPath()
338		{
339	1	return $this->path;
340		}
341
342		/**
343		* @return string
344		*/
345	1	public function getLanguage()
346		{
347	1	return $this->language;
348		}
349
350		/**
351		* @return string
352		*/
353	2	public function getClientVersion()
354		{
355	2	return $this->clientVersion;
356		}
357
358		/**
359		* @return string
360		*/
361	1	public function getClientTitleVersion()
362		{
363	1	return $this->clientTitleVersion;
364		}
365
366		/**
367		* @return string
368		*/
369	1	public function getIPAddress()
370		{
371	1	return $this->iPAddress;
372		}
373
374		/**
375		* @return int
376		*/
377	1	public function getDownloadRate()
378		{
379	1	return $this->downloadRate;
380		}
381
382		/**
383		* @return int
384		*/
385	1	public function getUploadRate()
386		{
387	1	return $this->uploadRate;
388		}
389
390		/**
391		* @return FileDesc
392		*/
393	1	public function getAvatar()
394		{
395	1	return $this->avatar;
396		}
397
398		/**
399		* @return Skin[]
400		*/
401	1	public function getSkins()
402		{
403	1	return $this->skins;
404		}
405
406		/**
407		* @return \mixed[]
408		*/
409	1	public function getLadderStats()
410		{
411	1	return $this->ladderStats;
412		}
413
414		/**
415		* @return int
416		*/
417	1	public function getHoursSinceZoneInscription()
418		{
419	1	return $this->hoursSinceZoneInscription;
420		}
421
422		/**
423		* @return string
424		*/
425	1	public function getBroadcasterLogin()
426		{
427	1	return $this->broadcasterLogin;
428		}
429
430		/**
431		* @return string[]
432		*/
433	1	public function getAllies()
434		{
435	1	return $this->allies;
436		}
437
438		/**
439		* @return string
440		*/
441	1	public function getClubLink()
442		{
443	1	return $this->clubLink;
444		}
445
446		/**
447		* @return int
448		*/
449	1	public function getRank()
450		{
451	1	return $this->rank;
452		}
453
454		/**
455		* @return int
456		*/
457	1	public function getBestTime()
458		{
459	1	return $this->bestTime;
460		}
461
462		/**
463		* @return integer[]
464		*/
465	1	public function getBestCheckpoints()
466		{
467	1	return $this->bestCheckpoints;
468		}
469
470		/**
471		* @return int
472		*/
473	1	public function getScore()
474		{
475	1	return $this->score;
476		}
477
478		/**
479		* @return int
480		*/
481	1	public function getNbrLapsFinished()
482		{
483	1	return $this->nbrLapsFinished;
484		}
485
486		/**
487		* @return float
488		*/
489	1	public function getLadderScore()
490		{
491	1	return $this->ladderScore;
492		}
493
494		/**
495		* @return string
496		*/
497	6	public function getLogin()
498		{
499	6	return $this->login;
500		}
501
502		/**
503		* @param \Maniaplanet\DedicatedServer\Structures\Player\|array $data
504		*
505		* @return $this
506		*/
507	9	function merge($data)
		0 ignored issues – show Best Practice introduced 2017-03-12 18:39 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
508		{
509	9	foreach ($data as $key => $value) {
		0 ignored issues – show Bug introduced 2017-03-13 18:53 UTC by Report Bug Copy Issue Report The expression `$data` of type `object<Maniaplanet\Dedic...tructures\Player>\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
510	9	$this->$key = $value;
511	9	}
512
513	9	return $this;
514		}
515		}
516

eXpansionPluginPack / eXpansion2

Push — master ( cac559...b1b643 )

Player B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

45 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like