JoinLeaveMessages::onPlayerDisconnect() - Code Metrics - Inspection of "WIP : Dev" - eXpansionPluginPack/eXpansion2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#22)

unknown

created 2017-03-20 21:06 UTC

JoinLeaveMessages::onPlayerDisconnect() A

↳ Parent: JoinLeaveMessages

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	7
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	7
loc	7
rs	9.4285
c	0
b	0
f	0
ccs	0
cts	7
cp	0
cc	2
eloc	4
nc	2
nop	2
crap	6

<?php

namespace eXpansion\Bundle\JoinLeaveMessages\Plugins;

use eXpansion\Core\DataProviders\Listener\PlayerDataListenerInterface;
use eXpansion\Core\Services\Console;
use eXpansion\Core\Storage\Data\Player;
use Maniaplanet\DedicatedServer\Connection;

class JoinLeaveMessages implements PlayerDataListenerInterface
{
    /** @var Connection  */
    protected $connection;
    /** @var Console  */
    protected $console;
    /** @var bool  */
    private $enabled = true;

    /**
     * JoinLeaveMessages constructor.
     *
     * @param Connection $connection
     * @param Console $console
     */
    function __construct(Connection $connection, Console $console)

    {
        $this->connection = $connection;
        $this->console = $console;
    }

    /**
     * @inheritdoc
     */
    public function onRun()
    {
        // @todo make this callback work!
        $this->enabled = true;
    }

    /**
     * @inheritdoc
     */
    public function onPlayerConnect(Player $player)

    {
        $msg = '$fffHello, ' . $player->getNickName() . '  $n$fff($888' . $player->getLogin() . '$fff)';
        if ($this->enabled) {
            $this->connection->chatSendServerMessage($msg);
        }
    }

    /**
     * @inheritdoc
     */
    public function onPlayerDisconnect(Player $player, $disconnectionReason)

    {
        $msg = '$fffSee you, ' . $player->getNickName() . '  $n$fff($888' . $player->getLogin() . '$fff)';
        if ($this->enabled) {
            $this->connection->chatSendServerMessage($msg);
        }
    }

    /**
     * @inheritdoc
     */
    public function onPlayerInfoChanged(Player $oldPlayer, Player $player)
    {
    }

    /**
     * @inheritdoc
     */
    public function onPlayerAlliesChanged(Player $oldPlayer, Player $player)
    {
    }
}


1		<?php
2
3		namespace eXpansion\Bundle\JoinLeaveMessages\Plugins;
4
5		use eXpansion\Core\DataProviders\Listener\PlayerDataListenerInterface;
6		use eXpansion\Core\Services\Console;
7		use eXpansion\Core\Storage\Data\Player;
8		use Maniaplanet\DedicatedServer\Connection;
9
10		class JoinLeaveMessages implements PlayerDataListenerInterface
11		{
12		/** @var Connection */
13		protected $connection;
14		/** @var Console */
15		protected $console;
16		/** @var bool */
17		private $enabled = true;
18
19		/**
20		* JoinLeaveMessages constructor.
21		*
22		* @param Connection $connection
23		* @param Console $console
24		*/
25		function __construct(Connection $connection, Console $console)
		0 ignored issues – show Best Practice introduced 2017-03-20 19:36 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
26		{
27		$this->connection = $connection;
28		$this->console = $console;
29		}
30
31		/**
32		* @inheritdoc
33		*/
34		public function onRun()
35		{
36		// @todo make this callback work!
37		$this->enabled = true;
38		}
39
40		/**
41		* @inheritdoc
42		*/
43	View Code Duplication	public function onPlayerConnect(Player $player)
		0 ignored issues – show Duplication introduced 2017-03-20 19:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		{
45		$msg = '$fffHello, ' . $player->getNickName() . ' $n$fff($888' . $player->getLogin() . '$fff)';
46		if ($this->enabled) {
47		$this->connection->chatSendServerMessage($msg);
48		}
49		}
50
51		/**
52		* @inheritdoc
53		*/
54	View Code Duplication	public function onPlayerDisconnect(Player $player, $disconnectionReason)
		0 ignored issues – show Duplication introduced 2017-03-20 19:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		{
56		$msg = '$fffSee you, ' . $player->getNickName() . ' $n$fff($888' . $player->getLogin() . '$fff)';
57		if ($this->enabled) {
58		$this->connection->chatSendServerMessage($msg);
59		}
60		}
61
62		/**
63		* @inheritdoc
64		*/
65		public function onPlayerInfoChanged(Player $oldPlayer, Player $player)
66		{
67		}
68
69		/**
70		* @inheritdoc
71		*/
72		public function onPlayerAlliesChanged(Player $oldPlayer, Player $player)
73		{
74		}
75		}
76

eXpansionPluginPack / eXpansion2

Pull Request — master (#22)

JoinLeaveMessages::onPlayerDisconnect() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like