GenDummyRecordsCommand::execute() - Code Metrics - eXpansionPluginPack/eXpansion2 - Measure and Improve Code Quality continuously with Scrutinizer

GenDummyRecordsCommand::execute() B
last analyzed 2020-03-13 11:49 UTC

↳ Parent: GenDummyRecordsCommand

Complexity

Conditions	8
Paths	16

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	72

Importance

Changes

Metric	Value
dl	0
loc	85
ccs	0
cts	61
cp	0
rs	7.0828
c	0
b	0
f	0
cc	8
nc	16
nop	2
crap	72

How to fix Long Method

<?php

namespace eXpansion\Bundle\LocalRecords\Command;

use eXpansion\Bundle\LocalRecords\Model\Map\RecordTableMap;
use eXpansion\Bundle\LocalRecords\Model\Record;
use eXpansion\Bundle\LocalRecords\Model\RecordQueryBuilder;
use eXpansion\Bundle\Maps\Model\Base\MapQuery;
use eXpansion\Bundle\Maps\Model\MapQueryBuilder;
use eXpansion\Framework\Core\Services\Console;
use eXpansion\Framework\Core\Storage\MapStorage;
use eXpansion\Framework\PlayersBundle\Model\Map\PlayerTableMap;
use eXpansion\Framework\PlayersBundle\Model\Player;
use eXpansion\Framework\PlayersBundle\Model\PlayerQueryBuilder;
use Maniaplanet\DedicatedServer\Connection;
use Propel\Runtime\Propel;
use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
use Symfony\Component\Console\Helper\ProgressBar;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;


/**
 * Class Records
 *
 * @author  reaby
 */
class GenDummyRecordsCommand extends ContainerAwareCommand
{
    /**
     * @var MapStorage
     */
    private $mapStorage;
    /**
     * @var PlayerQueryBuilder
     */
    private $playerQueryBuilder;
    /**
     * @var RecordQueryBuilder
     */
    private $recordQueryBuilder;
    /**
     * @var Console
     */
    private $console;
    /**
     * @var MapQueryBuilder
     */
    private $mapQuery;

    /**
     * ScriptPanel constructor.
     *
     * @param MapStorage         $mapStorage
     * @param PlayerQueryBuilder $playerQueryBuilder
     * @param RecordQueryBuilder $recordQueryBuilder
     * @param MapQueryBuilder    $mapQuery
     * @param Console            $console
     */
    public function __construct(

        MapStorage $mapStorage,
        PlayerQueryBuilder $playerQueryBuilder,
        RecordQueryBuilder $recordQueryBuilder,
        MapQueryBuilder $mapQuery,
        Console $console
    ) {
        parent::__construct();
        $this->mapStorage = $mapStorage;
        $this->playerQueryBuilder = $playerQueryBuilder;
        $this->recordQueryBuilder = $recordQueryBuilder;
        $this->mapQuery = $mapQuery;
        $this->console = $console;
    }

    /**
     * @inheritdoc
     */
    protected function configure()
    {
        $this
            // the name of the command (the part after "bin/console")
            ->setName('eXpansion:testing:generateTestData')
            // the short description shown while running "php bin/console list"
            ->setDescription('creates defined number of users with records to all maps.')
            // the full command description shown when running the command with
            // the "--help" option
            ->setHelp('This command generates defined number of users and records to each map...');
        $this
            // configure an argument
            ->addArgument('count', InputArgument::REQUIRED, 'The number of users and records to generate.');

    }

    /**
     * @inheritdoc
     */
    public function execute(InputInterface $input, OutputInterface $output)
    {
        $this->console->init($output, null);

        $count = $input->getArgument('count');
        $this->console->writeln('Checking if there\'s enough players');

        $preAdd = $this->playerQueryBuilder->findDummy();

        if (count($preAdd) < $count) {

            $this->console->writeln("Generating missing players up to $count");
            $progress = new ProgressBar($output, $count);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $progress->start();
            $progress->advance(count($preAdd));

            $con = Propel::getWriteConnection(PlayerTableMap::DATABASE_NAME);
            $con->beginTransaction();

            for ($x = count($preAdd); $x < $count; $x++) {
                $player = new Player();
                $login = "dummyplayer_$x";
                $player->setNickname($login);
                $player->setNicknameStripped($login);
                $player->setLogin($login);
                $player->setPath("World|Hello");
                $player->save();
                $progress->advance();
            }
            $con->commit();
            $progress->finish();
        }

        unset($preAdd);

        /** @var Player[] $players */
        $players = $this->playerQueryBuilder->findDummy();

        $this->console->writeln("Generating maximum of $count records for all maps on server");
        $maps = $this->mapQuery->getAllMaps();

        $con = Propel::getWriteConnection(RecordTableMap::DATABASE_NAME);
        $i = 1;
        foreach ($maps as $m => $map) {
            $records = $this->recordQueryBuilder->getMapRecords($map->getMapuid(), 1, "asc", 1000);


            $idsUsed = [];
            if (count($records) < $count) {
                foreach ($records as $record) {
                    $idsUsed[] = $record->getPlayerId();
                }
                $this->console->writeln("Generating records for map ".$i."/".count($maps)." -> ".$map->getName());
                $con->beginTransaction();

                $record = new Record();
                $record->setNblaps(1);
                $record->setNbFinish(1);
                $record->setMapuid($map->getMapuid());
                $record->setCreatedAt(new \DateTime());
                $record->setCheckpoints([]);
                $progress = new ProgressBar($output, $count - count($records));
                $progress->start();
                for ($x = (count($records) + 1); $x < $count; $x++) {
                    if (!in_array($x, $idsUsed)) {
                        $rec = clone $record;
                        $rec->setScore(mt_rand($map->getGoldtime(), $map->getGoldtime() * 5));
                        $rec->setPlayerId($players[$x-1]->getId());
                        $rec->save();
                        $progress->advance();
                    }
                }
                $con->commit();
                $progress->finish();
                $i++;
                RecordTableMap::clearInstancePool();
                RecordTableMap::clearRelatedInstancePool();

            } else {
                $this->console->writeln("skipping map, records alreaady set!");
            }
        }
        PlayerTableMap::clearInstancePool();
        PlayerTableMap::clearRelatedInstancePool();
    }
}


1			<?php
2
3			namespace eXpansion\Bundle\LocalRecords\Command;
4
5			use eXpansion\Bundle\LocalRecords\Model\Map\RecordTableMap;
6			use eXpansion\Bundle\LocalRecords\Model\Record;
7			use eXpansion\Bundle\LocalRecords\Model\RecordQueryBuilder;
8			use eXpansion\Bundle\Maps\Model\Base\MapQuery;
9			use eXpansion\Bundle\Maps\Model\MapQueryBuilder;
10			use eXpansion\Framework\Core\Services\Console;
11			use eXpansion\Framework\Core\Storage\MapStorage;
12			use eXpansion\Framework\PlayersBundle\Model\Map\PlayerTableMap;
13			use eXpansion\Framework\PlayersBundle\Model\Player;
14			use eXpansion\Framework\PlayersBundle\Model\PlayerQueryBuilder;
15			use Maniaplanet\DedicatedServer\Connection;
16			use Propel\Runtime\Propel;
17			use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
18			use Symfony\Component\Console\Helper\ProgressBar;
19			use Symfony\Component\Console\Input\InputArgument;
20			use Symfony\Component\Console\Input\InputInterface;
21			use Symfony\Component\Console\Output\OutputInterface;
22
23
24			/**
25			* Class Records
26			*
27			* @author reaby
28			*/
29			class GenDummyRecordsCommand extends ContainerAwareCommand
30			{
31			/**
32			* @var MapStorage
33			*/
34			private $mapStorage;
35			/**
36			* @var PlayerQueryBuilder
37			*/
38			private $playerQueryBuilder;
39			/**
40			* @var RecordQueryBuilder
41			*/
42			private $recordQueryBuilder;
43			/**
44			* @var Console
45			*/
46			private $console;
47			/**
48			* @var MapQueryBuilder
49			*/
50			private $mapQuery;
51
52			/**
53			* ScriptPanel constructor.
54			*
55			* @param MapStorage $mapStorage
56			* @param PlayerQueryBuilder $playerQueryBuilder
57			* @param RecordQueryBuilder $recordQueryBuilder
58			* @param MapQueryBuilder $mapQuery
59			* @param Console $console
60			*/
61	2	View Code Duplication	public function __construct(
			0 ignored issues – show Duplication introduced 2018-02-27 17:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
62			MapStorage $mapStorage,
63			PlayerQueryBuilder $playerQueryBuilder,
64			RecordQueryBuilder $recordQueryBuilder,
65			MapQueryBuilder $mapQuery,
66			Console $console
67			) {
68	2		parent::__construct();
69	2		$this->mapStorage = $mapStorage;
70	2		$this->playerQueryBuilder = $playerQueryBuilder;
71	2		$this->recordQueryBuilder = $recordQueryBuilder;
72	2		$this->mapQuery = $mapQuery;
73	2		$this->console = $console;
74	2		}
75
76			/**
77			* @inheritdoc
78			*/
79	2		protected function configure()
80			{
81			$this
82			// the name of the command (the part after "bin/console")
83	2		->setName('eXpansion:testing:generateTestData')
84			// the short description shown while running "php bin/console list"
85	2		->setDescription('creates defined number of users with records to all maps.')
86			// the full command description shown when running the command with
87			// the "--help" option
88	2		->setHelp('This command generates defined number of users and records to each map...');
89			$this
90			// configure an argument
91	2		->addArgument('count', InputArgument::REQUIRED, 'The number of users and records to generate.');
92
93	2		}
94
95			/**
96			* @inheritdoc
97			*/
98			public function execute(InputInterface $input, OutputInterface $output)
99			{
100			$this->console->init($output, null);
101
102			$count = $input->getArgument('count');
103			$this->console->writeln('Checking if there\'s enough players');
104
105			$preAdd = $this->playerQueryBuilder->findDummy();
106
107			if (count($preAdd) < $count) {
108
109			$this->console->writeln("Generating missing players up to $count");
110			$progress = new ProgressBar($output, $count);
			0 ignored issues – show Documentation introduced 2020-02-27 08:41 UTC by Report Bug Copy Issue Report `$count` is of type `string\|array<integer,string>`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
111			$progress->start();
112			$progress->advance(count($preAdd));
113
114			$con = Propel::getWriteConnection(PlayerTableMap::DATABASE_NAME);
115			$con->beginTransaction();
116
117			for ($x = count($preAdd); $x < $count; $x++) {
118			$player = new Player();
119			$login = "dummyplayer_$x";
120			$player->setNickname($login);
121			$player->setNicknameStripped($login);
122			$player->setLogin($login);
123			$player->setPath("World\|Hello");
124			$player->save();
125			$progress->advance();
126			}
127			$con->commit();
128			$progress->finish();
129			}
130
131			unset($preAdd);
132
133			/** @var Player[] $players */
134			$players = $this->playerQueryBuilder->findDummy();
135
136			$this->console->writeln("Generating maximum of $count records for all maps on server");
137			$maps = $this->mapQuery->getAllMaps();
138
139			$con = Propel::getWriteConnection(RecordTableMap::DATABASE_NAME);
140			$i = 1;
141			foreach ($maps as $m => $map) {
142			$records = $this->recordQueryBuilder->getMapRecords($map->getMapuid(), 1, "asc", 1000);
143
144
145			$idsUsed = [];
146			if (count($records) < $count) {
147			foreach ($records as $record) {
148			$idsUsed[] = $record->getPlayerId();
149			}
150			$this->console->writeln("Generating records for map ".$i."/".count($maps)." -> ".$map->getName());
151			$con->beginTransaction();
152
153			$record = new Record();
154			$record->setNblaps(1);
155			$record->setNbFinish(1);
156			$record->setMapuid($map->getMapuid());
157			$record->setCreatedAt(new \DateTime());
158			$record->setCheckpoints([]);
159			$progress = new ProgressBar($output, $count - count($records));
160			$progress->start();
161			for ($x = (count($records) + 1); $x < $count; $x++) {
162			if (!in_array($x, $idsUsed)) {
163			$rec = clone $record;
164			$rec->setScore(mt_rand($map->getGoldtime(), $map->getGoldtime() * 5));
165			$rec->setPlayerId($players[$x-1]->getId());
166			$rec->save();
167			$progress->advance();
168			}
169			}
170			$con->commit();
171			$progress->finish();
172			$i++;
173			RecordTableMap::clearInstancePool();
174			RecordTableMap::clearRelatedInstancePool();
175
176			} else {
177			$this->console->writeln("skipping map, records alreaady set!");
178			}
179			}
180			PlayerTableMap::clearInstancePool();
181			PlayerTableMap::clearRelatedInstancePool();
182			}
183			}
184

eXpansionPluginPack / eXpansion2

GenDummyRecordsCommand::execute() B last analyzed 2020-03-13 11:49 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

GenDummyRecordsCommand::execute() B
last analyzed 2020-03-13 11:49 UTC