eXpansion\Framework\Core\Helpers\ChatNotification

Complexity

Total Complexity

11

Size/Duplication

Total Lines	113
Duplicated Lines	11.5 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

70%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getMessage()	0	4	1
A	getMessages()	0	4	1
A	__construct()	13	13	1
B	sendMessage()	0	33	8

<?php

namespace eXpansion\Framework\Core\Helpers;

use eXpansion\Framework\Core\Model\Helpers\ChatNotificationInterface;
use eXpansion\Framework\Core\Model\UserGroups\Group;
use eXpansion\Framework\Core\Services\Console;
use eXpansion\Framework\Core\Services\DedicatedConnection\Factory;
use eXpansion\Framework\Core\Storage\PlayerStorage;
use Maniaplanet\DedicatedServer\Connection;
use Maniaplanet\DedicatedServer\InvalidArgumentException;
use Maniaplanet\DedicatedServer\Xmlrpc\UnknownPlayerException;
use Psr\Log\LoggerInterface;

/**
 * Class ChatNotification
 *
 * @package eXpansion\Framework\Core\Helpers;
 * @author  oliver de Cramer <oliverde8@gmail.com>
 */
class ChatNotification implements ChatNotificationInterface
{
    /** @var  Factory */
    protected $factory;

    /** @var Translations */
    protected $translations;

    /** @var PlayerStorage */
    protected $playerStorage;

    /** @var Console */
    protected $console;
    /**
     * @var LoggerInterface
     */
    private $logger;

    /**
     * ChatNotification constructor.
     *
     * @param Factory $connectionFactory
     * @param Translations $translations
     * @param PlayerStorage $playerStorage
     * @param Console $console
     * @param LoggerInterface $logger
     */
    public function __construct(

This method seems to be duplicated in your project.

        Factory $connectionFactory,
        Translations $translations,
        PlayerStorage $playerStorage,
        Console $console,
        LoggerInterface $logger
    ) {
        $this->factory = $connectionFactory;
        $this->translations = $translations;
        $this->playerStorage = $playerStorage;
        $this->console = $console;
        $this->logger = $logger;
    }

    /**
     * Send message.
     *
     * @param string                     $messageId
     * @param string|string[]|Group|null $to
     * @param string[]                   $parameters
     */
    public function sendMessage($messageId, $to = null, $parameters = [])
    {
        $message = $messageId;

        if (is_string($to)) {
            $player = $this->playerStorage->getPlayerInfo($to);
            $message = $this->translations->getTranslation($messageId, $parameters, strtolower($player->getLanguage()));
        }

        if (is_array($to)) {
            $to = implode(",", $to);
            $message = $this->translations->getTranslations($messageId, $parameters);
        }

        if ($to instanceof Group) {

The class eXpansion\Framework\Core\Model\UserGroups\Group does not exist. Did you forget a USE statement, or did you not list all dependencies?

            $to = implode(",", $to->getLogins());
            $message = $this->translations->getTranslations($messageId, $parameters);
        }

        if ($to === null || $to instanceof Group) {

The class eXpansion\Framework\Core\Model\UserGroups\Group does not exist. Did you forget a USE statement, or did you not list all dependencies?

            $message = $this->translations->getTranslations($messageId, $parameters);
            $this->console->writeln(end($message)['Text']);
        }

        try {
            $this->factory->getConnection()->chatSendServerMessage($message, $to);

It seems like $message can also be of type array; however, Maniaplanet\DedicatedServer\Connection::chatSendServerMessage() does only seem to accept string|array<integer,array<integer,string>>, maybe add an additional type check?

        } catch (UnknownPlayerException $e) {
            $this->logger->info("can't send chat message: $message", ["to" => $to, "exception" => $e]);
            // Nothing to do, it happens.
        } catch (InvalidArgumentException $ex) {
            // Nothing to do
        }
    }

    /**
     * Return messageId with arguments as a string
     * Usage: used for retrieving partials for chat messages
     *  * defaults to English locale, without parameters
     *
     * @param string $messageId
     * @param array  $parameters
     * @param string $locale
     * @return string
     */
    public function getMessage($messageId, $parameters = [], $locale = "en")
    {
        return $this->translations->getTranslation($messageId, $parameters, $locale);
    }

    /**
     * Return messageId with arguments as a string
     * Usage: used for retrieving partials for chat messages
     *  * defaults to English locale, without parameters
     *
     * @param string $messageId
     * @param array  $parameters
     *
     * @return string[]
     */
    public function getMessages($messageId, $parameters = [])
    {
        return $this->translations->getTranslations($messageId, $parameters);
    }

}