OldSound\RabbitMqBundle\Command\DeclareCommand

Complexity

Total Complexity

8

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	configure()	0	7	1
A	execute()	0	36	6

<?php

namespace OldSound\RabbitMqBundle\Command;

use OldSound\RabbitMqBundle\Declarations\DeclarationsRegistry;
use OldSound\RabbitMqBundle\Declarations\Declarator;
use OldSound\RabbitMqBundle\RabbitMq\DynamicConsumer;

The type OldSound\RabbitMqBundle\RabbitMq\DynamicConsumer was not found. Maybe you did not declare it correctly or list all dependencies?

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Exception\InvalidOptionException;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\DependencyInjection\ContainerAwareTrait;

class DeclareCommand extends Command
{
    use ContainerAwareTrait;

    public function __construct(
        DeclarationsRegistry $declarationsRegistry
    ) {
        parent::__construct();
        $this->declarationsRegistry = $declarationsRegistry;

The property declarationsRegistry does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    protected function configure()
    {
        $this
            ->setName('rabbitmq:declare')
            ->addArgument('connection', InputArgument::OPTIONAL, 'Rabbitmq connection name', 'default')
            ->setDescription('Sets up the Rabbit MQ fabric')
            ->addOption('debug', 'd', InputOption::VALUE_NONE, 'Enable Debugging')
        ;
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        if (defined('AMQP_DEBUG') === false) {
            define('AMQP_DEBUG', (bool) $input->getOption('debug'));
        }

        $connection = $input->getArgument('connection');
        $channelAlias = sprintf('old_sound_rabbit_mq.channel.%s', $connection);

It seems like $connection can also be of type string[]; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

        if(!$this->container->has($channelAlias)) {
            throw new InvalidOptionException('Connection is not exist');
        };

        $channel = $this->container->get($channelAlias);

        // TODO $output->writeln('Setting up the Rabbit MQ fabric');

        $producers = [];
        $consumers = [];
        $exchanges = [];
        foreach ($producers as $producer) {
            // TODO $exchanges[] = $producer->exchange;
        }

        foreach ($consumers as $consumer) {
            // TODO $exchanges[] = $producer->exchange;
            //$bindings[] = $producer->exchange;
            //$queues[] = $producer->exchange;
        }

        $declarator = new Declarator($channel);

It seems like $channel can also be of type null; however, parameter $channel of OldSound\RabbitMqBundle\Declarations\Declarator::__construct() does only seem to accept PhpAmqpLib\Channel\AMQPChannel, maybe add an additional type check?

        // $declarator->declareExchanges($exchanges);
        foreach ($exchanges as $exchange) {
            $declarator->declareForExchange($exchange);

The call to OldSound\RabbitMqBundle\Declarations\Declarator::declareForExchange() has too few arguments starting with declarationsRegistry.

        }

        return 0;

    }
}