eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Tax/Model/Collector.php

Doc Comments +2 added lines

@@ -73,6 +73,7 @@ 
      * @param array
      * @param string
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function _nullCoalesce(array $arr, $key, $default)
@@ -110,6 +111,7 @@ 
      * Set whether the last tax request made was successful.
      *
      * @param bool
+     * @param boolean $success
      * @return self
      */
     public function setTaxRequestSuccess($success)

Spacing +5 added lines, -5 removed lines

@@ -138,7 +138,7 @@ 
     {
         return array_filter(
             $this->getTaxRecords(),
-            function ($record) use ($addressId) {
+            function($record) use ($addressId) {
                 return $record->getAddressId() === $addressId;
             }
         );
@@ -154,7 +154,7 @@ 
     {
         return array_filter(
             $this->getTaxRecords(),
-            function ($record) use ($itemId) {
+            function($record) use ($itemId) {
                 return $record->getItemId() === $itemId;
             }
         );
@@ -210,7 +210,7 @@ 
     {
         return array_filter(
             $this->getTaxDuties(),
-            function ($duty) use ($addressId) {
+            function($duty) use ($addressId) {
                 return $duty->getAddressId() === $addressId;
             }
         );
@@ -248,7 +248,7 @@ 
     {
         return array_filter(
             $this->getTaxFees(),
-            function ($fee) use ($itemId) {
+            function($fee) use ($itemId) {
                 return $fee->getItemId() === $itemId;
             }
         );
@@ -264,7 +264,7 @@ 
     {
         return array_filter(
             $this->getTaxFees(),
-            function ($fee) use ($addressId) {
+            function($fee) use ($addressId) {
                 return $fee->getAddressId() === $addressId;
             }
         );

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Tax/Model/Fee.php

Doc Comments +1 added lines

@@ -118,6 +118,7 @@
 
     /**
      * @param string
+     * @param string $type
      * @return string
      */
     public function setType($type)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Tax/Model/Order/Create/Order.php

Doc Comments +2 added lines, -1 removed lines

@@ -63,7 +63,8 @@
      * @param string
      * @param array
      * @param mixed
-     * @return mixed
+     * @param string $key
+     * @return EbayEnterprise_Tax_Model_Collector
      */
     protected function _nullCoalesce(array $arr, $key, $default)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Tax/Model/Order/Create/Orderitem.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,9 +13,9 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
+use eBayEnterprise\RetailOrderManagement\Payload\Order\IDiscountContainer;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderItem;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\ITaxContainer;
-use eBayEnterprise\RetailOrderManagement\Payload\Order\IDiscountContainer;
 
 /**
  * Adds Tax information to an OrderItem payload and its sub payloads.

Spacing +2 added lines, -2 removed lines

@@ -247,7 +247,7 @@ 
             // immediate remediation.
             $feeTaxes = array_filter(
                 $feeTaxRecords,
-                function ($taxRecord) use ($feeId) {
+                function($taxRecord) use ($feeId) {
                     return $feeId && $feeId === $taxRecord->getFeeId();
                 }
             );
@@ -316,7 +316,7 @@ 
             // now, at least, it should be a small enough data set to not demand
             // immediate remediation.
             $this->_addTaxRecordsToContainer(
-                array_filter($taxRecords, function ($taxRecord) use ($discountId) {
+                array_filter($taxRecords, function($taxRecord) use ($discountId) {
                     return $discountId && $taxRecord->getDiscountId() == $discountId;
                 }),
                 $discountPayload

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Tax/Model/Order/Create/Shipgroup.php

Doc Comments +2 added lines, -1 removed lines

@@ -78,6 +78,7 @@ 
      * @param string
      * @param array
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function _nullCoalesce(array $arr, $key, $default)
@@ -134,7 +135,7 @@ 
     /**
      * Get the tax container for address level gifting taxes.
      *
-     * @return ITaxContainer
+     * @return Payload\Order\ITaxIterable
      */
     protected function _getTaxContainer()
     {

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
  */
 
 use eBayEnterprise\RetailOrderManagement\Payload\Order\IGifting;
-use eBayEnterprise\RetailOrderManagement\Payload\Order\ITax;
 
 /**
  * Adds Tax information to an OrderItem payload and its sub payloads.

Spacing +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
         // gifting, and do not indicate a calculation error for the record.
         return array_filter(
             $this->_taxCollector->getTaxRecords(),
-            function ($record) use ($addressId) {
+            function($record) use ($addressId) {
                 return $record->getAddressId() === $addressId
                     && $record->getTaxSource() === EbayEnterprise_Tax_Model_Record::SOURCE_ADDRESS_GIFTING;
             }

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Tax/Model/Request/Builder/Address.php

Doc Comments +3 added lines, -2 removed lines

@@ -109,6 +109,7 @@ 
      * @param string
      * @param array
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function _nullCoalesce(array $arr, $key, $default)
@@ -119,7 +120,7 @@ 
     /**
      * Get the destination payload for the address.
      *
-     * @return IDestination|null
+     * @return IDestination
      */
     public function getDestinationPayload()
     {
@@ -129,7 +130,7 @@ 
     /**
      * Get the ship group payload for the address.
      *
-     * @return IShipGroup|null
+     * @return IShipGroup
      */
     public function getShipGroupPayload()
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,8 +13,8 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\IShipGroupIterable;
 use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\IDestinationIterable;
+use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\IShipGroupIterable;
 
 class EbayEnterprise_Tax_Model_Request_Builder_Address
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Tax/Model/Request/Builder/Item.php

Doc Comments +2 added lines, -1 removed lines

@@ -127,6 +127,7 @@ 
      * @param string
      * @param array
      * @param mixed
+     * @param string $key
      * @return mixed
      */
     protected function _nullCoalesce(array $arr, $key, $default)
@@ -137,7 +138,7 @@ 
     /**
      * Get the order item payload for the item.
      *
-     * @return IOrderItemRequest|null
+     * @return IOrderItemRequest
      */
     public function getOrderItemPayload()
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,9 +13,9 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
+use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\IDiscountContainer;
 use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\IOrderItemRequest;
 use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\IOrderItemRequestIterable;
-use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\IDiscountContainer;
 
 class EbayEnterprise_Tax_Model_Request_Builder_Item
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Tax/Model/Response/Parser/Address.php

Doc Comments +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
      * nearly identical steps from being repeated for each item for each type of
      * tax data.
      *
-     * @return EbayEnterprise_Tax_Model_Record[]
+     * @return EbayEnterprise_Tax_Model_Response_Parser_Address
      */
     protected function _extractTaxData()
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,8 +13,8 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\ITaxedShipGroup;
 use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\ITaxedOrderItem;
+use eBayEnterprise\RetailOrderManagement\Payload\TaxDutyFee\ITaxedShipGroup;
 
 class EbayEnterprise_Tax_Model_Response_Parser_Address extends EbayEnterprise_Tax_Model_Response_Parser_Abstract
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Tax/Model/Response/Parser/Item.php

Doc Comments +1 added lines, -1 removed lines

@@ -244,7 +244,7 @@
     /**
      * Extract tax records from a gifting payload.
      *
-     * @return EbayEnterprise_Tax_Model_Record
+     * @return EbayEnterprise_Tax_Model_Record[]
      */
     protected function _extractGiftingTaxRecords()
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {