eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Order/Helper/Map/Abstract.php

Doc Comments +4 added lines, -4 removed lines

@@ -50,7 +50,7 @@ 
      * @param  array
      * @param  string $field Valid array key
      * @param  mixed
-     * @return mixed
+     * @return EbayEnterprise_Eb2cCore_Model_Config_Registry
      */
     protected function nullCoalesce(array $arr, $field, $default)
     {
@@ -72,7 +72,7 @@ 
      *
      * @param  IPayload
      * @param  string
-     * @return mixed
+     * @return string
      */
     protected function _getStringValue(IPayload $payload, $getter)
     {
@@ -97,7 +97,7 @@ 
      *
      * @param  IPayload
      * @param  string
-     * @return mixed
+     * @return double
      */
     protected function _getFloatValue(IPayload $payload, $getter)
     {
@@ -109,7 +109,7 @@ 
      *
      * @param  IPayload
      * @param  string
-     * @return mixed
+     * @return boolean
      */
     protected function _getBooleanValue(IPayload $payload, $getter)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
      * @param array $initParams May have this key:
      *                          - 'multi_shipping' => EbayEnterprise_PayPal_Model_Multishipping
      */
-    public function __construct(array $initParams=[])
+    public function __construct(array $initParams = [])
     {
         list($this->multiShipping) = $this->checkTypes(
             $this->nullCoalesce($initParams, 'multi_shipping', Mage::getModel('ebayenterprise_paypal/multishipping'))

src/app/code/community/EbayEnterprise/Order/Helper/Search/Map.php

Doc Comments +5 added lines, -2 removed lines

@@ -52,6 +52,7 @@ 
      *
      * @param  IOrderSummary
      * @param  string
+     * @param string $getter
      * @return string | null
      */
     public function getDatetimeValue(IOrderSummary $summary, $getter)
@@ -65,7 +66,8 @@ 
      *
      * @param  IOrderSummary
      * @param  string
-     * @return mixed
+     * @param string $getter
+     * @return double
      */
     public function getFloatValue(IOrderSummary $summary, $getter)
     {
@@ -77,7 +79,8 @@ 
      *
      * @param  IOrderSummary
      * @param  string
-     * @return mixed
+     * @param string $getter
+     * @return boolean
      */
     public function getBooleanValue(IOrderSummary $summary, $getter)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Model/Cancel/Build/Request.php

Doc Comments +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
      * @param  array
      * @param  string $field Valid array key
      * @param  mixed
-     * @return mixed
+     * @return EbayEnterprise_Order_Helper_Data
      */
     protected function _nullCoalesce(array $arr, $field, $default)
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,8 +13,8 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderCancelRequest;
 use eBayEnterprise\RetailOrderManagement\Api\IBidirectionalApi;
+use eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderCancelRequest;
 
 class EbayEnterprise_Order_Model_Cancel_Build_Request implements EbayEnterprise_Order_Model_Cancel_Build_IRequest
 {

Spacing +1 added lines, -1 removed lines

@@ -124,6 +124,6 @@
     protected function _getReasonDescription()
     {
         $reasonCode = $this->_order->getCancelReasonCode();
-        return $reasonCode? $this->_orderHelper->getCancelReasonDescription($reasonCode) : null;
+        return $reasonCode ? $this->_orderHelper->getCancelReasonDescription($reasonCode) : null;
     }
 }

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Model/Create.php

Doc Comments +4 added lines, -3 removed lines

@@ -165,6 +165,7 @@ 
      * @param  string
      * @param  array
      * @param  mixed
+     * @param string $key
      * @return mixed
      */
     protected function _nullCoalesce($key, array $arr, $default)
@@ -343,7 +344,7 @@ 
      * so the SDK can use it.
      *
      * @param Mage_Customer_Model_Address_Abstract
-     * @return IMailingAddress
+     * @return IPhysicalAddress
      */
     protected function _getRomBillingAddress(Mage_Customer_Model_Address_Abstract $address)
     {
@@ -683,7 +684,7 @@ 
      *
      * @param Mage_Customer_Model_Address_Abstract
      * @param IOrderDestinationIterable Used to create the new email address destination payload
-     * @return IMailingAddressDestination
+     * @return IPhysicalAddress
      */
     protected function _buildPhysicalDestination(Mage_Customer_Model_Address_Abstract $address, IOrderDestinationIterable $destinations)
     {
@@ -759,7 +760,7 @@ 
      * convert a mage date string to a datetime.
      * if $dateString is invalid, return false.
      * @param  string
-     * @return DateTime|false
+     * @return DateTime
      */
     protected function _getAsDateTime($dateString)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Model/Create/Orderitem.php

Doc Comments +3 added lines

@@ -57,6 +57,7 @@ 
      * @param  string
      * @param  array
      * @param  mixed
+     * @param string $key
      * @return mixed
      */
     protected function nullCoalesce($key, array $ar, $default)
@@ -72,6 +73,7 @@ 
      * @param  int
      * @param  string
      * @param  bool
+     * @param integer $lineNumber
      * @return IOrderItem
      */
     public function buildOrderItem(
@@ -226,6 +228,7 @@ 
      * attribute
      * @param  string
      * @param  Mage_Sales_Model_Order_Item
+     * @param string $attributeCode
      * @return array
      */
     protected function getOptionInfo($attributeCode, Mage_Sales_Model_Order_Item $item)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Model/Create/Relationships.php

Doc Comments +6 added lines

@@ -53,6 +53,11 @@ 
         return func_get_args();
     }
 
+    /**
+     * @param string $key
+     *
+     * @return EbayEnterprise_Order_Model_Create_Relationships_IStorage
+     */
     protected function nullCoalesce(array $arr, $key, $default)
     {
         return isset($arr[$key]) ? $arr[$key] : $default;
@@ -91,6 +96,7 @@ 
      *
      * @param Mage_Sales_Model_Order_Item
      * @param bool
+     * @param boolean $isParentItemPayload
      */
     protected function addItemToRelationship(Mage_Sales_Model_Order_Item $keyItem, $isParentItemPayload)
     {

Spacing +1 added lines, -2 removed lines

@@ -111,8 +111,7 @@
      */
     protected function getOrCreateItemRelationship(Mage_Sales_Model_Order_Item $keyItem)
     {
-        $relationship = $this->storage->getRelationshipPayload($keyItem) ?:
-            $this->createRelationshipPayload($this->itemPayload);
+        $relationship = $this->storage->getRelationshipPayload($keyItem) ?: $this->createRelationshipPayload($this->itemPayload);
         $this->storage->addRelationship($keyItem, $relationship);
         return $relationship;
     }

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,8 +13,8 @@
  * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
-use eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderItem;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\IItemRelationship;
+use eBayEnterprise\RetailOrderManagement\Payload\Order\IOrderItem;
 
 /**
  * keeps track of relationship payloads

src/app/code/community/EbayEnterprise/Order/Model/Create/Relationships/IStorage.php

Doc Comments +1 added lines

@@ -34,6 +34,7 @@
      *
      * @param Mage_Sales_Model_Order_Item
      * @param IItemRelationship
+     * @return EbayEnterprise_Order_Model_Create_Relationships_Storage
      */
     public function addRelationship(
         Mage_Sales_Model_Order_Item $item,

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Model/Create/Relationships/Storage.php

Doc Comments +6 added lines

@@ -37,6 +37,12 @@
         return func_get_args();
     }
 
+    /**
+     * @param string $key
+     * @param SplObjectStorage $default
+     *
+     * @return SplObjectStorage
+     */
     protected function nullCoalesce(array $arr, $key, $default)
     {
         return isset($arr[$key]) ? $arr[$key] : $default;

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Order/Model/Detail/Process/Response.php

Unused Use Statements +4 added lines, -4 removed lines

@@ -14,14 +14,14 @@
  */
 
 use eBayEnterprise\RetailOrderManagement\Payload\IPayload;
-use eBayEnterprise\RetailOrderManagement\Payload\Order\Detail\IOrderDetailResponse;
-use eBayEnterprise\RetailOrderManagement\Payload\Order\IMailingAddress;
-use eBayEnterprise\RetailOrderManagement\Payload\Order\IEmailAddressDestination;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\Detail\IOrderDetailItem;
+use eBayEnterprise\RetailOrderManagement\Payload\Order\Detail\IOrderDetailResponse;
+use eBayEnterprise\RetailOrderManagement\Payload\Order\Detail\IOrderDetailStoredValueCardPayment;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\Detail\IShipment;
+use eBayEnterprise\RetailOrderManagement\Payload\Order\IEmailAddressDestination;
+use eBayEnterprise\RetailOrderManagement\Payload\Order\IMailingAddress;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\IPayment;
 use eBayEnterprise\RetailOrderManagement\Payload\Order\IShipGroup;
-use eBayEnterprise\RetailOrderManagement\Payload\Order\Detail\IOrderDetailStoredValueCardPayment;
 
 class EbayEnterprise_Order_Model_Detail_Process_Response extends Mage_Sales_Model_Order implements EbayEnterprise_Order_Model_Detail_Process_IResponse
 {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {