eBayEnterprise / magento-retail-order-management

src/app/code/community/EbayEnterprise/Catalog/Model/Observers.php

Doc Comments +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
      * @param  array
      * @param  string $field Valid array key
      * @param  mixed
-     * @return mixed
+     * @return EbayEnterprise_Eb2cCore_Model_Config_Registry
      */
     protected function nullCoalesce(array $arr, $field, $default)
     {

Indentation +18 added lines, -18 removed lines

@@ -1,17 +1,17 @@ 
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Catalog_Model_Observers
 {
@@ -25,12 +25,12 @@ 
         );
     }
 
-     /**
-     * Type hinting for self::__construct $initParams
-     *
-     * @param  EbayEnterprise_Eb2cCore_Model_Config_Registry
-     * @return array
-     */
+        /**
+         * Type hinting for self::__construct $initParams
+         *
+         * @param  EbayEnterprise_Eb2cCore_Model_Config_Registry
+         * @return array
+         */
     protected function checkTypes(EbayEnterprise_Eb2cCore_Model_Config_Registry $config)
     {
         return func_get_args();

src/app/code/community/EbayEnterprise/Catalog/Model/Pim.php

Doc Comments +1 added lines, -5 removed lines

@@ -114,10 +114,7 @@ 
     }
     /**
      * generate the outgoing product feed.
-     * @param  array  $productIds     list of product id's to include in the feed.
-     * @param  array  $feedTypeConfig configuration data for the current feed.
-     * @param  array  $stores         list of stores to use as context for getting values.
-     * @return array  array of full filepath where the feed files was saved.
+     * @return string  array of full filepath where the feed files was saved.
      */
     public function buildFeed()
     {
@@ -215,7 +212,6 @@ 
      *
      * @param  Mage_Catalog_Model_Resource_Product_Collection $products products for a specific store
      * @param  EbayEnterprise_Catalog_Model_Pim_Product_Collection $pimProducts collection of PIM Product instances
-     * @param  string $key
      * @param array $productIds
      * @return EbayEnterprise_Catalog_Model_Pim_Product_Collection $pimProducts collection of PIM Product instances
      */

Spacing +4 added lines, -5 removed lines

@@ -250,7 +250,7 @@ 
                 $logMessage = 'Product "{sku}" excluded from export.';
                 $this->_logger->warning($logMessage, $this->_context->getMetaData(__CLASS__, $logData));
                 $this->_logger->logException($e, $this->_context->getMetaData(__CLASS__, [], $e));
-                $excludedProductIds[]= $product->getId();
+                $excludedProductIds[] = $product->getId();
                 $pimProducts->deleteItem($pimProduct);
             }
         }
@@ -270,9 +270,8 @@ 
     protected function _getFeedAttributes($storeId)
     {
         $config = $this->_getFeedConfig();
-        return ((int) $storeId === (int) $this->_getDefaultStoreViewId())?
-            array_keys($config[self::KEY_MAPPINGS]) :
-            $this->_getTranslatableAttributes($config[self::KEY_MAPPINGS]);
+        return ((int) $storeId === (int) $this->_getDefaultStoreViewId()) ?
+            array_keys($config[self::KEY_MAPPINGS]) : $this->_getTranslatableAttributes($config[self::KEY_MAPPINGS]);
     }
     /**
      * get only translatable attributes
@@ -281,7 +280,7 @@ 
      */
     protected function _getTranslatableAttributes(array $mapAttributes)
     {
-        return array_filter(array_map(function ($key) use ($mapAttributes) {
+        return array_filter(array_map(function($key) use ($mapAttributes) {
                 return ($mapAttributes[$key]['translate'] === '1') ? $key : null;
         }, array_keys($mapAttributes)));
     }

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Catalog/Model/Pim/Attribute/Factory.php

Doc Comments +1 added lines, -3 removed lines

@@ -47,7 +47,6 @@ 
      * @param  string $attribute
      * @param  Mage_Catalog_Model_Product          $product
      * @param  EbayEnterprise_Dom_Document             $doc
-     * @param  array $key
      * @return EbayEnterprise_Catalog_Model_Pim_Attribute
      */
     public function getPimAttribute(
@@ -69,7 +68,6 @@ 
     /**
      * Get the attribute mapping. The result will be an empty array.
      * @param  string $attribute
-     * @param  string $key
      * @return array
      */
     protected function _getAttributeMapping($attribute, $config)
@@ -81,7 +79,7 @@ 
      * Lookup the callable described in the mapping xml to export this attribute for this product.
      *
      * @param array $callbackMapping
-     * @param $attribute
+     * @param string $attribute
      * @param Mage_Catalog_Model_Product $product
      * @param EbayEnterprise_Dom_Document $doc
      * @return array|null

Spacing +1 added lines, -2 removed lines

@@ -125,8 +125,7 @@
             'destination_xpath' => $callbackMapping['xml_dest'],
             'sku' => $product->getSku(),
             'language' => $callbackMapping['translate'] ?
-                $product->getPimLanguageCode() :
-                null,
+                $product->getPimLanguageCode() : null,
             'value' => $pimAttributeValue,
         );
     }

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Catalog/Model/Price/Event.php

Doc Comments +3 added lines, -3 removed lines

@@ -111,7 +111,7 @@ 
 
     /**
      * Get the "special_price" if there is one.
-     * @return float|null
+     * @return double
      */
     public function getSpecialPrice()
     {
@@ -134,7 +134,7 @@ 
      * format string or via a default.
      * @see self::_formatDate
      * @param  string|null $format Date format string to use
-     * @return string|null Formatted datetime
+     * @return string Formatted datetime
      */
     public function getSpecialFromDate($format = null)
     {
@@ -146,7 +146,7 @@ 
      * format string or via a default.
      * @see self::_formatDate
      * @param  string|null $format Date format string to use
-     * @return string|null Formatted datetime
+     * @return string Formatted datetime
      */
     public function getSpecialToDate($format = null)
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Catalog/Test/Helper/DataTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -862,8 +862,8 @@
     }
     /**
      * Test normalizing a product style id to match formatting for skus
-     * @param  string $style   The product style id
-     * @param  string $catalog The product catalog id
+     * @param  string $styleId   The product style id
+     * @param  string $catalogId The product catalog id
      * @dataProvider dataProvider
      */
     public function testNormalizeSku($styleId, $catalogId)

Spacing +4 added lines, -4 removed lines

@@ -243,17 +243,17 @@
      */
     public function testParseTranslations()
     {
-        $sampleInput = array (
-            array (
+        $sampleInput = array(
+            array(
                 'lang' => 'en-US',
                 'description' => 'An en-US translation',
             ),
-            array (
+            array(
                 'lang' => 'ja-JP',
                 'description' => 'ja-JP に変換',
             ),
         );
-        $expectedOutput = array (
+        $expectedOutput = array(
             'en-US' => 'An en-US translation',
             'ja-JP' => 'ja-JP に変換',
         );

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Catalog/Test/Helper/FeedTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
     /**
      * Test getting a DateTime object for a CreateDateAndTime from an import feed
      * @param string|null $feedTime  Create date and time in feed
-     * @param string $dateTimeStamp Expected timestamp
+     * @param string $dateTimeDate Expected timestamp
      * @dataProvider dataProvider
      */
     public function testGetDateTimeForFeedTime($feedTime, $dateTimeDate)

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Catalog/Test/Helper/PimTest.php

Doc Comments +4 added lines, -2 removed lines

@@ -952,6 +952,10 @@ 
         ));
         $this->assertSame($expected->saveXML(), $doc->saveXML());
     }
+
+    /**
+     * @param string $xml
+     */
     protected function _newDocument($xml = null)
     {
         $doc = Mage::helper('eb2ccore')->getNewDomDocument();
@@ -963,8 +967,6 @@ 
     }
     /**
      * verify a fragment is returned containing the product links
-     * @param  bool   $allowMessage
-     * @param  bool   $isVirtual
      * @SuppressWarnings(PHPMD.UnusedLocalVariable)
      */
     public function testPassProductLinks()

Spacing +6 added lines, -6 removed lines

@@ -86,7 +86,7 @@ 
         // return array containing config product's id and an empty array otherwise
         $this->configTypeResource->expects($this->any())
             ->method('getParentIdsByChild')
-            ->will($this->returnCallback(function ($childId) use ($configId, $simpleId) {
+            ->will($this->returnCallback(function($childId) use ($configId, $simpleId) {
                 return $childId === $simpleId ? array($configId) : array();
             }));
 
@@ -736,7 +736,7 @@ 
     public function testCreateDateTime()
     {
         $value = '2014-03-15 12:33:48';
-        $result     = '2014-03-15T12:33:48+00:00';
+        $result = '2014-03-15T12:33:48+00:00';
 
         $pimHelperMock = $this->getHelperMockBuilder('ebayenterprise_catalog/pim')
             ->disableOriginalConstructor()
@@ -753,7 +753,7 @@ 
     public function testCreateInteger()
     {
         $value = '12';
-        $result     = 12;
+        $result = 12;
 
         $pimHelperMock = $this->getHelperMockBuilder('ebayenterprise_catalog/pim')
             ->disableOriginalConstructor()
@@ -770,7 +770,7 @@ 
     public function testCreateDecimal()
     {
         $value = '12.677';
-        $result     = 12.677;
+        $result = 12.677;
 
         $pimHelperMock = $this->getHelperMockBuilder('ebayenterprise_catalog/pim')
             ->disableOriginalConstructor()
@@ -787,7 +787,7 @@ 
     public function testCreateBool()
     {
         $value = '1';
-        $result     = 'true';
+        $result = 'true';
 
         $pimHelperMock = $this->getHelperMockBuilder('ebayenterprise_catalog/pim')
             ->disableOriginalConstructor()
@@ -1000,7 +1000,7 @@ 
         $pimHelper->expects($this->any())
             ->method('passSKU')
             ->will($this->returnCallback(
-                function ($a, $b, $product, $doc) {
+                function($a, $b, $product, $doc) {
                     return $doc->createCDataSection($product->getSku());
                 }
             ));

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Catalog/Test/Model/Feed/CleanerTest.php

Doc Comments -2 removed lines

@@ -153,8 +153,6 @@
     /**
      * Test determining if a product is expected to have a configuratble parent
      * products.
-     * @param  Mage_Catalog_Model_Product $product
-     * @param  bool $hasParent
      */
     public function testGetAllParentConfigurableSkus()
     {

Spacing +2 added lines, -2 removed lines

@@ -518,10 +518,10 @@
         // Product links to try to make
         $linkUpdates = array(
             array(
-                'link_type' => $linkType, 'operation_type' => 'Add','link_to_unique_id' => '45-missing-link',
+                'link_type' => $linkType, 'operation_type' => 'Add', 'link_to_unique_id' => '45-missing-link',
             ),
             array(
-                'link_type' => $linkType, 'operation_type' => 'Add','link_to_unique_id' => '45-add-link',
+                'link_type' => $linkType, 'operation_type' => 'Add', 'link_to_unique_id' => '45-add-link',
             ),
             array(
                 'link_type' => $linkType, 'operation_type' => 'delete', 'link_to_unique_id' => '45-link-to-remove',

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {

src/app/code/community/EbayEnterprise/Catalog/Test/Model/Feed/CoreTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
 {
     /**
      * Get a mock Varien_Io_File object to sub out for a real one.
-     * @return Mock_Varien_File_Io
+     * @return PHPUnit_Framework_MockObject_MockBuilder
      */
     protected function _getMockFsTool()
     {

Indentation +12 added lines, -12 removed lines

@@ -1,17 +1,17 @@
 <?php
 /**
- * Copyright (c) 2013-2014 eBay Enterprise, Inc.
- *
- * NOTICE OF LICENSE
- *
- * This source file is subject to the Open Software License (OSL 3.0)
- * that is bundled with this package in the file LICENSE.md.
- * It is also available through the world-wide-web at this URL:
- * http://opensource.org/licenses/osl-3.0.php
- *
- * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
- * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
- */
+     * Copyright (c) 2013-2014 eBay Enterprise, Inc.
+     *
+     * NOTICE OF LICENSE
+     *
+     * This source file is subject to the Open Software License (OSL 3.0)
+     * that is bundled with this package in the file LICENSE.md.
+     * It is also available through the world-wide-web at this URL:
+     * http://opensource.org/licenses/osl-3.0.php
+     *
+     * @copyright   Copyright (c) 2013-2014 eBay Enterprise, Inc. (http://www.ebayenterprise.com/)
+     * @license     http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+     */
 
 class EbayEnterprise_Tax_Test_Model_Total_Quote_Address_TaxTest extends EcomDev_PHPUnit_Test_Case
 {